From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Gibson To: passt-dev@passt.top Subject: Re: [PATCH 08/12] clang-tidy: Disable 'readability-identifier-length' Date: Sat, 24 Sep 2022 13:06:35 +1000 Message-ID: In-Reply-To: <20220924010855.45e930d6@elisabeth> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6682502791518172250==" --===============6682502791518172250== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit On Sat, Sep 24, 2022 at 01:08:55AM +0200, Stefano Brivio wrote: > On Fri, 23 Sep 2022 17:20:34 +1000 > David Gibson wrote: > > > This check complains about any identifier of less than 3 characters. For > > locals and parameters this is often pointlessly verbose. Disable it. > > > > Signed-off-by: David Gibson > > --- > > Makefile | 6 +++++- > > 1 file changed, 5 insertions(+), 1 deletion(-) > > > > diff --git a/Makefile b/Makefile > > index 432ee7a..0598865 100644 > > --- a/Makefile > > +++ b/Makefile > > @@ -237,6 +237,10 @@ docs: README.md > > # > > # - concurrency-mt-unsafe > > # TODO: check again if multithreading is implemented > > +# > > +# - readability-identifier-length > > +# Complains about any identifier <3 characters, reasonable for > > +# globals, pointlessly verbose for locals and parameters. > > > > clang-tidy: $(SRCS) $(HEADERS) > > clang-tidy -checks=*,-modernize-*,\ > > @@ -260,7 +264,7 @@ clang-tidy: $(SRCS) $(HEADERS) > > -bugprone-easily-swappable-parameters,\ > > -readability-function-cognitive-complexity,\ > > -altera-struct-pack-align,\ > > - -concurrency-mt-unsafe \ > > + -concurrency-mt-unsafe,-readability-identifier-length \ > > I would rather keep those (unrelated) switches on different lines, I > find it's a bit easier to follow through the comments like that. > > I can change this on merge if you agree, unless you respin. I am respinning, so I've made this change. > I reviewed the rest of the series, it looks great to me, I have no > further observations -- but I haven't tested it yet. > -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --===============6682502791518172250== Content-Type: application/pgp-signature Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="signature.asc" MIME-Version: 1.0 LS0tLS1CRUdJTiBQR1AgU0lHTkFUVVJFLS0tLS0KCmlRSXpCQUVCQ0FBZEZpRUVvVUx4V3U0L1dz MGRCK1h0Z3lwWTRnRXdZU0lGQW1NdWREVUFDZ2tRZ3lwWTRnRXcKWVNLUzJ4QUF6NWZvaXg1YUJq NS9CMC9qK3k3ZVo0Z29ldGR5d09vSm9DUE9XWHpjTlU5OGFSQzgvSkZPeHNRbwplbFRRNm1pdms1 TEV4dFB3VkdsL3VtQmU3Zjh3OC9DY3BEcklmUHZ5Y0JkU3hMTlVLcTN4WVB0ZjBWWkZhbkNPCmxH VUxqM0lqOUtxNEZBWVdWS3cxWk9NOWxFbmQyVktHN3lUKzNYd1ZnM2RBMTRjWDcxdzJzcFVBaXhQ RzlXa1IKMEdzQlBhVGY2YVdWaGpPVmhrLzd3R0JSckRDMC9FVXp1ZTR3UUYyUzJHa0YvNTFHK2FF czVYRVd6aDZSZThtYgpDemw1K1N4Q0hHYTlCdWlKemhwMUpjVllhMGlIOVZnZENDVWdjYWtxUVR4 UHYvSUxxa2xSc3FPenVCNmhkY29GCjlNaE84ZzhIUEs3bzlBRlNZbnpzaCt5SjZMRG9PT2FSODFF YlphNS8zVDlQTzJwcmpaK3RWZHR3bmVwMi8vL00KSVY5dTRQQ0huMGRBNHpVdXpNL2thVzFxT0cr QjFwd3k3a216OGl5ZmU1QmJHSVlSb0dIbEczYThzS3AxNWFuWApGSnc5bUFoMXp1SnRtVG1qemE2 cUlJVmFXem0zNW9DV1J4OVh5V1hZT3hlNURxdnd2UEF0OGluMnFPL0ZIZTRaCjlqTjF1aTJUWk10 d3dJNHRPZmw5R3J2dmxSMmM3V1hJQnFxMnRQWGd6ZE1DNWI1dzZ4WWl0dW1md1F6OXdMZzYKaHA0 MHNxQWRCUjBiTDhXL2lvcFFkVnhxeVZycVdnZVJXRmdtR3U0UDV5ZnhGQTZGL21DYzhkS0w4ZklZ NjFWdgorZFR0ZTBqZFB0OHh6QTIrY1gvWEpXRzZCVnY0a0dWMW9xSTVPNHpSdWdRcUg4N2FwNk09 Cj1nYzVJCi0tLS0tRU5EIFBHUCBTSUdOQVRVUkUtLS0tLQo= --===============6682502791518172250==--