From: David Gibson <david@gibson.dropbear.id.au>
To: passt-dev@passt.top
Subject: Re: [PATCH 04/12] test: More robust wait for pasta/passt to be ready
Date: Sat, 24 Sep 2022 13:03:32 +1000 [thread overview]
Message-ID: <Yy5zhG7Gsmd3WMdj@yekko> (raw)
In-Reply-To: <20220924010813.75195993@elisabeth>
[-- Attachment #1: Type: text/plain, Size: 2160 bytes --]
On Sat, Sep 24, 2022 at 01:08:13AM +0200, Stefano Brivio wrote:
> On Fri, 23 Sep 2022 17:20:30 +1000
> David Gibson <david(a)gibson.dropbear.id.au> wrote:
>
> > When we start passt or pasta, it may take a short time to be ready to
> > handle packets, especially if running under valgrind. We have a
> > number of semi-arbitrary fixed sleeps to account for this.
> >
> > We can do this more robustly by exploiting the fact that pasta/passt
> > doesn't write its pidfile until it's ready to go, so if we wait for
> > the pidfile to be created, we can proceed with confidence.
> >
> > Signed-off-by: David Gibson <david(a)gibson.dropbear.id.au>
> > ---
> > test/lib/setup | 15 ++++++++++-----
> > 1 file changed, 10 insertions(+), 5 deletions(-)
> >
> > diff --git a/test/lib/setup b/test/lib/setup
> > index 7e3f6c3..dee7b46 100755
> > --- a/test/lib/setup
> > +++ b/test/lib/setup
> > @@ -54,7 +54,9 @@ setup_passt() {
> > context_run passt "make clean"
> > context_run passt "make valgrind"
> > context_run_bg passt "valgrind --max-stackframe=$((4 * 1024 * 1024)) --trace-children=yes --vgdb=no --error-exitcode=1 --suppressions=test/valgrind.supp ./passt ${__opts} -f -t 10001 -u 10001 -P ${STATESETUP}/passt.pid"
> > - sleep 5
> > +
> > + # pidfile isn't created until passt is listening
>
> Here,
>
> > + wait_for [ -f "${STATESETUP}/passt.pid" ]
> >
> > GUEST_CID=94557
> > context_run_bg qemu './qrap 5 qemu-system-$(uname -m)' \
> > @@ -99,7 +101,9 @@ setup_pasta() {
> > [ ${TRACE} -eq 1 ] && __opts="${__opts} --trace"
> >
> > context_run_bg passt "./pasta ${__opts} -f -t 10002 -T 10003 -u 10002 -U 10003 -P ${STATESETUP}/passt.pid ${__target_pid}"
> > - sleep 1
> > +
> > + # pidfile isn't created until pasta is ready
>
> and here, we have spaces instead of tabs. I can fix that up on merge,
> unless you respin anyway.
Oops, fixed, and I will be respinning.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-09-24 3:03 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-23 7:20 [PATCH 00/12] Assorted test fixes, batch 7 David Gibson
2022-09-23 7:20 ` [PATCH 01/12] test: Add wait_for() shell helper David Gibson
2022-09-23 23:07 ` Stefano Brivio
2022-09-24 2:59 ` David Gibson
2022-09-23 7:20 ` [PATCH 02/12] test: Remove unnecessary sleeps from layout functions David Gibson
2022-09-23 23:08 ` Stefano Brivio
2022-09-24 3:02 ` David Gibson
2022-09-23 7:20 ` [PATCH 03/12] test: Remove unnecessary sleeps from shutdown tests David Gibson
2022-09-23 7:20 ` [PATCH 04/12] test: More robust wait for pasta/passt to be ready David Gibson
2022-09-23 23:08 ` Stefano Brivio
2022-09-24 3:03 ` David Gibson [this message]
2022-09-23 7:20 ` [PATCH 05/12] test: Use --config-net for namespace setup David Gibson
2022-09-23 7:20 ` [PATCH 06/12] test: Simplify data handling for transfer tests David Gibson
2022-09-23 23:08 ` Stefano Brivio
2022-09-23 7:20 ` [PATCH 07/12] test: Remove unneccessary pane naming from layout_two_guests David Gibson
2022-09-23 7:20 ` [PATCH 08/12] clang-tidy: Disable 'readability-identifier-length' David Gibson
2022-09-23 23:08 ` Stefano Brivio
2022-09-24 3:06 ` David Gibson
2022-09-23 7:20 ` [PATCH 09/12] cppcheck: Avoid excessive scanning due to system headers David Gibson
2022-09-23 7:20 ` [PATCH 10/12] cppcheck: Run quietly David Gibson
2022-09-23 7:20 ` [PATCH 11/12] Makefile: Simplify getting target triple for compiler David Gibson
2022-09-23 7:20 ` [PATCH 12/12] cppcheck: Add target specific headers David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yy5zhG7Gsmd3WMdj@yekko \
--to=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).