From: David Gibson <david@gibson.dropbear.id.au>
To: passt-dev@passt.top
Subject: Re: [PATCH v4 12/12] test: Move video processing files to $STATEBASE
Date: Tue, 13 Sep 2022 14:41:46 +1000 [thread overview]
Message-ID: <YyAKCoL2wYDc9woO@yekko> (raw)
In-Reply-To: <20220910224119.1f0ab9c6@elisabeth>
[-- Attachment #1: Type: text/plain, Size: 2851 bytes --]
On Sat, Sep 10, 2022 at 10:41:19PM +0200, Stefano Brivio wrote:
> On Sat, 10 Sep 2022 17:45:48 +1000
> David Gibson <david(a)gibson.dropbear.id.au> wrote:
>
> > On Fri, Sep 09, 2022 at 05:00:35PM +0200, Stefano Brivio wrote:
> > > On Fri, 9 Sep 2022 13:30:28 +1000
> > > David Gibson <david(a)gibson.dropbear.id.au> wrote:
> > >
> > > > The asciinema video handling creates a number of temporary files (.uncat,
> > > > .start, .stop) which currently go into the source tree. Put them in the
> > > > temporary state directory to avoid clutter. Put the final processed video
> > > > into the test_logs/ directory, since it's essentially a test output
> > > > artefact.
> > >
> > > This needs an update in hooks/pre-push in any case, but... I wouldn't
> >
> > Uh.. right. The hooks aren't part of the repo contents, though, so I
> > can't change that.
>
> They are, in some sense:
>
> $ git log --oneline -1 hooks/pre-push
> ba72c83 hooks: Copy .webp diagram versions too
>
> I then copy that single hook to .git whenever I clone a repository, as
> suggested in the comment:
Huh, I completely missed that there.
> $ grep .git hooks/pre-push
> # cp hooks/pre-push .git/hooks/pre-push
>
> ...this should eventually become a server-side post-receive hook, I
> guess, using a temporary branch for testing and then forwarding the
> updates to master if the tests pass.
Right. It wouldn't make sense for me or anyone else to have this as a
pre-push hook.
> But I haven't looked yet into headless asciinema captures -- I guess
> it's doable and I've been doing something similar with Xvfb, it might
> need some extra setup in the test scripts though.
Right. It should be ok as long as $TERM and the stty settings match.
Obviously a pty will have to be allocated for the command, which I
suspect asciinema rec must do anyway. It might be as simple as
setting the --cols and --rows options.
> > > mix those. The current directory listing at:
> > > https://passt.top/builds/latest/test/
> > >
> > > is sort of usable right now, and if I just scp everything into there,
> > > it wouldn't be anymore.
> > >
> > > Maybe we could move the cast files to test_logs/web/, then scp:
> > >
> > > - test_logs/* (files only) to latest/test/
> > > - test_logs/web/* to latest/web/
> > >
> > > instead?
> >
> > Sure, we could do that. It's really up to you what you want the
> > workflow to be.
>
> Hmm, yes, that would be my preferred option at the moment. I can also
> take care of updating the hook when I apply your patches.
Ok, I've done that in the next spin.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2022-09-13 4:41 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-09 3:30 [PATCH v4 00/12] Improve handling of test temporary files David Gibson
2022-09-09 3:30 ` [PATCH v4 01/12] test: Group tests by context then protocol, rather than the reverse David Gibson
2022-09-09 3:30 ` [PATCH v4 02/12] test: Remove unused variable FFMPEG_PID_FILE David Gibson
2022-09-09 3:30 ` [PATCH v4 03/12] test: Actually run cleanup function David Gibson
2022-09-09 3:30 ` [PATCH v4 04/12] test: Create common state directories for temporary files David Gibson
2022-09-09 3:30 ` [PATCH v4 05/12] test: Move passt_test_log_pipe to state directory David Gibson
2022-09-09 3:30 ` [PATCH v4 06/12] test: Move context temporary files to state dir David Gibson
2022-09-09 3:30 ` [PATCH v4 07/12] test: Dont regnerate small test file in pasta/tcp David Gibson
2022-09-09 3:30 ` [PATCH v4 08/12] test: Use paths in __STATEDIR__ instead of 'temp' and 'tempdir' directives David Gibson
2022-09-09 15:00 ` Stefano Brivio
2022-09-10 7:44 ` David Gibson
2022-09-10 20:41 ` Stefano Brivio
2022-09-09 3:30 ` [PATCH v4 09/12] test: Move pause temporary file to state directory David Gibson
2022-09-09 3:30 ` [PATCH v4 10/12] test: Store pcap files in $LOGDIR instead of /tmp David Gibson
2022-09-09 3:30 ` [PATCH v4 11/12] test: Move pidfiles and nsholder sockets into state directory David Gibson
2022-09-09 3:30 ` [PATCH v4 12/12] test: Move video processing files to $STATEBASE David Gibson
2022-09-09 15:00 ` Stefano Brivio
2022-09-10 7:45 ` David Gibson
2022-09-10 20:41 ` Stefano Brivio
2022-09-13 4:41 ` David Gibson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YyAKCoL2wYDc9woO@yekko \
--to=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).