From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Gibson <david@gibson.dropbear.id.au>
To: passt-dev@passt.top
Subject: Re: [PATCH v4 12/12] test: Move video processing files to $STATEBASE
Date: Tue, 13 Sep 2022 14:41:46 +1000
Message-ID: <YyAKCoL2wYDc9woO@yekko>
In-Reply-To: <20220910224119.1f0ab9c6@elisabeth>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3171038999635584693=="

--===============3171038999635584693==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

On Sat, Sep 10, 2022 at 10:41:19PM +0200, Stefano Brivio wrote:
> On Sat, 10 Sep 2022 17:45:48 +1000
> David Gibson <david(a)gibson.dropbear.id.au> wrote:
>=20
> > On Fri, Sep 09, 2022 at 05:00:35PM +0200, Stefano Brivio wrote:
> > > On Fri,  9 Sep 2022 13:30:28 +1000
> > > David Gibson <david(a)gibson.dropbear.id.au> wrote:
> > >  =20
> > > > The asciinema video handling creates a number of temporary files (.un=
cat,
> > > > .start, .stop) which currently go into the source tree.  Put them in =
the
> > > > temporary state directory to avoid clutter.  Put the final processed =
video
> > > > into the test_logs/ directory, since it's essentially a test output
> > > > artefact. =20
> > >=20
> > > This needs an update in hooks/pre-push in any case, but... I wouldn't  =

> >=20
> > Uh.. right.  The hooks aren't part of the repo contents, though, so I
> > can't change that.
>=20
> They are, in some sense:
>=20
>   $ git log --oneline -1 hooks/pre-push
>   ba72c83 hooks: Copy .webp diagram versions too
>=20
> I then copy that single hook to .git whenever I clone a repository, as
> suggested in the comment:

Huh, I completely missed that there.

>   $ grep .git hooks/pre-push
>   # cp hooks/pre-push .git/hooks/pre-push
>=20
> ...this should eventually become a server-side post-receive hook, I
> guess, using a temporary branch for testing and then forwarding the
> updates to master if the tests pass.

Right.  It wouldn't make sense for me or anyone else to have this as a
pre-push hook.

> But I haven't looked yet into headless asciinema captures -- I guess
> it's doable and I've been doing something similar with Xvfb, it might
> need some extra setup in the test scripts though.

Right.  It should be ok as long as $TERM and the stty settings match.
Obviously a pty will have to be allocated for the command, which I
suspect asciinema rec must do anyway.  It might be as simple as
setting the --cols and --rows options.

> > > mix those. The current directory listing at:
> > >   https://passt.top/builds/latest/test/
> > >=20
> > > is sort of usable right now, and if I just scp everything into there,
> > > it wouldn't be anymore.
> > >=20
> > > Maybe we could move the cast files to test_logs/web/, then scp:
> > >=20
> > > - test_logs/* (files only) to latest/test/
> > > - test_logs/web/* to latest/web/
> > >=20
> > > instead? =20
> >=20
> > Sure, we could do that.  It's really up to you what you want the
> > workflow to be.
>=20
> Hmm, yes, that would be my preferred option at the moment. I can also
> take care of updating the hook when I apply your patches.

Ok, I've done that in the next spin.

--=20
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

--===============3171038999635584693==
Content-Type: application/pgp-signature
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="signature.asc"
MIME-Version: 1.0

LS0tLS1CRUdJTiBQR1AgU0lHTkFUVVJFLS0tLS0KCmlRSXpCQUVCQ0FBZEZpRUVvVUx4V3U0L1dz
MGRCK1h0Z3lwWTRnRXdZU0lGQW1NZ0NlWUFDZ2tRZ3lwWTRnRXcKWVNLRUdRLytMbHBmU3Zzblpr
TTUvdjYxWHlSdlVCbkJPbmdWNWZjUFBqVFVQdHhaYXJqZmk1Q3BKc1BDYXgrKwpCMlBBelZvTi9X
amNxNHdvTDFENWJtYnl2Ykxaak54TTJZQldnK1hOTTNQNEplODByRDN3WDZIcEMxK2JGaVRtCnBZ
NmMxcWpXdnpnZnVvcmVndVh4V2lVcnRSRGFZNjk2aUhMUzA3UGtoamdGTFpuWlBWOUFTZ25JU3hE
b2lodHEKRVo2ZktsRTI0cW4vZXNXWEhwbksvWmhtUmJNbTdwbjlSNHhyaGZJcm84UTJYTjZxT0JW
dlllZndSVm51UUV6KwpZbEluU2JJelpRTDJIcWcrN2twRVJVLzIyT1VEZjkyYXhnR2NFSzNDNTVR
eFpVZFhxRW5EdXVKRmpkREc1V1k2ClNpSW1LczB6VGxHWnVBMW9ybHZySHpKWU9YTnZtaldwVktU
NUJuL3krL2h6VU1kSDBna2U2WW9vc25UVitBeHkKa2E3Q25uVWttS1dFbVE0bktlMEJBN3RoSzY0
WUIrNTQvdWlValNHbmM1TFE2bC83MUJEcEZyZFFIUXZ2bXJ5TQpsWDk4V3N4RGNBK2NidHRLV1RC
alhSVmVQN3RzNWRjSUhsREJMYVU4S0VWd2dmRmVTNTRaVmtHajY2ZU0rYnpwClZZc3IrQWVOTEp0
MEdKVlI4Z2JrSnlHK2ZZdVZYVk9kWlU2V0F6QURhNm5rTWgwY2RmZjJRRzl4bXpPWmZQQ1gKcUw0
VGkvelFvZjBWWXVkUlRYZTNJbWhZNHlHVTFyMHIyRTVmU0dUVVZIc3ZBUEl1VEowWThzUDlpL25t
M2FnRwpvOFdHL1BIV0FuemVINHFWdTFwUmZ2bCtQWFVUMEdwVkswdEsyYlN0QlBZbndMYVoxeEk9
Cj10Ni9mCi0tLS0tRU5EIFBHUCBTSUdOQVRVUkUtLS0tLQo=

--===============3171038999635584693==--