From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Gibson <david@gibson.dropbear.id.au>
To: passt-dev@passt.top
Subject:
 Re: [PATCH] test: term: When checking if status line is a number, hide errors
Date: Wed, 14 Sep 2022 21:56:36 +1000
Message-ID: <YyHBdJETMhQQFbEd@yekko>
In-Reply-To: <20220914095755.2359997-1-sbrivio@redhat.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============5257729617035705949=="

--===============5257729617035705949==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

On Wed, Sep 14, 2022 at 11:57:55AM +0200, Stefano Brivio wrote:
> We use the [ "$x" -eq "$x" ] syntax to check if $x is a number. The
> behaviour is clearly implied by POSIX, but some shells might actually
> report the (intended) error, and dash floods script.log with
> "Illegal number" error messages. Hide them.
> 
> Signed-off-by: Stefano Brivio <sbrivio(a)redhat.com>

Reviewed-by: David Gibson <david(a)gibson.dropbear.id.au>

I see a bunch of these errors and it would be nice to get rid of them.

> ---
>  test/lib/term | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/test/lib/term b/test/lib/term
> index b31deac..eade2cd 100755
> --- a/test/lib/term
> +++ b/test/lib/term
> @@ -232,7 +232,7 @@ pane_status() {
>  	[ ${DEMO} -eq 1 ] && return 0
>  
>  	__status="$(pane_parse "${1}")"
> -	while ! [ "${__status}" -eq "${__status}" ]; do
> +	while ! [ "${__status}" -eq "${__status}" ] 2>/dev/null; do
>  		sleep 1
>  		pane_run "${1}" 'echo $?'
>  		pane_wait "${1}"

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

--===============5257729617035705949==
Content-Type: application/pgp-signature
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="signature.asc"
MIME-Version: 1.0

LS0tLS1CRUdJTiBQR1AgU0lHTkFUVVJFLS0tLS0KCmlRSXpCQUVCQ0FBZEZpRUVvVUx4V3U0L1dz
MGRCK1h0Z3lwWTRnRXdZU0lGQW1NaHdWc0FDZ2tRZ3lwWTRnRXcKWVNJMGNBLytLM29naVMwNEhG
b0FYempJblRsSnhocGpwSW5EeGZnUzl6Njd0YUpzeXgwRlNDR3o3cjd2MnNjVApBd0l1QjRNSzNv
cU9EeXVCdHk4Q1NIdUY0MVIyVXRxL29aT0ExM0hybXRaR2NNVkp6c3RSaUcreGJOM3Jpc3F6CmJy
dW5jdmFQMjNMN3dFNnRWY093TGtGZzduZFhOZXU4Q05WV29ZbUp0akVieUM4UzBXc1ZveVV6VWtl
WEVhcDIKRE9VRVhoTURiTStaVnBDTytpVm9qQmdwYmJHRVJudS9Pd2RjM1FiQXdyY3dHRE5Hbmho
SnNvdEhpdzkwU3p6agp6Z2ZzT2Qybi8vWUs1V1F0RFNmUWVQRzRWWG5YeUtRR1JSYTVydU1iR3Bl
cWJWU0FwZTIzdHU3dmMyRzY1R1grCmxRcVl2S0R1WUYvaml4c3E0YXpLKzhtTU9zZUxRNUJ4UmpP
azE2TmlQamF3aVZxcEdUc3RzYVA0dEx3Q3cvOHQKTHhwdHp1SGNhdGxjL0pGY05VUHFjRVZvWDFy
RXVMUk1nTzg4L1RJYWZCdmxDanpyNTYyMnBCQWw1UVJYZUJ3RApEU0k3Q290YWdwZnRYb1hFYWwv
U1Y3NFk0TWErNXZRL3FWVlAwU2wrc3AvU1VDeXYyUnZlK09neXBxaHVpcEthCjZMSjd6ZlBGdUhh
Q0txYSt3OUdMN0VVRUFSWXRPRnozRnBzVUZXZzFMUlVwT1ZCenlSS05mbjBjS3JjUjJlUnkKWnhw
OXB2UVhyYzM1K3ZrRGtpSnExYTh6T2cvdEN2ODl2dnZ0VzdtY1NKWm96Q0dScHR5c3VBMUVYUG1G
V3VVZwo0SWY2MlNUSU0wWU40K3hjVktSSnBuMEFCSVFLRDhhLzgrVTJUdXdPWkZOVTdEa2lmZjQ9
Cj12RHVCCi0tLS0tRU5EIFBHUCBTSUdOQVRVUkUtLS0tLQo=

--===============5257729617035705949==--