From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Gibson <david@gibson.dropbear.id.au>
To: passt-dev@passt.top
Subject: Re: [PATCH] Makefile: Include seccomp.h in HEADERS and require it for
 static checkers
Date: Thu, 15 Sep 2022 01:07:21 +1000
Message-ID: <YyHuKcX5fj9djcyr@yekko>
In-Reply-To: <20220914135911.2873406-1-sbrivio@redhat.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============9129854396462727840=="

--===============9129854396462727840==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Sep 14, 2022 at 03:59:11PM +0200, Stefano Brivio wrote:
> Targets running static checkers (cppcheck and clang-tidy) need
> seccomp.h, but the latter is not included in HEADERS. Add it.
>=20
> Signed-off-by: Stefano Brivio <sbrivio(a)redhat.com>

Reviewed-by: David Gibson <david(a)gibson.dropbear.id.au>

> ---
>  Makefile | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>=20
> diff --git a/Makefile b/Makefile
> index 6805c23..c47a5f6 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -42,7 +42,7 @@ MANPAGES =3D passt.1 pasta.1 qrap.1
>  PASST_HEADERS =3D arch.h arp.h checksum.h conf.h dhcp.h dhcpv6.h icmp.h \
>  	isolation.h lineread.h ndp.h netlink.h packet.h passt.h pasta.h \
>  	pcap.h siphash.h tap.h tcp.h tcp_splice.h udp.h util.h
> -HEADERS =3D $(PASST_HEADERS)
> +HEADERS =3D $(PASST_HEADERS) seccomp.h
> =20
>  # On gcc 11.2, with -O2 and -flto, tcp_hash() and siphash_20b(), if inline=
d,
>  # seem to be hitting something similar to:
> @@ -104,11 +104,11 @@ static: clean all
>  seccomp.h: $(PASST_SRCS) $(PASST_HEADERS)
>  	@ EXTRA_SYSCALLS=3D$(EXTRA_SYSCALLS) ./seccomp.sh $^
> =20
> -passt: $(PASST_SRCS) $(PASST_HEADERS) seccomp.h
> +passt: $(PASST_SRCS) $(HEADERS)
>  	$(CC) $(FLAGS) $(CFLAGS) $(PASST_SRCS) -o passt $(LDFLAGS)
> =20
>  passt.avx2: FLAGS +=3D -Ofast -mavx2 -ftree-vectorize -funroll-loops
> -passt.avx2: $(PASST_SRCS) $(PASST_HEADERS) seccomp.h
> +passt.avx2: $(PASST_SRCS) $(HEADERS)
>  	$(CC) $(filter-out -O2,$(FLAGS) $(CFLAGS)) \
>  		$(PASST_SRCS) -o passt.avx2 $(LDFLAGS)
> =20

--=20
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

--===============9129854396462727840==
Content-Type: application/pgp-signature
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="signature.asc"
MIME-Version: 1.0

LS0tLS1CRUdJTiBQR1AgU0lHTkFUVVJFLS0tLS0KCmlRSXpCQUVCQ0FBZEZpRUVvVUx4V3U0L1dz
MGRCK1h0Z3lwWTRnRXdZU0lGQW1NaDdpSUFDZ2tRZ3lwWTRnRXcKWVNKY3FoQUFsdXFITi9mQWtt
VmZQdnU3ZkdIUG1FRGl0TFVEYVhscUFIZFVsaHVQU1U5dmVqMHRhOCtFMG9RRwpIbnhZR0NVeGRH
bi9NSm5iTzIxL3dYcE56V0lBdEdQdElGVURudGMxcDU0eXpoR1JCWVBMMVJxTS9vTS9zRVlJClFC
SzlFOWtGdUs2TWdiT2t3NmgwNzk3MW02MjY1TnE2Z3FySUowK3hVZkx3YjRqYUlJRlIyM2NRdXhS
ZS9JNFoKYTlDajdXNUJnc3dJcWthWXdxVXI5UnpSWCt1aXFVTHg4RlYyWEx0Q0c4YlRtQmF1a1Nl
WGhZN1cvazVndHptawpqQitmNExyOHZWclcrcEQvR043RUV4bGlBN3h0bEk4ZUE5TVZENEdhRTNL
cEdWZ0tYV3ZNWElLOUttcTYvN01DCllBalI3cVJPNG5xNFJZMnFNK3pMNW1WRTNVMk1HT2RpVWNW
NEx4OGpOa0pRSWlmNEIwUjBWNW9oOUsweE5wc0QKWkFVTEo5K3ZRMnhTeGREWlpibFpiM0xBa1pI
TmpmL1pjT2pFazhkajhTR2xodmE0VmpsRFNzNUpqK09oTlo3bQpCYStSVkxXTHhKVEVwLzhuQ2xl
T3ByWWFrZkZwSlVoTEtqbEh2bTRCMWRUS01HWUlkajFrcHFTT3FCOXVEWXlLCnZxV3BHSVhEdFk5
RkRBUXVlNVA3aXhGSHUrMlVvMmpYemRrQWhCVFh5dUc2TlNrSmFTTHVDUllNWVlIYUhmdFAKaHZr
azlsMHFrd0NPZnk0TnJOMGU1aStSMVhIRWpWWVlCWlJSdWlqOGllYWllSWN4dXdLWWNIbXIvZHJw
L2t4eQprTmgxMXV1Y1VWMHhSZy9ETjBmWVFySjNpbUczL2RldndZdlFDRVR6TEJHZFh1NXRsV0U9
Cj1UWFJzCi0tLS0tRU5EIFBHUCBTSUdOQVRVUkUtLS0tLQo=

--===============9129854396462727840==--