Re: [PATCH 1/2] test/perf: Check for /sbin/sysctl with which(1), not simply sysctl

[David Gibson <david@gibson.dropbear.id.au>]

[-- Attachment #1: Type: text/plain, Size: 2593 bytes --]

On Sat, Sep 17, 2022 at 01:55:33AM +0200, Stefano Brivio wrote:
> Otherwise, we're depending on having /sbin in $PATH. For some reason

Huh.  I wonder why this is working for me.

> I didn't completely grasp, with the new command dispatch mechanism
> that's not the case anymore, even if I have /sbin in $PATH in the
> parent shell.

For the guest, there's no mystery - there's no strong connection
between the shell environments there.  We probably can control PATH
with our mbuto setup though.

For the ns that is strange, though.

> 
> Signed-off-by: Stefano Brivio <sbrivio(a)redhat.com>
> ---
>  test/perf/passt_tcp | 4 ++--
>  test/perf/passt_udp | 2 +-
>  test/perf/pasta_tcp | 2 +-
>  3 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/test/perf/passt_tcp b/test/perf/passt_tcp
> index 45095b6..f0cfa1b 100644
> --- a/test/perf/passt_tcp
> +++ b/test/perf/passt_tcp
> @@ -11,8 +11,8 @@
>  # Copyright (c) 2021 Red Hat GmbH
>  # Author: Stefano Brivio <sbrivio(a)redhat.com>
>  
> -gtools	sysctl ip jq nproc seq sleep iperf3 tcp_rr tcp_crr # From neper
> -nstools	sysctl ip jq nproc seq sleep iperf3 tcp_rr tcp_crr
> +gtools	/sbin/sysctl ip jq nproc seq sleep iperf3 tcp_rr tcp_crr # From neper
> +nstools	/sbin/sysctl ip jq nproc seq sleep iperf3 tcp_rr tcp_crr
>  htools	bc head sed seq
>  
>  # In this setup, virtio_net TX queue sometimes hangs, still under investigation
> diff --git a/test/perf/passt_udp b/test/perf/passt_udp
> index d199523..80731d1 100644
> --- a/test/perf/passt_udp
> +++ b/test/perf/passt_udp
> @@ -11,7 +11,7 @@
>  # Copyright (c) 2021 Red Hat GmbH
>  # Author: Stefano Brivio <sbrivio(a)redhat.com>
>  
> -gtools	sysctl ip jq nproc sleep iperf3 udp_rr # From neper
> +gtools	/sbin/sysctl ip jq nproc sleep iperf3 udp_rr # From neper
>  nstools	ip jq sleep iperf3 udp_rr
>  htools	bc head sed
>  
> diff --git a/test/perf/pasta_tcp b/test/perf/pasta_tcp
> index 4c19364..602ce52 100644
> --- a/test/perf/pasta_tcp
> +++ b/test/perf/pasta_tcp
> @@ -12,7 +12,7 @@
>  # Author: Stefano Brivio <sbrivio(a)redhat.com>
>  
>  htools	head ip seq bc sleep iperf3 tcp_rr tcp_crr jq sed
> -nstools	sysctl nproc ip seq sleep iperf3 tcp_rr tcp_crr jq sed
> +nstools	/sbin/sysctl nproc ip seq sleep iperf3 tcp_rr tcp_crr jq sed
>  
>  test	pasta: throughput and latency (local connections)
>  

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]