From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Gibson <david@gibson.dropbear.id.au>
To: passt-dev@passt.top
Subject: Re: [PATCH 1/2] test/perf: Check for /sbin/sysctl with which(1), not
 simply sysctl
Date: Sat, 17 Sep 2022 13:27:32 +1000
Message-ID: <YyU+pOz9x7s6ogsv@yekko>
In-Reply-To: <20220916235534.2399997-2-sbrivio@redhat.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0002745678776529447=="

--===============0002745678776529447==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

On Sat, Sep 17, 2022 at 01:55:33AM +0200, Stefano Brivio wrote:
> Otherwise, we're depending on having /sbin in $PATH. For some reason

Huh.  I wonder why this is working for me.

> I didn't completely grasp, with the new command dispatch mechanism
> that's not the case anymore, even if I have /sbin in $PATH in the
> parent shell.

For the guest, there's no mystery - there's no strong connection
between the shell environments there.  We probably can control PATH
with our mbuto setup though.

For the ns that is strange, though.

>=20
> Signed-off-by: Stefano Brivio <sbrivio(a)redhat.com>
> ---
>  test/perf/passt_tcp | 4 ++--
>  test/perf/passt_udp | 2 +-
>  test/perf/pasta_tcp | 2 +-
>  3 files changed, 4 insertions(+), 4 deletions(-)
>=20
> diff --git a/test/perf/passt_tcp b/test/perf/passt_tcp
> index 45095b6..f0cfa1b 100644
> --- a/test/perf/passt_tcp
> +++ b/test/perf/passt_tcp
> @@ -11,8 +11,8 @@
>  # Copyright (c) 2021 Red Hat GmbH
>  # Author: Stefano Brivio <sbrivio(a)redhat.com>
> =20
> -gtools	sysctl ip jq nproc seq sleep iperf3 tcp_rr tcp_crr # From neper
> -nstools	sysctl ip jq nproc seq sleep iperf3 tcp_rr tcp_crr
> +gtools	/sbin/sysctl ip jq nproc seq sleep iperf3 tcp_rr tcp_crr # From nep=
er
> +nstools	/sbin/sysctl ip jq nproc seq sleep iperf3 tcp_rr tcp_crr
>  htools	bc head sed seq
> =20
>  # In this setup, virtio_net TX queue sometimes hangs, still under investig=
ation
> diff --git a/test/perf/passt_udp b/test/perf/passt_udp
> index d199523..80731d1 100644
> --- a/test/perf/passt_udp
> +++ b/test/perf/passt_udp
> @@ -11,7 +11,7 @@
>  # Copyright (c) 2021 Red Hat GmbH
>  # Author: Stefano Brivio <sbrivio(a)redhat.com>
> =20
> -gtools	sysctl ip jq nproc sleep iperf3 udp_rr # From neper
> +gtools	/sbin/sysctl ip jq nproc sleep iperf3 udp_rr # From neper
>  nstools	ip jq sleep iperf3 udp_rr
>  htools	bc head sed
> =20
> diff --git a/test/perf/pasta_tcp b/test/perf/pasta_tcp
> index 4c19364..602ce52 100644
> --- a/test/perf/pasta_tcp
> +++ b/test/perf/pasta_tcp
> @@ -12,7 +12,7 @@
>  # Author: Stefano Brivio <sbrivio(a)redhat.com>
> =20
>  htools	head ip seq bc sleep iperf3 tcp_rr tcp_crr jq sed
> -nstools	sysctl nproc ip seq sleep iperf3 tcp_rr tcp_crr jq sed
> +nstools	/sbin/sysctl nproc ip seq sleep iperf3 tcp_rr tcp_crr jq sed
> =20
>  test	pasta: throughput and latency (local connections)
> =20

--=20
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

--===============0002745678776529447==
Content-Type: application/pgp-signature
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="signature.asc"
MIME-Version: 1.0

LS0tLS1CRUdJTiBQR1AgU0lHTkFUVVJFLS0tLS0KCmlRSXpCQUVCQ0FBZEZpRUVvVUx4V3U0L1dz
MGRCK1h0Z3lwWTRnRXdZU0lGQW1NbFBwMEFDZ2tRZ3lwWTRnRXcKWVNMbE1RLy9ZNEphOUVjSlNM
azMveVkvd3kwd0hXTmp0dWJXQW9iVUhWU0NKWWZWdWxpRUErWDZINkx0SU1GUQpnWDZyZ3htYmo1
b2xZbDNRcEdhaU9wd0huL3UxeURaRUhuQXNJd1JoZmJHdWQxaUZJVWxOclVPanJPUUlLWThhCndy
dWpsbjd6MUhsbnRUdzc4azJjeDdQRUJHY1dvM1J0QmE4UUhybzEwOWxJV2RvL01wTzVGS0xiQjE0
anZhdEQKVXFmc3ZQb3RyNmRHbFU0QzNvK00yUUp6SEtXT003UVpSYnBDUUNqRG1sRXUyS0RYanhw
c2w5aUpuOGRwVTlvdAoxMlhNZU50SEpCSk5qbnNDQTVrcmIweHY2UURJbEo1d3BLMTF2ZnVlVzEy
dk13ajY2ZHhHQkkvQ3RnL2lNMnh2CmhySEF6bTFQMG40SFhoN2lQNWlvcVE1VGI3My9TZmtXc2pw
K1Q1Sy9wWTNNb1ZKaXgvRExvWk9uc3ZVVkdhUG8KRTFQemExaE0zM0ZYc0RzVkNkRkN4QjJSRUtG
Vk96djVrUHFEZEIwNHJ4WnlEcFhxTkdYQ09zN2oxWmI0MEx1VQpOb3h3bVZSQUlYWkc2N2JkeEVs
TGxVaU9rRElkRllEMzZLQkZGakIycHpaL1NwckdtZ0szT2FnR3kzREh6YzhvCmw2MDFMcFBlS200
WGw4OUNTK0l2UDNzYmpQZHRUMGNjTGFtUE44d2JjUTd1MENLb1d1ZUhJUkFzK25zWVg5Yi8KU3dX
SmNLWGZHVFBvek1pZGR1UklPM0lRRTV3NUNvQTI3QWx5REJ4NUpHRzBCWUpPN2xUOG1kMVA2dlBl
cFBLagpPeTlvN092b0RIdHNIWXNZSnc0aTJaOWExMnN6SnNhQkhSRklveDFTRUlERUllWnh2Mkk9
Cj0yMGRuCi0tLS0tRU5EIFBHUCBTSUdOQVRVUkUtLS0tLQo=

--===============0002745678776529447==--