Re: [PATCH 1/2] doc/demo: Drop /sbin from dhclient command, pass script file explicitly

[David Gibson <david@gibson.dropbear.id.au>]

[-- Attachment #1: Type: text/plain, Size: 1415 bytes --]

On Sat, Sep 17, 2022 at 01:55:18AM +0200, Stefano Brivio wrote:
> dhclient might be in /usr/sbin on recent versions of Fedora, and
> mbuto just adds it to the same location as it was on the host:
> just call dhclient instead of /sbin/dhclient.
> 
> This also applies for dhclient-script: given that we create the file
> on boot, pass its explicit location with -sf.
> 
> Signed-off-by: Stefano Brivio <sbrivio(a)redhat.com>

Hm, for the tests mbuto image I addressed this with symlinks instead.
Not sure which is more elegant.

> ---
>  doc/demo.sh | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/doc/demo.sh b/doc/demo.sh
> index d39a10e..f704ed4 100755
> --- a/doc/demo.sh
> +++ b/doc/demo.sh
> @@ -63,11 +63,11 @@ EOF
>  		echo "$ ip link set dev eth0 up"
>  		ip link set dev eth0 up
>  		sleep 3
> -		echo "$ /sbin/dhclient -4 -1"
> -		/sbin/dhclient -4 -1
> +		echo "$ dhclient -4 -1 -sf /sbin/dhclient-script"
> +		dhclient -4 -1 -sf /sbin/dhclient-script
>  		sleep 2
> -		echo "$ /sbin/dhclient -6 -1"
> -		/sbin/dhclient -6 -1
> +		echo "$ dhclient -6 -1 -sf /sbin/dhclient-script"
> +		dhclient -6 -1 -sf /sbin/dhclient-script
>  		sleep 2
>  		echo
>  		echo "$ ip address show"

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]