From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Gibson To: passt-dev@passt.top Subject: Re: [PATCH 1/2] doc/demo: Drop /sbin from dhclient command, pass script file explicitly Date: Sat, 17 Sep 2022 13:23:55 +1000 Message-ID: In-Reply-To: <20220916235519.2399943-2-sbrivio@redhat.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7906186574019625093==" --===============7906186574019625093== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit On Sat, Sep 17, 2022 at 01:55:18AM +0200, Stefano Brivio wrote: > dhclient might be in /usr/sbin on recent versions of Fedora, and > mbuto just adds it to the same location as it was on the host: > just call dhclient instead of /sbin/dhclient. > > This also applies for dhclient-script: given that we create the file > on boot, pass its explicit location with -sf. > > Signed-off-by: Stefano Brivio Hm, for the tests mbuto image I addressed this with symlinks instead. Not sure which is more elegant. > --- > doc/demo.sh | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/doc/demo.sh b/doc/demo.sh > index d39a10e..f704ed4 100755 > --- a/doc/demo.sh > +++ b/doc/demo.sh > @@ -63,11 +63,11 @@ EOF > echo "$ ip link set dev eth0 up" > ip link set dev eth0 up > sleep 3 > - echo "$ /sbin/dhclient -4 -1" > - /sbin/dhclient -4 -1 > + echo "$ dhclient -4 -1 -sf /sbin/dhclient-script" > + dhclient -4 -1 -sf /sbin/dhclient-script > sleep 2 > - echo "$ /sbin/dhclient -6 -1" > - /sbin/dhclient -6 -1 > + echo "$ dhclient -6 -1 -sf /sbin/dhclient-script" > + dhclient -6 -1 -sf /sbin/dhclient-script > sleep 2 > echo > echo "$ ip address show" -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --===============7906186574019625093== Content-Type: application/pgp-signature Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="signature.asc" MIME-Version: 1.0 LS0tLS1CRUdJTiBQR1AgU0lHTkFUVVJFLS0tLS0KCmlRSXpCQUVCQ0FBZEZpRUVvVUx4V3U0L1dz MGRCK1h0Z3lwWTRnRXdZU0lGQW1NbFBiTUFDZ2tRZ3lwWTRnRXcKWVNLU21nLy9YeDFJc05OeFcx cmdjRXpHSld3ZjJBUTJ3VU1DWHBaRE10OVJ6bnByNGlHQzZBVER5bTBNNVhhLwp5bXJHVWpZTGFL RG9ZNm5nVEJybDdXbEdwT2wyZ3BadXFOcWRuSkFVUlFRckx6Q3RsMmdVOUtLNGhmeW5UL0g0Ckly aFVheW1wZlRLcGNWUjg5Si9EN0p0djN0MUNqMVkxSTg1SGR2RUtFdHFldzkvajlkOEFHR2R2OWw0 K1FIM0IKclhhc0NxbkE3aE12UkVOQjF2N2JGKzlIMkRoa0lpVGladlFWMFQ0TjM1cEViNGw0T0ZV SlFYSmEvcnBkY0NWZAp0ZU1HQ29rZ1RUSU84ekJKSnUrU05rTVBrNUlvQ2RLUnVVRFkwSG5adU0z RnZYaWpKVVVTWmtBeVdVc0h0WWxBClJneWxoRU91YVI0c1FGay9keXpJcE9LOE5HQWIrRVgrUVhj ejNJK3VYM3dNWTVaSmh1MFA3eGx2Vk9mYU00cXEKSFRUcGlJTWxFclZ4aGNuOHFBMGhkWlc3NzMr WldWNTBxTG9sQWNQQTdUU1VKUnRTdEttUmJjOGdMWEtJdTdIdAppd1VuUmlFMnAyYTdrOStyRG5K N0dxb3phOEZjMFZWaHo4MnUvVWFKVFp3YTRIcXNUL3hXRzU0aXpsbHQxYVc1CnZSRjZJaUh2SnFG MjluNUk4bmloKy8xK051T0JNdlBBWnhWdUJsNWM5d1QvcDhXcFlNQmdOa0xRaGcyM2xWNlcKdDkx b0k0anNzS0s3alA1YjNYS1FIdlZwWDZZRk00U3o2KzlONXJLbCswa2E3N08reEdRQlRpazJicldq M2IwQwpGREF1b2FnakpwdjJVdU1kUVZvM3pCM3IxSWc1cFFLbXdzTnI3dlR2NUlQZkc4SGhKN0k9 Cj1rZ1g1Ci0tLS0tRU5EIFBHUCBTSUdOQVRVUkUtLS0tLQo= --===============7906186574019625093==--