From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Gibson To: passt-dev@passt.top Subject: Re: [PATCH 1/2] test/perf: Check for /sbin/sysctl with which(1), not simply sysctl Date: Sat, 17 Sep 2022 19:51:45 +1000 Message-ID: In-Reply-To: <20220917104436.28fe332e@elisabeth> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4988703709627121269==" --===============4988703709627121269== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit On Sat, Sep 17, 2022 at 10:44:36AM +0200, Stefano Brivio wrote: > On Sat, 17 Sep 2022 13:27:32 +1000 > David Gibson wrote: > > > On Sat, Sep 17, 2022 at 01:55:33AM +0200, Stefano Brivio wrote: > > > Otherwise, we're depending on having /sbin in $PATH. For some reason > > > > Huh. I wonder why this is working for me. > > Different shells, or different shell profiles, I guess? > > > > I didn't completely grasp, with the new command dispatch mechanism > > > that's not the case anymore, even if I have /sbin in $PATH in the > > > parent shell. > > > > For the guest, there's no mystery - there's no strong connection > > between the shell environments there. We probably can control PATH > > with our mbuto setup though. > > > > For the ns that is strange, though. > > I think the reason is that with: > > echo "nsenter $@ sh -c" > "${__enter}" > > you get a different behaviour than nsenter with an interactive shell > (previous implementation). For example, on Debian, commands (by default) > will run with dash instead of bash. > > In any case, just using 'which sysctl' looks wrong to me, and that can > break for many other reasons, so I don't feel very inclined in digging > into the actual reason and differences between environments here. Yeah, fair enough. Reviewed-by: David Gibson -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --===============4988703709627121269== Content-Type: application/pgp-signature Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="signature.asc" MIME-Version: 1.0 LS0tLS1CRUdJTiBQR1AgU0lHTkFUVVJFLS0tLS0KCmlRSXpCQUVCQ0FBZEZpRUVvVUx4V3U0L1dz MGRCK1h0Z3lwWTRnRXdZU0lGQW1NbG1Lb0FDZ2tRZ3lwWTRnRXcKWVNMZlRSQUFtK1Y4Y3lnVTFV MkFqZmFzbkVLQzZwbGRWcnNlZ0dPT1RUME1UL1BBck5vYS82VGRDQnB1RHNFcwpYYVM2bUV4SDhk Q0wyaTAyYVFidHQyMnlRVGtxTTd0QVJsTWF6WE9SamlrWmhmWVBVUmM2VCtKQ2sxdHZHYWlvCmZF ak1DUkcwWnJ3QUdtMmtzaWYyOHN4d3E5dmZweGFkeVJ3SURBQUYvZWhOZ29UWDFnYkFJMjQxQUZB d1Q1MVkKYlBLOGk5VDNNaStlcGtqTWRaU3NkU1BTc25GaFN2TXNmMmxtSnhtL016NERzbjV3TTVD WWUrQm84YUJaVFpjUApBeGI3R0VLUEJvWkY0azhLTVI3UVErd08wNXc4T3NuOWE4V3dnMk1IMDMw MVlDWTZuTnFCWndzdmN0ZlpPMjU2Cml3MFExMXA5SVNmR20rcU9IRE95ZG5MY0FuY21NSGh6QkM1 S3NKdERSL1ZBOTdtNlhsYmIzVzlXSGxtT3ZkZysKTm5HdVYranZUZjJGQ1RjQ2UvNUQ1MVFtOVBu RVptVjB5M2hYTVFmWlprem41Rlg2RWtYN0NGVUN6bDFqczJOLwpQY3VXU0JRWEtQT0dEOXh6Ui80 VVBCMTBmOFZaK0xZQllVOWlIYWJVaFAvVlRLem5pbmk2ZkM3TGRTbFRpOXZiClFVRzVoSHVPanlI a2xSWlF0SDVZenM0dk14blBhUVRkU2M2M3N5Y0JobEM3VW5YOHVQSEpENC9rN1ZyYjZEMU4KWitp b212dVUvdWNYdVlEOU1kVVAzSTNxRnN6dUdESWo4Q3dFZEZ0R1YvU2lsaVp4WVN5c0NJUksrcXI1 bThmKworSEk1RENvTWNTdjBqZC9EbVFydEFLdUVjaGVCODh2ZkZ3U2twT2JUSjZiWkJpRUx0RFk9 Cj1VS0dUCi0tLS0tRU5EIFBHUCBTSUdOQVRVUkUtLS0tLQo= --===============4988703709627121269==--