From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Gibson <david@gibson.dropbear.id.au>
To: passt-dev@passt.top
Subject: Re: [PATCH 1/7] test/perf: Always use /sbin/sysctl in tcp test
Date: Thu, 22 Sep 2022 16:28:41 +1000
Message-ID: <YywAmdh5oR7r6j4C@yekko>
In-Reply-To: <20220921205507.2742203-2-sbrivio@redhat.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2278101834050464631=="

--===============2278101834050464631==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Sep 21, 2022 at 10:55:01PM +0200, Stefano Brivio wrote:
> Signed-off-by: Stefano Brivio <sbrivio(a)redhat.com>

Reviewed-by: David Gibson <david(a)gibson.dropbear.id.au>

> ---
>  test/perf/passt_tcp | 6 +++---
>  test/perf/pasta_tcp | 6 +++---
>  2 files changed, 6 insertions(+), 6 deletions(-)
>=20
> diff --git a/test/perf/passt_tcp b/test/perf/passt_tcp
> index f0cfa1b..bee4f9e 100644
> --- a/test/perf/passt_tcp
> +++ b/test/perf/passt_tcp
> @@ -30,9 +30,9 @@ guest	/sbin/sysctl -w net.ipv4.tcp_rmem=3D"4096 131072 26=
8435456"
>  guest	/sbin/sysctl -w net.ipv4.tcp_wmem=3D"4096 131072 268435456"
>  guest	/sbin/sysctl -w net.ipv4.tcp_timestamps=3D0
> =20
> -ns	sysctl -w net.ipv4.tcp_rmem=3D"4096 524288 134217728"
> -ns	sysctl -w net.ipv4.tcp_wmem=3D"4096 524288 134217728"
> -ns	sysctl -w net.ipv4.tcp_timestamps=3D0
> +ns	/sbin/sysctl -w net.ipv4.tcp_rmem=3D"4096 524288 134217728"
> +ns	/sbin/sysctl -w net.ipv4.tcp_wmem=3D"4096 524288 134217728"
> +ns	/sbin/sysctl -w net.ipv4.tcp_timestamps=3D0
> =20
>  gout	GW ip -j -4 route show|jq -rM '.[] | select(.dst =3D=3D "default").ga=
teway'
>  gout	GW6 ip -j -6 route show|jq -rM '.[] | select(.dst =3D=3D "default").g=
ateway'
> diff --git a/test/perf/pasta_tcp b/test/perf/pasta_tcp
> index 602ce52..cc21075 100644
> --- a/test/perf/pasta_tcp
> +++ b/test/perf/pasta_tcp
> @@ -16,9 +16,9 @@ nstools	/sbin/sysctl nproc ip seq sleep iperf3 tcp_rr tcp=
_crr jq sed
> =20
>  test	pasta: throughput and latency (local connections)
> =20
> -ns	sysctl -w net.ipv4.tcp_rmem=3D"131072 524288 134217728"
> -ns	sysctl -w net.ipv4.tcp_wmem=3D"131072 524288 134217728"
> -ns	sysctl -w net.ipv4.tcp_timestamps=3D0
> +ns	/sbin/sysctl -w net.ipv4.tcp_rmem=3D"131072 524288 134217728"
> +ns	/sbin/sysctl -w net.ipv4.tcp_wmem=3D"131072 524288 134217728"
> +ns	/sbin/sysctl -w net.ipv4.tcp_timestamps=3D0
> =20
> =20
>  set	THREADS 2

--=20
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

--===============2278101834050464631==
Content-Type: application/pgp-signature
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="signature.asc"
MIME-Version: 1.0

LS0tLS1CRUdJTiBQR1AgU0lHTkFUVVJFLS0tLS0KCmlRSXpCQUVCQ0FBZEZpRUVvVUx4V3U0L1dz
MGRCK1h0Z3lwWTRnRXdZU0lGQW1Nc0FKQUFDZ2tRZ3lwWTRnRXcKWVNJOUhoQUF1SXlKTUFhNEZz
QlFGRnFmbC9raFRMVWlkKzF1VXdEQW53akVPVHhualpCVW1ha0pEU08xcGRWZApoa3VQd1BYdFJM
eC8rTmt1a1JJN2lldkN4VzNLRWYvWVJXZlk5Rk9VQWoxaFVEV2V6OTlHdCtuZ1VaNHM0SGJGCmV4
RHprOUZZUmhrcS9pWGRFZHlHa1dQbytjT1V3T2YvVmVjRDN5SnpKbmc3aDhoT1ZwaTlDd2tkcjZ3
VUY2UFIKSDg1QXgxQVJMbUw3UVdzWXllUDVPMVlscjlQZklKRjAvaDRRcGFBSnpsTnBQN0xTV21D
RUdIUVdqOHk4QTZONQo2aitGeFF6djloUVFwNTNyRGlvN3pTT1lZNDhYeGFKWVlBMTNtT2J4YVpK
YXBBWmpOSTVQYXhNWHRhR1VLVFVjClF2UjYybFozNnMrYnVSaHdCWldpR2ZFK0dCYmJrcFJJTGZJ
eHk0emdINkt2S0F1eVluMnpVWFUvMFVodTJUR1IKZ1NWek1oZ1BNQkR2VFNqZzJXcE16UVRGeFpj
RDJpenZvZ3l4YXZnakNVUzczVVJNbG5WcTBVZGlldm4rYlA2UgpRVSswNDU4V0VRR1dzL0xNVlpB
Ky9uRTNmcXdoUEU2K21MTUYxS01rMVZFc3JWczhPTTI0b1daMW1HMkFHNjFHClpNSk9UeHVTTXpH
c0VFbEhDMjZ3TDNiZXNsc3p3Y0toY1lFdkJyRzc2bFcrQ01ha1dmWFJLcGF0ZlNnZjd0Y04KQzI2
cENSMGtwRnhiNGEwK1Jxb3lsTEhKV0NYcVFzV1FpVzVNbHI5dkg5ZGd3Q2V0MnVXaE1hZ0JSRk9Q
NUhMSwo5am1TanZ3MEd6WktXbVU0UVlhNEJBZ2hnaTkzdFdEcXB4WWtVNzVoQ0lpeEk1NENQaGM9
Cj1RL0Q4Ci0tLS0tRU5EIFBHUCBTSUdOQVRVUkUtLS0tLQo=

--===============2278101834050464631==--