From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Gibson To: passt-dev@passt.top Subject: Re: [PATCH 7/7] test/perf: Disable periodic throughput reports to avoid vhost hang Date: Thu, 22 Sep 2022 16:46:57 +1000 Message-ID: In-Reply-To: <20220921205507.2742203-8-sbrivio@redhat.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1716251400144167203==" --===============1716251400144167203== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Wed, Sep 21, 2022 at 10:55:07PM +0200, Stefano Brivio wrote: > It appears that if we run throughput tests with one-second periodic > reports, the sending side of the vhost channel used for SSH-based > command dispatch occasionally stops working altogether. I haven't > investigated this further, all I see is that output is truncated > at some point, and doesn't resume. Huh. I don't think I ever observed this. > If we use gzip compression (ssh -C) this happens less frequently, > but it still happens, seemingly indicating the issue is probably > related to vhost itself. >=20 > Disable periodic reports in iperf3 clients. The -i options were > actually redundant, so remove them from both test files as well as > from test_iperf3(). >=20 > Signed-off-by: Stefano Brivio > --- > test/lib/test | 2 +- > test/perf/passt_tcp | 2 +- > test/perf/passt_udp | 2 +- > test/perf/pasta_tcp | 2 +- > test/perf/pasta_udp | 2 +- > 5 files changed, 5 insertions(+), 5 deletions(-) >=20 > diff --git a/test/lib/test b/test/lib/test > index b69d519..d68ade4 100755 > --- a/test/lib/test > +++ b/test/lib/test > @@ -44,7 +44,7 @@ test_iperf3() { > '(' \ > ' for i in $(seq 0 '${__procs}'); do' \ > ' iperf3 -c '${__dest}' -p '${__port} \ > - ' -t'${__time}' -T s${i} '"${@}"' &' \ > + ' -t'${__time}' -i0 -T s${i} '"${@}"' &' \ > ' done;' \ > ' wait' \ > ')' > diff --git a/test/perf/passt_tcp b/test/perf/passt_tcp > index 5f0aa3a..5ba5450 100644 > --- a/test/perf/passt_tcp > +++ b/test/perf/passt_tcp > @@ -46,7 +46,7 @@ set THREADS 1 > set STREAMS 8 > set TIME 10 > hout OMIT echo __TIME__ / 6 | bc -l > -set OPTS -Z -P __STREAMS__ -l 1M -i1 -O__OMIT__ --pacing-timer 1000000 > +set OPTS -Z -P __STREAMS__ -l 1M -O__OMIT__ --pacing-timer 1000000 > =20 > info Throughput in Gbps, latency in =C2=B5s, one thread at __FREQ__ GHz, _= _STREAMS__ streams > report passt tcp __THREADS__ __FREQ__ > diff --git a/test/perf/passt_udp b/test/perf/passt_udp > index 6bd86ff..fd2ddc1 100644 > --- a/test/perf/passt_udp > +++ b/test/perf/passt_udp > @@ -38,7 +38,7 @@ hout FREQ [ -n "__FREQ_CPUFREQ__" ] && echo __FREQ_CPUFRE= Q__ || echo __FREQ_PROC > set THREADS 4 > set STREAMS 1 > set TIME 10 > -set OPTS -u -i1 -P __STREAMS__ --pacing-timer 1000 > +set OPTS -u -P __STREAMS__ --pacing-timer 1000 > =20 > info Throughput in Gbps, latency in =C2=B5s, __THREADS__ threads at __FREQ= __ GHz, one stream each > =20 > diff --git a/test/perf/pasta_tcp b/test/perf/pasta_tcp > index 44c5e54..1847c83 100644 > --- a/test/perf/pasta_tcp > +++ b/test/perf/pasta_tcp > @@ -25,7 +25,7 @@ set THREADS 2 > set STREAMS 2 > set TIME 10 > hout OMIT echo __TIME__ / 6 | bc -l > -set OPTS -Z -w 4M -l 1M -P __STREAMS__ -i1 -O__OMIT__ --pacing-timer 10000 > +set OPTS -Z -w 4M -l 1M -P __STREAMS__ -O__OMIT__ --pacing-timer 10000 > =20 > hout FREQ_PROCFS (echo "scale=3D1"; sed -n 's/cpu MHz.*: \([0-9]*\)\..*$/(= \1+10^2\/2)\/10^3/p' /proc/cpuinfo) | bc -l | head -n1 > hout FREQ_CPUFREQ (echo "scale=3D1"; printf '( %i + 10^5 / 2 ) / 10^6\n' $= (cat /sys/devices/system/cpu/cpu0/cpufreq/scaling_max_freq) ) | bc -l > diff --git a/test/perf/pasta_udp b/test/perf/pasta_udp > index abb88b0..27ea724 100644 > --- a/test/perf/pasta_udp > +++ b/test/perf/pasta_udp > @@ -23,7 +23,7 @@ hout FREQ [ -n "__FREQ_CPUFREQ__" ] && echo __FREQ_CPUFRE= Q__ || echo __FREQ_PROC > set THREADS 1 > set STREAMS 4 > set TIME 10 > -set OPTS -u -i1 -P __STREAMS__ > +set OPTS -u -P __STREAMS__ > =20 > info Throughput in Gbps, latency in =C2=B5s, one thread at __FREQ__ GHz, _= _STREAMS__ streams > =20 --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --===============1716251400144167203== Content-Type: application/pgp-signature Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="signature.asc" MIME-Version: 1.0 LS0tLS1CRUdJTiBQR1AgU0lHTkFUVVJFLS0tLS0KCmlRSXpCQUVCQ0FBZEZpRUVvVUx4V3U0L1dz MGRCK1h0Z3lwWTRnRXdZU0lGQW1Nc0JOc0FDZ2tRZ3lwWTRnRXcKWVNJOW54QUFzaXM1b1hsMnhK ZnhnZ2h3SXhPWE50eGxidUkySkZNaFV2TDRDV2FIYnNXeE1Ib1VLQ29sU0ZQaApqWU15aDhPck1u MlQ1bThCRERudS85Nnk1MDQ3TGRteko4WENPbjQ4cU96M1VucWNWTXRJMnhFbC83UWRaZWdNCmFS SENCQkUrQjBTUEVESE10Z0xRQlViNU1ZYkJJTzRISk5oVkFpdFJ3ZXRySzFnL3FjWWhaUkN1c2F2 REdLeUwKT3JlWjdCdm1UNlFPbkNuS05zRWcrYkZuczZjR25QZ0JCbitSeVJJTklHNmNKZE1iN2o2 a0w5NUJITmU1cDRYcgppUWJzZjM3aVpORW1vdzhUaDNLQnJkeUN5eHhBYU9vRGlMVHRSczhZa2ZL RFcrN0hTT3hQTGdBUytuQXM5bC9OCmlCL214bWRhQlJMTC8rRXZnZFF2QmtISUlFaVFMcUtFNWxO UVp5YktRWFRsRFBTTUNsSDlySzZRdEt1cVZwU2MKUjdOOVJnaHhqWG00T0VWTWNmSDU4bFNXMUk3 MmpOZTVrTlk5alNsNUFMeE83a3BaOWdqSlRoUi8veGpLZ2drbQp1bzNDRUZ6RXA2aEJJSnF4R25y MGNPS1hYZGFQU1YzMTl5ODVNblhhY2xnRWtKZTJkYUFxeEtjUWtKOXIxTlA3CmpXOFVKNTQ2MVVF VUFpb0dLRlRMeGpJQjREUnVRZ0xvWjdRUGF3ZENxbm9INnBLb3hOYTNHbGdMTUt6enhqd1UKeWhX MHpVejhac2Q0eVVMM09yU0prNlJsYS9pZ1VmRzliMHNvb3RIS29Ndis0aE5DdUlhRlRmTzBUbXFB TVNpTgpvYnE2aVAranN3a20zREdraDNPV01wU1c4VThvZlJTL1NSWGswd0lSYjhRZ0tsam5sWUU9 Cj10bFlBCi0tLS0tRU5EIFBHUCBTSUdOQVRVUkUtLS0tLQo= --===============1716251400144167203==--