From: David Gibson <david@gibson.dropbear.id.au>
To: passt-dev@passt.top
Subject: Re: [PATCH 5/7] test/lib: Restore IFS while executing directives in def blocks
Date: Thu, 22 Sep 2022 16:44:31 +1000 [thread overview]
Message-ID: <YywET39IsntGsbmP@yekko> (raw)
In-Reply-To: <20220921205507.2742203-6-sbrivio@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 923 bytes --]
On Wed, Sep 21, 2022 at 10:55:05PM +0200, Stefano Brivio wrote:
> If we don't, guest command dispatch will fail altogether, given that
> we use cat(1) on the enter file, which contains spaces.
>
> Signed-off-by: Stefano Brivio <sbrivio(a)redhat.com>
Huh. I wonder how this was working for me.
> ---
> test/lib/test | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/test/lib/test b/test/lib/test
> index 3ad178f..a9ffe83 100755
> --- a/test/lib/test
> +++ b/test/lib/test
> @@ -312,7 +312,7 @@ test_one_line() {
> IFS='
> '
> for __def_line in ${__def_body}; do
> - IFS= test_one_line "${__def_line}"
> + IFS="${__ifs}" test_one_line "${__def_line}"
> done
> IFS="${__ifs}"
> fi
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-09-22 6:44 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-21 20:55 [PATCH 0/7] Fixes and workarounds for tests, Coverity warnings Stefano Brivio
2022-09-21 20:55 ` [PATCH 1/7] test/perf: Always use /sbin/sysctl in tcp test Stefano Brivio
2022-09-22 6:28 ` David Gibson
2022-09-21 20:55 ` [PATCH 2/7] test/perf: Switch performance test duration to 10 seconds instead of 30 Stefano Brivio
2022-09-22 6:29 ` David Gibson
2022-09-21 20:55 ` [PATCH 3/7] tap: Check return value of accept4() before calling getsockopt() Stefano Brivio
2022-09-22 6:30 ` David Gibson
2022-09-21 20:55 ` [PATCH 4/7] conf, tcp, udp: Arrays for ports need 2^16 values, not 2^16-8 Stefano Brivio
2022-09-22 6:43 ` David Gibson
2022-09-22 8:21 ` Stefano Brivio
2022-09-22 23:39 ` Stefano Brivio
2022-09-23 2:09 ` David Gibson
2022-09-21 20:55 ` [PATCH 5/7] test/lib: Restore IFS while executing directives in def blocks Stefano Brivio
2022-09-22 6:44 ` David Gibson [this message]
2022-09-22 8:25 ` Stefano Brivio
2022-09-23 6:55 ` David Gibson
2022-09-21 20:55 ` [PATCH 6/7] test/lib: Wait on iperf3 clients to be done, then send SIGINT to servers Stefano Brivio
2022-09-21 20:55 ` [PATCH 7/7] test/perf: Disable periodic throughput reports to avoid vhost hang Stefano Brivio
2022-09-22 6:46 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YywET39IsntGsbmP@yekko \
--to=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).