From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Gibson <david@gibson.dropbear.id.au>
To: passt-dev@passt.top
Subject: Re: [PATCH 5/7] test/lib: Restore IFS while executing directives in
 def blocks
Date: Thu, 22 Sep 2022 16:44:31 +1000
Message-ID: <YywET39IsntGsbmP@yekko>
In-Reply-To: <20220921205507.2742203-6-sbrivio@redhat.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2871006277544773202=="

--===============2871006277544773202==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

On Wed, Sep 21, 2022 at 10:55:05PM +0200, Stefano Brivio wrote:
> If we don't, guest command dispatch will fail altogether, given that
> we use cat(1) on the enter file, which contains spaces.
> 
> Signed-off-by: Stefano Brivio <sbrivio(a)redhat.com>

Huh.  I wonder how this was working for me.

> ---
>  test/lib/test | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/test/lib/test b/test/lib/test
> index 3ad178f..a9ffe83 100755
> --- a/test/lib/test
> +++ b/test/lib/test
> @@ -312,7 +312,7 @@ test_one_line() {
>  			IFS='
>  '
>  			for __def_line in ${__def_body}; do
> -				IFS= test_one_line "${__def_line}"
> +				IFS="${__ifs}" test_one_line "${__def_line}"
>  			done
>  			IFS="${__ifs}"
>  		fi

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

--===============2871006277544773202==
Content-Type: application/pgp-signature
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="signature.asc"
MIME-Version: 1.0

LS0tLS1CRUdJTiBQR1AgU0lHTkFUVVJFLS0tLS0KCmlRSXpCQUVCQ0FBZEZpRUVvVUx4V3U0L1dz
MGRCK1h0Z3lwWTRnRXdZU0lGQW1Nc0JFZ0FDZ2tRZ3lwWTRnRXcKWVNMdk9oQUF0ck4xUXZXKzJ6
TFFicEpuNFJDUExCWE1iUVlnY3FpbjBFTWczMXBTUDZIMWlWZmxuYTJma0pCUQppM0hacW1CSys3
MWNTalJZZFBzZ2paUnkwTHNxSkRNcWpBc3o4S1R6SGZEKytObDJCUUorUHFTUHJwUWRLMWt0CjIz
bkRqOVFvOGF2SjhDd2hiZzF2M2NQV1pXeVNSSVZzc3VGd2NNT0VBckVZMU82bXBTM0hNZzJySHV4
QUJDcEUKdVFXQ0RLR255Z3FSSDRIZWVjNHoycXNrNk9Ra0kyazhhUHlLY3JReVd1TlZKOS96dFBy
akhoSjJ2NklDTnJuRwo1Q0NLdTY3a3FhRnowNXNGZG1qUUxwREd2bXdTVCtuMVg5d05ZUEN5NG85
KzVEQ2ltV0UvRlhPRHMvZDd2bkU0CnIyLzQvNEZENmkyMlMzZ1U3aGdaaGJMckdnYkE5NW1jc3lQ
U3ErRlBST21uZG9oOEFodWdUQWFUYk9GaXVLaGQKZjBTaFdvb1U0NE5pbzB4NHJMdTlxMnhHWW55
ZXpnUlFTaXJrZndjSStIMjE5RzkwbFNhK2g5VVRSNWRtdHNQOQp2eGRUYzNaTy9aWmZhR0pzUmJn
Z21qWkVONXhBaUtIYXdOWENManlWUkduWEp4ZHA5R1JSMmpxNUFDNklwK0VSCmJrZjBaWnEyYm9K
RzBsQ0Y5VzZTTGw2VXEzcGJMWUZNVWJmMitqTlBPWkU0aXkxd1RzRUFzcEFmQUx1RUdPNkEKQjN5
NzhBM29nZmJ0cjBkcTdmRW5LM21Fb0F6dzU3ZlVGQ0F2YkxqQkdlMTY2QWpreWJYTC9NVlFvYWtu
ekNNbQo3SEhzd3RvTUc4TU91clRCclpvSmQwOFNYZm1MV2JOcjBmOTMzSWwyOWJTaVA3SmRVUkk9
Cj1STW5ICi0tLS0tRU5EIFBHUCBTSUdOQVRVUkUtLS0tLQo=

--===============2871006277544773202==--