From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Gibson <david@gibson.dropbear.id.au>
To: passt-dev@passt.top
Subject: Re: [PATCH 3/8] passt.h: Include netinet/if_ether.h before struct ctx
 declaration
Date: Fri, 07 Oct 2022 17:23:30 +1100
Message-ID: <Yz/F4vfxsb2sn/J3@yekko>
In-Reply-To: <20221007004742.1188933-4-sbrivio@redhat.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============6687495942817566518=="

--===============6687495942817566518==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

On Fri, Oct 07, 2022 at 02:47:37AM +0200, Stefano Brivio wrote:
> This saves some hassle when including passt.h, as we need ETH_ALEN
> there.
> 
> Signed-off-by: Stefano Brivio <sbrivio(a)redhat.com>

Hrm.  So I had the impression that passt was using the convention that
it's the top level files responsibility to include all the
dependencies for a header before including the header, rather than
having headers include other headers they need.  Was I mistaken?  I'm
ok with either model, they each have their advantages, but I find
sticking to one or the other is generally better than a mix of both.

That is, it would be helpful to me for you to clarify the policy, but
for this specific patch

Reviewed-by: David Gibson <david(a)gibson.dropbear.id.au>

> ---
>  passt.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/passt.h b/passt.h
> index 48e1096..de79e7b 100644
> --- a/passt.h
> +++ b/passt.h
> @@ -133,6 +133,8 @@ struct ip6_ctx {
>  	struct in6_addr dns_fwd;
>  };
>  
> +#include <netinet/if_ether.h>
> +
>  /**
>   * struct ctx - Execution context
>   * @mode:		Operation mode, qemu/UNIX domain socket or namespace/tap

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

--===============6687495942817566518==
Content-Type: application/pgp-signature
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="signature.asc"
MIME-Version: 1.0

LS0tLS1CRUdJTiBQR1AgU0lHTkFUVVJFLS0tLS0KCmlRSXpCQUVCQ0FBZEZpRUVvVUx4V3U0L1dz
MGRCK1h0Z3lwWTRnRXdZU0lGQW1NL3hkc0FDZ2tRZ3lwWTRnRXcKWVNJcUpnLy9jSkdrKzMxSTVp
Uk5CRkpQU0ExWGVXMktkOE85T1lPVXIxa3RMRGlnRG1WZEU0d3k4cDMvSjg0ZwpSd3JTUDc1NzhH
ZUZiM2JZTnBhUFdWcEFXRGppRTVVZ1VtTjBUZHZQSkZrVWRHZjdOSUtPYzNLa01VZWFlUHlMCnRW
ZEhLQS81ZWNiaUh1eHlqeEpTVTd1aWwvNWJZa0NqSjdJL3Q1VS9xdDNUU1kzSURxSUVPT2RKTW5j
QXJXY0sKS0ZoU1l5OUtmd2taZEFiNE9FUGt2bjV0Vi9oUWhTQnFESFVISEpsUW1pNVljak1YeWZS
RTU2aDhBUy9LQTFqbwpDM2lFQ041dVVHam1oTmhjOGJ3VVhSVmJPN3UvcWNBR01ZZkhPRWhCMmh4
QW9jS3Mwek5lMVE4d1BHS2dkektuCmMvQVUrQzc0QU5uVGdiWFVLT1ZYMkZUL3cxVlVHRU5Wckpy
L1RhTGkvTnV4N01SbU9HMnJUWHRYcWw1TVNwYlUKWjZjU1laRXFyUjBiZDV1SnFqYXl0eXlGTkFL
VFpLSytZQ0MzY0xkK2Fjc3hrWU56WmtmUVJyN1VvNi9nV2dMVwpJMXk5dW9DRUtJVThadngwejNP
V1UwQ28xdE83SGdKWGFHYW5MMnNteUNIT3pvSjJvd0ZIbGtuMTI4UC8xV24wCmw2UjBOS3JIVklD
azBhYzdPMFQ3SkxZTXoyeGRPUmtTOGJZaDFqSlpYeUFGWHNBRTkzeVRWRW1HREtMb0ZQMk8KSEJx
WXJaL0JIT2NDNUVISkJSdGE2S204dFZCa0MyUDF3THE1ODFxSUFqUktmYjZ2Vzh2VDBSN2RCc3N1
OXN4Ugp1ellMK09vY2phdnREUVBRRm1kemRtMGkxRWhqU2dpTEtrVDJ0ZGN2SjUyZHVTUnBxR2c9
Cj01N1JxCi0tLS0tRU5EIFBHUCBTSUdOQVRVUkUtLS0tLQo=

--===============6687495942817566518==--