From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Gibson <david@gibson.dropbear.id.au>
To: passt-dev@passt.top
Subject:
 Re: [PATCH 20/28] cppcheck: Suppress same-value-in-ternary branches warning
Date: Thu, 29 Sep 2022 11:00:55 +1000
Message-ID: <YzTuR/NUyHUFE56o@yekko>
In-Reply-To: <20220928225806.101066a9@elisabeth>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4778371828822737315=="

--===============4778371828822737315==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Sep 28, 2022 at 10:58:06PM +0200, Stefano Brivio wrote:
> On Wed, 28 Sep 2022 14:33:31 +1000
> David Gibson <david(a)gibson.dropbear.id.au> wrote:
>=20
> > TIMER_INTERVAL is the minimum of two separately defined intervals which
> > happen to have the same value at present.  This results in an expression
> > which has the same value in both branches of a ternary operator, which
> > cppcheck warngs about.  This is logically sound in this case, so suppress
> > the error (we appear to already have a similar suppression for clang-tidy=
).
> >=20
> > Also add an unmatchedSuppression suppression, since only some cppcheck
> > versions complain about this instance.
> >=20
> > Signed-off-by: David Gibson <david(a)gibson.dropbear.id.au>
> > ---
> >  passt.c | 1 +
> >  1 file changed, 1 insertion(+)
> >=20
> > diff --git a/passt.c b/passt.c
> > index 4796c89..2c4a986 100644
> > --- a/passt.c
> > +++ b/passt.c
> > @@ -305,6 +305,7 @@ int main(int argc, char **argv)
> > =20
> >  loop:
> >  	/* NOLINTNEXTLINE(bugprone-branch-clone): intervals can be the same */
> > +	/* cppcheck-suppress [duplicateValueTernary, unmatchedSuppression] */
>=20
> Somewhat surprisingly to me, NOLINTNEXTLINE means "next line of code",
> not next line altogether -- given that this still works (I wouldn't
> have even tried).

Yeah, I wondered about that and came to the same conclusion.

--=20
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

--===============4778371828822737315==
Content-Type: application/pgp-signature
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="signature.asc"
MIME-Version: 1.0

LS0tLS1CRUdJTiBQR1AgU0lHTkFUVVJFLS0tLS0KCmlRSXpCQUVCQ0FBZEZpRUVvVUx4V3U0L1dz
MGRCK1h0Z3lwWTRnRXdZU0lGQW1NMDdqOEFDZ2tRZ3lwWTRnRXcKWVNLU2VnLzhDSHpXZllCbnBk
UmxINkpsOU9xTCt6MzROb0wrdjJGM2JnNEtjMmJYU0R2QTJQekdwQXZFdzlPVApRaVdVaU9UUXpK
cEIxS1J4UTNxeUtPRVZxUmlJL1Z6N2N5eDFkcGUzZXNSYllHbGh5TGp1VmhKVmlPa0hzbk9FCmlr
ZXNjRTF5ZUE5S2FlWVk3M1lkaEdkRW5KaWE3d1JaVVVPcStDVFc1b3ZQZ2puV3RYY0d5UUpUVWY5
alcycEIKaDVwYmswK1ZNaWQyc3lvTEN1enlObHA2WHA2S240YlAyTWZoVGtWZGpDVi9iMGRaTTlZ
WEk3ZkpqM1lWNUJGaAphcG1OZGhwMXkzZGh0VTg1OHRQR2tEaitHcUZwSU0zdUNBaElTNi93dS85
eUhOYWdXRDdEQTdYVXZWRFpYNjAwCnRZVlhDTHUrRDR0MEpValB4c1VrSUJjYStvbXljdUxoMHVW
TUt2VGZvZXoyT0gwYk9hZ01DaHNMUUdpcFk5KzQKVFpWeEpnZmhIQVA0bG8xWmZoVXpOWGY5dXRT
YVVCVzhKK2lzZmh1UUl2U3hzU1NtRmxsM0xhaUhPTzNMZGlLNQpxUTFKdUIxSWtqYUhxa3kzUSs0
aTNGd29QM1hqb1BCRVdUMUcwVzROZUFmdG9CUXpKTmp2WWJONUptUUtDcjdGClRmcHk1TE1oK0Fw
R1g1bzcyYi9BMnZnSXhadUNHaFlydjMwMFQ0RWo5eWtUdURDcHlub2N5dnBCQU04WVhhdFAKMFpN
TTUwWWNGelpVdWdWQmtSdVJ0U2FMdi96bWMyTXEzZVRBTk1IVzRmT1h6eWl3ZVh4aHVkdys5WEFX
TkQzOApMMCtJcVBDRXVRSFhkSEVlZ1F1MjVHUzd6ZjB4bDRMcCs3WGl2MkJTTlhnYTdsWVZsOW89
Cj1yME5KCi0tLS0tRU5EIFBHUCBTSUdOQVRVUkUtLS0tLQo=

--===============4778371828822737315==--