From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Gibson <david@gibson.dropbear.id.au>
To: passt-dev@passt.top
Subject: Re: [PATCH 21/28] cppcheck: Suppress NULL pointer warning in
 tcp_sock_consume()
Date: Thu, 29 Sep 2022 11:07:41 +1000
Message-ID: <YzTv3UngFH/Lynbo@yekko>
In-Reply-To: <20220928225837.190a0fed@elisabeth>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============5565945228349436746=="

--===============5565945228349436746==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

On Wed, Sep 28, 2022 at 10:58:37PM +0200, Stefano Brivio wrote:
> On Wed, 28 Sep 2022 14:33:32 +1000
> David Gibson <david(a)gibson.dropbear.id.au> wrote:
> 
> > Recent versions of cppcheck give a warning due to the NULL buffer passed
> > to recv() in tcp_sock_consume().  Since this apparently works, I assume
> > it's actually valid,
> 
> Yes, given that we use MSG_TRUNC to discard socket buffers, I thought
> it's cleaner to avoid supplying a data buffer altogether.
> 
> POSIX doesn't specify MSG_TRUNC, and whether the buffer can be NULL
> isn't specified in Linux documentation, but it works reliably (the
> kernel won't even look at it).

Ah, interesting.  I've update the comment and commit message with this
detail.

> This was actually the first step of a long-overdue plan: if you observe
> this through perf(1), you'll see some overhead in the kernel, which
> looks a bit more than a reasonable expectation for pure syscall
> overhead.
> 
> So, I planned to check if we can simplify the kernel path if no buffer
> is passed. I'll track this somewhere next week.
> 
> Even the day we add a vhost-user back-end, this overhead is still going
> to be there, as that wouldn't change anything host-side.
> 
> > but cppcheck doesn't know that recv() can take a NULL
> > buffer.  So, use a suppression to get rid of the error.
> 
> valgrind didn't know either, by the way -- see the corresponding
> suppression in test/valgrind.supp.
> 

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

--===============5565945228349436746==
Content-Type: application/pgp-signature
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="signature.asc"
MIME-Version: 1.0

LS0tLS1CRUdJTiBQR1AgU0lHTkFUVVJFLS0tLS0KCmlRSXpCQUVCQ0FBZEZpRUVvVUx4V3U0L1dz
MGRCK1h0Z3lwWTRnRXdZU0lGQW1NMDc5Y0FDZ2tRZ3lwWTRnRXcKWVNLazBRLytNREZSRmdId0tW
bDVjK0E2aCs2Sk1ZWjJDUFlsanZwU3dnNEtoZHo0N3VzV0VsczZwSi83UjZWTQpDaHNJV2hEMGsx
MmNDcU1pY0l6YkJEU1FsVHhDU0RTdEhBUUFXSks4VDFSNnlKV0RmczhwTk8wMkNPSDUyejhxCllz
ZTFDNlp4RlRSWEJrelhJUmVzK0tRUTVlQzlUTHgzYlkrTEV4TjFRNnVlbCtQQmpEbUVIOG5ob0Q3
TGMrNWQKSHkvUGdNTmhHYklodGlHcVl1aEJXZUVVOGhKelFjSGZaM2FvSUNpdFhsbFFsZ2NUbDRD
TG82QXlVYllZNk9LagppODkwUmtOeTBjYVdqQ24rZTloZmJldFNKWlU4WTM5SDRPdUJHMWhKTitp
SnVCOVhuU1ArT1Y5UHBMSzFYNjB3Cmd3OE9MY0ZIbXNLWTc1ZmltTVVkMkh5RDZOMk9saGhZNmJh
bmdlS0p3TElPSi9GS1JqNEZDc2w3d2VjVjFWaWUKT1JjZnZIanUxM2JzYWg0dERnMFBvdGlXRTFs
dll0RWZVbEJGUmE3VTlSYmt3K01rU2E3cGg1d003VEswRVBtZgpIQzZWWFBBeVkrUXlEcys2TjlG
Mks0OGJjNkRUVWVzUVRTUVNLRzZqL0QzVGxoY0R4aTNmSFhBeE4vMDc1SE5yCmY2OU5YWVlrVTVx
ODh4cmFSNWhOQVBJcGNFc3JXMlVPbmFTeEIxRjlyNVE0Kyt6UFI4cEVsZ1B4S0dnRnY0eHYKNHB0
ZTNTSk1nSzZFUHFjZWRDQmtkWkhOcDVnOUl5WG01R0hhcXlSRllaUHlMazhnem9vdXhjVWlGa1hG
eWtGUAptaUVvS2ZDbXZSSlB1Q3pGcGUxMi8va3BYSFd3U2NYL0xzWnd1cWJDb1hLSW1GSHJLWHc9
Cj1JcDd1Ci0tLS0tRU5EIFBHUCBTSUdOQVRVUkUtLS0tLQo=

--===============5565945228349436746==--