From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Gibson <david@gibson.dropbear.id.au>
To: passt-dev@passt.top
Subject: Re: [PATCH 25/28] cppcheck: Remove unused objectIndex suppressions
Date: Thu, 29 Sep 2022 11:12:45 +1000
Message-ID: <YzTxDQyjuuZT/DCx@yekko>
In-Reply-To: <20220928225829.03aed371@elisabeth>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============5866491843796268019=="

--===============5866491843796268019==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Sep 28, 2022 at 10:58:29PM +0200, Stefano Brivio wrote:
11;rgb:ffff/ffff/ffff> On Wed, 28 Sep 2022 14:33:36 +1000
> David Gibson <david(a)gibson.dropbear.id.au> wrote:
>=20
> > I can't get these warnings to trigger on the cppcheck versions I have, so
> > remove them.  If we find in future we need to replace these, they should =
be
> > replaced with inline suppressions so its clear what's the section of code
> > at issue.
>=20
> At least for TCP:
>=20
> -	/* First buffer is to discard data, last one may be partially filled. */
> -	iov[-1].iov_len =3D already_sent;
>=20
> gone with commit 38fbfdbcb916 ("tcp: Get rid of iov with cached MSS, drop
> sendmmsg(), add deferred flush").

Ah, thanks, I've added that background to the commit message.

--=20
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

--===============5866491843796268019==
Content-Type: application/pgp-signature
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="signature.asc"
MIME-Version: 1.0

LS0tLS1CRUdJTiBQR1AgU0lHTkFUVVJFLS0tLS0KCmlRSXpCQUVCQ0FBZEZpRUVvVUx4V3U0L1dz
MGRCK1h0Z3lwWTRnRXdZU0lGQW1NMDhRWUFDZ2tRZ3lwWTRnRXcKWVNLVURRLy9WQjFpWXN2cmFt
ZXd0RTJ2UVdHTHo5ME1ONnNqZkV1cm1Gbk42dTlJZW1POEhVR1pSSkcvNjJCYgpPMFQ1UTM5QkNv
Uk01czRGMEVoaDRnVFlYOXVXRng1c3FIYThQd1hsRmNudEhlRTYxMjJ6andVMVpwNTNWTkxmClIx
VXVmYmhMQWxMVUFvSm5aSjQrQy94STlRMnMwQVpmL3JSNE9mN0o5bVFFMk9VQzJBWEVNdzBZY3Ax
cTVCS3UKa2FFLysvMmtUWGFUVVc3aWdteU1sdDlSUm5KSXRHTXBWdFMzZ2pjYnJ3R0VVK0N6WVJU
MUFHejc2QXljSFR5RgpaL2JyRkdHU0oycmM5RE1OaDRXT3N5c2hSdDNqbVlJMHNyRjZGYzJQNGJI
YzYvVzNBOWtBSmFDTmNvb2w3K015CjM5aFpHbVkxOFNNVFhRd0xQVUJaUHNmWlh4S2p1eHNSL2sw
UHBVY0pKNE5ORHZyWFhSQXF3K1k0QUlhSHJmamoKNSs4RXBaKzVBYXlDazRjaHl6dnZsOHdVYVBm
N3l6dnNCWjEvaUpRd2pYN05ScVBTcXFIeHZXT0RrZUhlTVVmWQpNNHdkcytNR3lzV3lLRWt3WXMr
b1pWMktpQ3JlVnJPK3pHLzlTRkQ1eU93YW56NUYxZ3g1cGtEMnlhQVh3dTFhCjlDRG5lTEdLWWcr
WWF6TEErUWZVTXFXYmFkdk5IWmU1Vkgvd3huSU56M0pIL2dpU0dHTEk1NDhZR0dtRm0yeFgKWllt
eG9nOGhScXJnVU11TEcxNDhhNDgyYk1hZDhTZDNrT1YzcVQ1OGlDcVB4NWxXRnVZVGxEaVlwdlJE
amlxMgptRnBkWjMxdFBjTVRZYVBhOGFkalJCVVRPTklrYUxmY2l3ZWR0eXpaTCtCRllBb29DWW89
Cj1FNUhMCi0tLS0tRU5EIFBHUCBTSUdOQVRVUkUtLS0tLQo=

--===============5866491843796268019==--