From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Gibson To: passt-dev@passt.top Subject: Re: [PATCH 24/28] cppcheck: Remove unused knownConditionTrueFalse suppression Date: Thu, 29 Sep 2022 11:24:36 +1000 Message-ID: In-Reply-To: <20220928225825.14a50d29@elisabeth> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4884619733242498789==" --===============4884619733242498789== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit On Wed, Sep 28, 2022 at 10:58:25PM +0200, Stefano Brivio wrote: > On Wed, 28 Sep 2022 14:33:35 +1000 > David Gibson wrote: > > > I can't get this warning to trigger, so I think this suppression must be > > out of date. Whether that's because we've changed our code to no longer > > have the problem, or because cppcheck itself has been updated to remove a > > false positive I don't know. > > The former: you got rid of that case with the rework of the PID parsing. Hmm... I couldn't manage to trip the warning even if I went back before that rework. I did only try cppcheck-2.7 though. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --===============4884619733242498789== Content-Type: application/pgp-signature Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="signature.asc" MIME-Version: 1.0 LS0tLS1CRUdJTiBQR1AgU0lHTkFUVVJFLS0tLS0KCmlRSXpCQUVCQ0FBZEZpRUVvVUx4V3U0L1dz MGRCK1h0Z3lwWTRnRXdZU0lGQW1NMDg4MEFDZ2tRZ3lwWTRnRXcKWVNLWnRCQUFuNExPOG9mdmZu cUlWRmlZUTdURy9KcEI4UDVrdlRVYkRuWmNwb00vZzhqVmJoaDI0Y3Jjd1lmZQpwRXRKYzZiNTRr anJsYmRST2hpRTR6UDhrYi85WmxUMVlzTHV3Wk8wTFZsaFdMS3Q2dDRwcGpRUW5VMU9RdEl5CkZp MzRiLytqYmtVRFpXcldoL1N5TDkwNE5sY3VkQ1d0NC9XT01zZ0ZTaWZBNm1KcFhRMno3ZUxuL2U2 eUFkY0cKVUNEVmxLa0wrazJHMEs1UUNBUkZ0VHJFN2pER1lSK1Vvc0REMUxvdDRZOXdRMFl3Rnp5 ZmVqZ2VWdnlqL0FweQpKcGVBOGlvdVdRNjlTZ1hKZGlBZSt6eWIvN0p2WGNtRWJJcjVNMjE4Tkxw TDg0WEF2MFRyMkpSaXhFRC9aY0JaCmpzbS96U3dYc05RMmhHUHJYaEFyeTh4TXFEazNMd29nSG5o YmJXUC9GS3JSNHMzdnJZbzRoWnlhU3pMd0x6Qm4KTjJ2SzBzS2dHUklMeUxETnFZMkozK3ZwZWY2 WGdWN05XckFMTjdtN2NwRTlST2puSnQvN1lEZmx1SGpQV0NsUAp1ZHVyQlpKQ0NSUk01NlNGZERr T3JZV1FVTXcvVGdyOXZmaUR4c21kdnVteVcrSlF6VGYwMVc3TVhDdyt2MWVRCmIzUmdMaTNueHpY K1NaQkNBdko4TVYrVFpjcFp5eUlSc3lLb1lPN3pVcURQQjhlbS9nSU05Q0M5K0dOR0twVmwKb29l RE81L2ljTVk4RkdFVU9hUjc1S0VZMU5CMm1NYTZPRWpEZExSVUdmYitZTVdPODg4MHZLUDFJaWZ2 akpGegpZcDhXQjFVbHlBYTVLUUE1azc2aUZYR2RXZkZ4RkVjSzg4SlliR3M1eVd2dUF0RWduVUE9 Cj1pYVAwCi0tLS0tRU5EIFBHUCBTSUdOQVRVUkUtLS0tLQo= --===============4884619733242498789==--