From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202502 header.b=iXcfUEiz; dkim-atps=neutral Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id A3D135A0008 for ; Thu, 03 Apr 2025 07:38:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202502; t=1743658684; bh=be0EJKG1dddavi60EuUm+zUOJAhVooU+Nn+fPM5IfrY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=iXcfUEizRg06jxZWP5UP9cY1zW0pEfmlEcxbVUEpqelW3KkY6na2dMRQG09V5/g7O U1wtWz1Foa8rnm4bN30JE8ohG6MxFUpYvbDMshBm8F+CaHdi3YcjrYf5/GKNRiR9sb BdZ8RcIs/aR2d96qKx7zty7w8vDKRXTWuK42OT4YVOsbHBiMfv3iruerRzciNWoacv CfHSyziHwHMvzL3ssLq8eleptCMpiuqRbdDo4oDXYyM9cg2SoiGcseCzltXrA88MHm upjf4mNIwH4ANaIVct7T9C0pErG4OZffLC82Mjhj4KRbYOWPfh6jqnwYCdMYwm575Q KOaKOqm6qMPQw== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4ZSr9m5JwXz4x3p; Thu, 3 Apr 2025 16:38:04 +1100 (AEDT) Date: Thu, 3 Apr 2025 16:00:53 +1100 From: David Gibson To: Laurent Vivier Subject: Re: [PATCH 06/18] arp: Convert to iov_tail Message-ID: References: <20250402172343.858187-1-lvivier@redhat.com> <20250402172343.858187-7-lvivier@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="85JGO1UfLMRmuXZJ" Content-Disposition: inline In-Reply-To: <20250402172343.858187-7-lvivier@redhat.com> Message-ID-Hash: V7NCOSS3WWH2KVTSHTYOSPDG5EFIVJZL X-Message-ID-Hash: V7NCOSS3WWH2KVTSHTYOSPDG5EFIVJZL X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --85JGO1UfLMRmuXZJ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Apr 02, 2025 at 07:23:31PM +0200, Laurent Vivier wrote: > Use packet_base() and extract headers using IOV_REMOVE_HEADER() > rather than packet_get(). >=20 > Signed-off-by: Laurent Vivier Reviewed-by: David Gibson > --- > arp.c | 12 +++++++++--- > packet.c | 1 - > 2 files changed, 9 insertions(+), 4 deletions(-) >=20 > diff --git a/arp.c b/arp.c > index 9d68d7c3b602..cd0e15de7de0 100644 > --- a/arp.c > +++ b/arp.c > @@ -77,11 +77,17 @@ int arp(const struct ctx *c, const struct pool *p) > const struct ethhdr *eh; > const struct arphdr *ah; > const struct arpmsg *am; > + struct iov_tail data; > + struct arphdr ahc; > + struct ethhdr ehc; > + struct arpmsg amc; > =20 > - eh =3D packet_get(p, 0, 0, sizeof(*eh), NULL); > - ah =3D packet_get(p, 0, sizeof(*eh), sizeof(*ah), NULL); > - am =3D packet_get(p, 0, sizeof(*eh) + sizeof(*ah), sizeof(*am), NULL); > + if (!packet_base(p, 0, &data)) > + return -1; > =20 > + eh =3D IOV_REMOVE_HEADER(&data, ehc); > + ah =3D IOV_REMOVE_HEADER(&data, ahc); > + am =3D IOV_REMOVE_HEADER(&data, amc); > if (!eh || !ah || !am) > return -1; > =20 > diff --git a/packet.c b/packet.c > index 25ede38b94cb..8066ac12502b 100644 > --- a/packet.c > +++ b/packet.c > @@ -165,7 +165,6 @@ void *packet_get_do(const struct pool *p, size_t idx,= size_t offset, > * > * Return: pointer to start of data range, NULL on invalid range or desc= riptor > */ > -/* cppcheck-suppress unusedFunction */ > bool packet_base_do(const struct pool *p, size_t idx, > struct iov_tail *data, > const char *func, int line) --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --85JGO1UfLMRmuXZJ Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmfuFgUACgkQzQJF27ox 2Ge8RhAAi7I7X/bFzTZopx9mHGV1zzWKvoUbQV5Lmz1pQhdJjyb9jqcuQxBqCuAL G2h0o6qN4UrUPyBGMO6SCY8vNXNcYD2rW1uvNtwWZHqA5bqAxt7i4AW0TBn5IrMq ONB/FqgcsM2NeQpXJUKPuuKqAYhttpq9cvgT0whBkzdc3/1fZGnaBzPeGpYe9eOm O6kdSDPadeeONbof5ZT2FagDVa83iNSoJ1YmTn6NLQXzj/MR8rBTPUstXAWSpPIT PLQr2LQd4lbVmM6PB3FVLWvFPRleouj1QbKWsS9lCcsu41y5BqupXXnu8sz3RxSz iNrajjb1h1IT+fTSRxHxnZNVSTCvUwJNKFkSxFyGfTws7rrfjUMdXoV0JkBnxSQM CU+a2xTaVah+YpMHVocP9qIWssPzBmHGSq4ZjgzL1AB+gh95C5ZoxBYmty/ydyq5 eY/yLVqDdTz6Ba3N8yIalPNqe+1StMjy4tIfqTKMXv9f3Zi+MJS4jmTkG+iRq5M1 hFQKVUgeOPhtcwq4vZRQqrlt033077fbXktw+8kbKSTCPRzPojWhbp65hoVdFtxn rLHm6ke4iIOrp/x1uiXqgNHhvz9j+RkHJ4fA7Rp5ogMaqS9+Xns7HLlU0pR1dPth OEPyxyZ+g6TH0BhbCzaNENbX/ckxZ/DrkogOEaZB9de+dWsR0W0= =Tjz8 -----END PGP SIGNATURE----- --85JGO1UfLMRmuXZJ--