From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202502 header.b=CKpD0lkU; dkim-atps=neutral Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id 5FB775A0008 for ; Thu, 03 Apr 2025 07:38:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202502; t=1743658684; bh=vXy14P/vNZ3EDVOSVUhIRqB0SvJNjb7gJwleZWJakZ0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CKpD0lkUVWejcrfgoJ3Hnxl1D6Cj0LbAnB2s4LaIa9saesHTPNahTWtODJPn0yP8d EoybAGxA67jUggaB0yaggPMmjSteri6llVOj8jKWY7DaS6BoIN+p6luRLfcA5XIfEv ZFcKnVxxOVPdmcs0u35VFPDAOCMzM4druAOhCu/rsULQZBNzGlcgQVKXCGzBYrByMq xHLuX5OPrFtCr9tvD4mWRa0nC4NpU0bofdRhPxqPZYDCzEZ5GoDuZsvjT5feqCWt9x 2KmnaaFmIvziyx4Ur8torNoMnw7LfDfr7mRe0O3LahZ/OpU4bPNESTh6MXtRsRC2hI Z8+px8sDF2RTw== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4ZSr9m5MKmz4x0t; Thu, 3 Apr 2025 16:38:04 +1100 (AEDT) Date: Thu, 3 Apr 2025 16:01:37 +1100 From: David Gibson To: Laurent Vivier Subject: Re: [PATCH 07/18] ndp: Convert to iov_tail Message-ID: References: <20250402172343.858187-1-lvivier@redhat.com> <20250402172343.858187-8-lvivier@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="dMM97TPBKL7QVOHM" Content-Disposition: inline In-Reply-To: <20250402172343.858187-8-lvivier@redhat.com> Message-ID-Hash: W57ZY52VDFTY2ISHFHYWH6D6LX57X3IQ X-Message-ID-Hash: W57ZY52VDFTY2ISHFHYWH6D6LX57X3IQ X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --dMM97TPBKL7QVOHM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Apr 02, 2025 at 07:23:32PM +0200, Laurent Vivier wrote: > Use packet_base() and extract headers using IOV_REMOVE_HEADER() > rather than packet_get(). >=20 > Signed-off-by: Laurent Vivier Reviewed-by: David Gibson > --- > ndp.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) >=20 > diff --git a/ndp.c b/ndp.c > index ded2081ddd1d..64e25d5455b4 100644 > --- a/ndp.c > +++ b/ndp.c > @@ -351,8 +351,13 @@ int ndp(const struct ctx *c, const struct icmp6hdr *= ih, > =20 > if (ih->icmp6_type =3D=3D NS) { > const struct ndp_ns *ns; > + struct iov_tail data; > + struct ndp_ns nsc; > =20 > - ns =3D packet_get(p, 0, 0, sizeof(struct ndp_ns), NULL); > + if (!packet_base(p, 0, &data)) > + return -1; > + > + ns =3D IOV_REMOVE_HEADER(&data, nsc); > if (!ns) > return -1; > =20 --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --dMM97TPBKL7QVOHM Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmfuFjAACgkQzQJF27ox 2GfDdA/8Cl48gcCVJYDKSROGiBLD3YDrB4I0IB2R7ZG9NbWopkNlVLBC7PBKnQri Tu2W8QyIZts6gYKd3JKEmRwXHlraxhiZqbUaxR8KgqskKOjVHxhKH0WEcp5kWGet wX9cGlm6TQG//0M07d7zoZzeSQzbIXl6s2aphs9kyfGjjH+2r5RJaGlPtlMMFsoj x6zcE6E1ODsfQcZrP2H3ijlsr4JLEqvlYEo5j4q8zgIXPoIsjs2rAvpcxWgMWIxS 3qdBAn645xgEtufWPwTQflY4S4aH7BoBS/GldJxzSwcNqZPhzVgJ8PZbKbXWppDD 7+iwMh2TzL8Qfgerkx2NeW709HZ/gY8lBYHF3xtk7icW9SzdqGCN8QJ60GSfm8ui lF8hevsVCAffy/ZPssWHW1fWdluGDn+PbpgQ1FUgvSxZFF36WUfpcOBsSwjqZzRX TxFCklZnT9tM86Zh0o+Kq1AFkDo5CABfPoEbdPoWodkp1uo2ukNUqFbRuBHZXGAv PHNYugQgTHMlUj8EQ+s5mYcOzFc5JWN+dtZrOTQOWco8WttAyQkfnyLqmJbtle5F JpSqI+G5szlKqFUbpV2oULrwgeI+rEtU1rCBBZl6bBDYPaaFVTGpKr9hTZttYl2f BxWljbVnkUyFeUOyyERY5Rv7KOeeyRYfGZ6BJWoECMm+wDKDv90= =v0Ld -----END PGP SIGNATURE----- --dMM97TPBKL7QVOHM--