Re: [PATCH] passt.1: Fix "default" note about --map-guest-addr

[David Gibson <david@gibson.dropbear.id.au>]

[-- Attachment #1: Type: text/plain, Size: 1749 bytes --]

On Mon, Nov 25, 2024 at 11:43:19AM +0100, Stefano Brivio wrote:
> It's not true that there's no mapping by default: there's no mapping
> in the --map-guest-addr sense, by default, but in that case
> the default --map-host-loopback behaviour prevails.
> 
> While at it, fix a typo.
> 
> Fixes: 57b7bd2a48a1 ("fwd, conf: Allow NAT of the guest's assigned address")
> Signed-off-by: Stefano Brivio <sbrivio@redhat.com>

Reviewed-by: David Gibson <david@gibson.dropbear.id.au>

> ---
>  passt.1 | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/passt.1 b/passt.1
> index f5cf8a4..8d1d860 100644
> --- a/passt.1
> +++ b/passt.1
> @@ -381,14 +381,14 @@ Translate \fIaddr\fR in the guest to be equal to the guest's assigned
>  address on the host.  That is, packets from the guest to \fIaddr\fR
>  will be redirected to the address assigned to the guest with \fB-a\fR,
>  or by default the host's global address.  This allows the guest to
> -access services availble on the host's global address, even though its
> +access services available on the host's global address, even though its
>  own address shadows that of the host.
>  
>  If \fIaddr\fR is 'none', no address is mapped.  Only one IPv4 and one
>  IPv6 address can be translated, and if the option is specified
>  multiple times, the last one for each address type takes effect.
>  
> -Default is no mapping.
> +By default, mapping happens as described for the \-\-map-host-loopback option.
>  
>  .TP
>  .BR \-4 ", " \-\-ipv4-only

-- 
David Gibson (he or they)	| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you, not the other way
				| around.
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]