From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202410 header.b=GSNZSq4m; dkim-atps=neutral Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id 3BE2B5A004C for ; Tue, 26 Nov 2024 01:41:23 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202410; t=1732581675; bh=mVRJfV+9I4OHLdGPyzn4P522gDxEHBiLHFa2Bk0oTl0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GSNZSq4mq/CPHguR2W8IZX227QBzzwe9DZFhUQblOa3YwPPJlgFSfsAUWBPu1ttnO XzoiL/5rC0uJH0eZbpfQrJ58QlLgpTQKmolLoQ3DC28LuskROGYoFtil82fmYarhEa Z90renIe+x3r7veKB+mbfgkWXU62L2eN3TpuzwzR5eYNPOwrUghoGC/yGPfmxcrCoL CM0T3T87l2t8uDVJ48Qle/5mLFMZEo/Op4vBIuM93miXMS5PvLRmSy4rHfbCaHySuI rFNAJcDV0cfh+tRuk9KahT6c8a9lnzJvrOt14pXd1TzIhSJgdz+Ah+42BK7/8Urzfm LTBfMei2CjoZw== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4Xy3fM19Pxz4xSQ; Tue, 26 Nov 2024 11:41:15 +1100 (AEDT) Date: Tue, 26 Nov 2024 11:40:35 +1100 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH] passt.1: Fix "default" note about --map-guest-addr Message-ID: References: <20241125104319.156626-1-sbrivio@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="9CK/beaynM8eDj3D" Content-Disposition: inline In-Reply-To: <20241125104319.156626-1-sbrivio@redhat.com> Message-ID-Hash: 2KRIGLN66HPL4O7WDFDTCHDEAUMR3BXQ X-Message-ID-Hash: 2KRIGLN66HPL4O7WDFDTCHDEAUMR3BXQ X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --9CK/beaynM8eDj3D Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Nov 25, 2024 at 11:43:19AM +0100, Stefano Brivio wrote: > It's not true that there's no mapping by default: there's no mapping > in the --map-guest-addr sense, by default, but in that case > the default --map-host-loopback behaviour prevails. >=20 > While at it, fix a typo. >=20 > Fixes: 57b7bd2a48a1 ("fwd, conf: Allow NAT of the guest's assigned addres= s") > Signed-off-by: Stefano Brivio Reviewed-by: David Gibson > --- > passt.1 | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/passt.1 b/passt.1 > index f5cf8a4..8d1d860 100644 > --- a/passt.1 > +++ b/passt.1 > @@ -381,14 +381,14 @@ Translate \fIaddr\fR in the guest to be equal to th= e guest's assigned > address on the host. That is, packets from the guest to \fIaddr\fR > will be redirected to the address assigned to the guest with \fB-a\fR, > or by default the host's global address. This allows the guest to > -access services availble on the host's global address, even though its > +access services available on the host's global address, even though its > own address shadows that of the host. > =20 > If \fIaddr\fR is 'none', no address is mapped. Only one IPv4 and one > IPv6 address can be translated, and if the option is specified > multiple times, the last one for each address type takes effect. > =20 > -Default is no mapping. > +By default, mapping happens as described for the \-\-map-host-loopback o= ption. > =20 > .TP > .BR \-4 ", " \-\-ipv4-only --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --9CK/beaynM8eDj3D Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmdFGPgACgkQzQJF27ox 2GcySw/6Amzy5cBE2Tm1bbP/H4Sy6/3OPZbtfjBaEjVCRTXSjxH8c9asataMczel SU7nAFoeKtwzWmUHFcxNs9Hn2OEh3zriUi4xNdMI4YpurEgUYnE4hd6PO8ZEXPRM W+eiRlBK+jOacDHiZEi5YdqfbhU4iMfo5UtF4mt3ovGmKfbwMLhBgCUcWMQA3Gzp 16AjPbc9mBm79NUAGNDKeO78wQRBZt24BUX9VkfBvCZkSpYb5yI7huABZyHCpqfS pciZw+U87Rf1inmMQe438MAym0Da2IUZzB+sJwZf61LWh90yQAQ32BWFkhxjkMMD yd1suIiuAWiNQsdgtovva/zSeJp4pJ+iJo1qOzHkurXoY1trmGlhBhN5wyIha1BO xtOtFAnqi9MXB93kU0JMD9Nes1v50s9nW8BPxlI9bscuPZKOodv/y4ekp2A/q6bD LYcGnITwBdusYFZnRajmtj3tR62hEvwFpCZ1R1q4ts3CFcXRcAVAU+NGSLf5CPrQ MvzgKUNLTYVSNMg4QJoLYMAUME4FNQoeD7BJBW45g/CFiZ8krunyTCy1edu5t7Hb F9aB1qEnVmFwAsmfKdERYIhLkXc1JbL2z2CRR1SJ3dFBR70f+q8pAKzOzz/MO6Ld uI2T42+E9rvNkLoChTHIo5Wq1dl90RU7ytgQ0NxdZ2i7gFkurxk= =F3y1 -----END PGP SIGNATURE----- --9CK/beaynM8eDj3D--