Re: [PATCH] conf, passt.1: Update --mac-addr default in usage() and man page

[David Gibson <david@gibson.dropbear.id.au>]

[-- Attachment #1: Type: text/plain, Size: 1821 bytes --]

On Mon, Nov 25, 2024 at 11:47:33AM +0100, Stefano Brivio wrote:
> Fixes: 90e83d50a9bd ("Don't take "our" MAC address from the host")
> Signed-off-by: Stefano Brivio <sbrivio@redhat.com>

Reviewed-by: David Gibson <david@gibson.dropbear.id.au>

> ---
>  conf.c  | 2 +-
>  passt.1 | 3 +--
>  2 files changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/conf.c b/conf.c
> index 551c2b0..3a84669 100644
> --- a/conf.c
> +++ b/conf.c
> @@ -826,7 +826,7 @@ static void usage(const char *name, FILE *f, int status)
>  		"  -n, --netmask MASK	Assign IPv4 MASK, dot-decimal or bits\n"
>  		"    default: netmask from matching address on the host\n"
>  		"  -M, --mac-addr ADDR	Use source MAC address ADDR\n"
> -		"    default: MAC address from interface with default route\n"
> +		"    default: 9a:55:9a:55:9a:55 (locally administered)\n"
>  		"  -g, --gateway ADDR	Pass IPv4 or IPv6 address as gateway\n"
>  		"    default: gateway from interface with default route\n"
>  		"  -i, --interface NAME	Interface for addresses and routes\n"
> diff --git a/passt.1 b/passt.1
> index 8d1d860..15c8338 100644
> --- a/passt.1
> +++ b/passt.1
> @@ -176,8 +176,7 @@ according to the CIDR block of the assigned address (RFC 4632).
>  .BR \-M ", " \-\-mac-addr " " \fIaddr
>  Use source MAC address \fIaddr\fR when communicating to the guest or to the
>  target namespace.
> -Default is to use the MAC address of the interface with the first IPv4 default
> -route on the host.
> +Default is the locally administered MAC addresses 9a:55:9a:55:9a:55.
>  
>  .TP
>  .BR \-g ", " \-\-gateway " " \fIaddr

-- 
David Gibson (he or they)	| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you, not the other way
				| around.
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]