From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202410 header.b=EyrZwA1z; dkim-atps=neutral Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id 59B7F5A004C for ; Tue, 26 Nov 2024 01:45:16 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202410; t=1732581905; bh=uDVGi/Ot9UIPjebVxIL6isIEqDu1Kcs5ey7nexxgogI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EyrZwA1zIOASQ8piRkS8ADLGOF5p/bzj1QJdy3TIse47RI7bYk530JKEx45Bx4GsU V2lYJvU9qVoelcMa5304UR2vqbTGF1gl8/SoElsFibest7XERItInWMKYRQH7nHDax F5GFzMZ58+ry7NBmzt9hx7eTLb8HwIbOvSk1GVA5dW99lNPXf56ixw155Ksff2QfVP 1z1SgXhNEVKhXoeJyKUFHh6CozgJcXZ16PD57x9AHcVqTMA/J3uBFSmcc2Xye4aEMq lrjE1ERGHF4AyISYyhHvISFk6GcqJqPtHbCrGrp3rA1cKFlz0Q65i4SSGJvzNVD8ou Pb9vII1cWzF/Q== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4Xy3kn00fnz4wy6; Tue, 26 Nov 2024 11:45:04 +1100 (AEDT) Date: Tue, 26 Nov 2024 11:45:01 +1100 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH] test/perf: Select a single IPv6 namespace address in pasta tests Message-ID: References: <20241125105801.266838-1-sbrivio@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="OJprZpUac0QUzgSL" Content-Disposition: inline In-Reply-To: <20241125105801.266838-1-sbrivio@redhat.com> Message-ID-Hash: F5M3DSUE567IC2CJWYVZHPBR5HVTIJID X-Message-ID-Hash: F5M3DSUE567IC2CJWYVZHPBR5HVTIJID X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --OJprZpUac0QUzgSL Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Nov 25, 2024 at 11:58:01AM +0100, Stefano Brivio wrote: > By dropping the filter on prefix length, commit 910f4f910301 > ("test: Don't require 64-bit prefixes in perf tests") broke tests on > setups where two global unicast IPv6 addresses are available, which > is the typical case when the "host" is a VM running under passt with > addresses from SLAAC and DHCPv6, because two addresses will be > returned. >=20 > Pick the first one instead. We don't really care about the prefix > length, any of these addresses will work. Ah.. I do have two IPv6 addresses on my host, but they're not on the same interface, which is why it didn't trigger this. Reviewed-by: David Gibson Fixes: 910f4f910301 ("test: Don't require 64-bit prefixes in perf tests") > Link: https://archives.passt.top/passt-dev/20241119214344.6b4a5b3a@elisab= eth/ > Signed-off-by: Stefano Brivio > --- > test/perf/pasta_tcp | 2 +- > test/perf/pasta_udp | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/test/perf/pasta_tcp b/test/perf/pasta_tcp > index 88284b2..bc0de3c 100644 > --- a/test/perf/pasta_tcp > +++ b/test/perf/pasta_tcp > @@ -211,7 +211,7 @@ tr TCP throughput over IPv6: host to ns > iperf3s ns 10002 > =20 > nsout IFNAME ip -j link show | jq -rM '.[] | select(.link_type =3D=3D "e= ther").ifname' > -nsout ADDR6 ip -j -6 addr show|jq -rM '.[] | select(.ifname =3D=3D "__IF= NAME__").addr_info[] | select(.scope =3D=3D "global").local' > +nsout ADDR6 ip -j -6 addr show|jq -rM '[.[] | select(.ifname =3D=3D "__I= FNAME__").addr_info[] | select(.scope =3D=3D "global").local] | .[0]' > bw - > bw - > bw - > diff --git a/test/perf/pasta_udp b/test/perf/pasta_udp > index 3d07091..ab2f3e8 100644 > --- a/test/perf/pasta_udp > +++ b/test/perf/pasta_udp > @@ -196,7 +196,7 @@ tr UDP throughput over IPv6: host to ns > iperf3s ns 10002 > =20 > nsout IFNAME ip -j link show | jq -rM '.[] | select(.link_type =3D=3D "e= ther").ifname' > -nsout ADDR6 ip -j -6 addr show|jq -rM '.[] | select(.ifname =3D=3D "__IF= NAME__").addr_info[] | select(.scope =3D=3D "global").local' > +nsout ADDR6 ip -j -6 addr show|jq -rM '[.[] | select(.ifname =3D=3D "__I= FNAME__").addr_info[] | select(.scope =3D=3D "global").local] | .[0]' > iperf3 BW host __ADDR6__ 10002 __TIME__ __OPTS__ -b 8G -l 1472 > bw __BW__ 0.3 0.5 > iperf3 BW host __ADDR6__ 10002 __TIME__ __OPTS__ -b 12G -l 3972 --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --OJprZpUac0QUzgSL Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmdFGgwACgkQzQJF27ox 2Gfo5hAAit/H5E1UvaRCoaOhC5XpVSnzlEq2K4M3jvINb0TtxEcWBsMp117jfdij 8aY66/YaMZ7blrqpWYV9q70uttbncUJQsR50F9N1/Wpw7bR4Zu6jlOxbdkW8WNih Kqs8VJolhDT0g901XGQm75GlmyxldOahmR7DMpxEl7HRVlsJbDu6uELAeb7xd4t4 gSzVLr+1BCqQLOL1zIzX6mpEuoETX65MCtYJX7xbN7ogwtuEXzYBxYxdwOyO/5XA 10JGahpp5nRxbqyLFf2bXaLUf84F6LvRRt/vWXLxUiH3LN2i04shCbISX+5OyLGv aw5RTMAOmXzZZ8IGa0SUQwgJueHm74pOK0wecqPVN3Y4bUbPAIJSUvWP6jPAZbLi 8BbBIRegCrCxLP7SapeWnJWGcMcWTnfJjBWD/97TBvHVfE4Y1OAlXyliFZFLI5Ug SFIhYbmZMcAksDHXlNCV+DnjMrHMx48HIlEqCEB3wStNkvmjf7LOAQEcLo+7kSwM Azoe7jwqWxwL93Us8E7eRzGjRcOh0VD7Z2H4+W7C885q4dNM+HnD/Inm96qrFxYO 8ovxK63mrC+JVHt9ik2GpEy9NUxxn9oeK447Hb9+FlImnfwWuQOzVGPzbxCaU4DW vuPkAiHyozfmUUCma731NrZ/VJTNlFOlP98/mn255Xg8NyU+30M= =cXV7 -----END PGP SIGNATURE----- --OJprZpUac0QUzgSL--