From: David Gibson <david@gibson.dropbear.id.au>
To: Stefano Brivio <sbrivio@redhat.com>
Cc: Laurent Vivier <lvivier@redhat.com>, passt-dev@passt.top
Subject: Re: [PATCH] udp_vu: update segment size
Date: Thu, 5 Dec 2024 12:36:35 +1100 [thread overview]
Message-ID: <Z1EDo2o9OBRk1MI6@zatzit> (raw)
In-Reply-To: <20241204175806.052c9b4d@elisabeth>
[-- Attachment #1: Type: text/plain, Size: 670 bytes --]
On Wed, Dec 04, 2024 at 05:58:06PM +0100, Stefano Brivio wrote:
> On Wed, 4 Dec 2024 16:33:21 +0100
> Laurent Vivier <lvivier@redhat.com> wrote:
>
> > In udp_vu_sock_recv(), collect a segment with a size defined to
> > IP_MAX_MTU + ETH_HLEN + sizeof(struct virtio_net_hdr_mrg_rxbuf)
>
> Can you briefly explain why, and what's the problem otherwise?
The original version double counted the IP header: IP_MAX_MTU includes
the IP header, and so did hdrlen.
--
David Gibson (he or they) | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you, not the other way
| around.
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2024-12-05 2:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-04 15:33 [PATCH] udp_vu: update segment size Laurent Vivier
2024-12-04 16:58 ` Stefano Brivio
2024-12-05 1:36 ` David Gibson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z1EDo2o9OBRk1MI6@zatzit \
--to=david@gibson.dropbear.id.au \
--cc=lvivier@redhat.com \
--cc=passt-dev@passt.top \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).