From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202410 header.b=ckd073PB; dkim-atps=neutral Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id 8B8355A004C for ; Thu, 05 Dec 2024 03:46:08 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202410; t=1733366748; bh=MIr25u5cjm2Ao+2XzGL0z1EEgkfgwIO8nbV2UYE52lA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ckd073PBTHsMy8Ar/kYRImF9iJk0EefvVezKfOB+IgPEUBzRIFFfRcRkvEMNuTQR3 etV1JtkYLFrRvpcP4M5UENc8ydSr+YvojIkkMsstXOIn3FpYr1M0vOLkb5/HmepbcU AAzKcU1a/ITBnolCLk9cpVC+VhoEpUNdF8PjXdYM6Wa6KmhsvsFtalf7uyMaZs4KcY AOELgosNU+j8+gvigxMxoUEEaR0z/+Qd4NNVISsRXi6S1IioOnAED9JyWwnDPaF084 BDWaB2q34/yObxm1MaNOxxqDSM3yvNvi/n4Kw4+jEQtWhCfjE5nxuFzuAzYBD/SXpk 6FeX4wNt+YJTw== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4Y3dzw0jrQz4x4t; Thu, 5 Dec 2024 13:45:48 +1100 (AEDT) Date: Thu, 5 Dec 2024 12:36:35 +1100 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH] udp_vu: update segment size Message-ID: References: <20241204153321.87117-1-lvivier@redhat.com> <20241204175806.052c9b4d@elisabeth> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="QpLtyIdz4YbDseoN" Content-Disposition: inline In-Reply-To: <20241204175806.052c9b4d@elisabeth> Message-ID-Hash: JIYE4HVXYSIB4WRFRY6Y4Z2S2ECXOIYJ X-Message-ID-Hash: JIYE4HVXYSIB4WRFRY6Y4Z2S2ECXOIYJ X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Laurent Vivier , passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --QpLtyIdz4YbDseoN Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Dec 04, 2024 at 05:58:06PM +0100, Stefano Brivio wrote: > On Wed, 4 Dec 2024 16:33:21 +0100 > Laurent Vivier wrote: >=20 > > In udp_vu_sock_recv(), collect a segment with a size defined to > > IP_MAX_MTU + ETH_HLEN + sizeof(struct virtio_net_hdr_mrg_rxbuf) >=20 > Can you briefly explain why, and what's the problem otherwise? The original version double counted the IP header: IP_MAX_MTU includes the IP header, and so did hdrlen. --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --QpLtyIdz4YbDseoN Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmdRA6IACgkQzQJF27ox 2GdIMg//afCIRwf6iPjudwd8OE1g2PzHQXbYJBB6j8oX9iHiNu1WyyliLN4XKD66 kPcGXGtO3/8qZHrGIdhQpJiUjfNFpPINJAhhf6p/iuIdo5T606soP02scHLWDY5R 3rNkcla6O/vsPOqxb7Penwtq6COIsAbCoV6K2+GToHXlZoNu2sr7jb1Te1vMe3mG EVNUD6ZQpH0E5QBxwtxpgyffdVUUKSyO1xNX+ja1vz90i3dy+olvojSrXK7yVX77 8JU9Exla4fm7dqktYloqnXaNAxHViEaqC1Ept5ufwQagz7ncAP/hW9vR5kxSN8w8 EaT5xElLg+LrUhphHpi/9a18DudgD4LtWLtkGeyjgTID5jOCJeCXHFPsoDBA+Hpz ysvFsHQZNY2wbpUlhOGRY8VTxRp9fn/HSkeStwfOa+UEoIlIQyk5BG83E2gQdwRr dr83hd8tEoDXqRMhUSbliG7xf0MiZ7g5b68DEyyDqgXi14OdldBPb60YaBXJyVrH uaszAz5jrEx6wVbjnujBSePznR3G86IdWT9/GRVdvgsXWvwst5CS+gzMxbsfKJRn vhdp8oif0UGWdCt1KpJkF5W94l9yUyx1vbkR10FLoTIAnCSN5MsuWgR5HBDkrVSG iqfk51Pwjot1Ew7H5m6ZECTD9BqqfyVuHHW5O/CnqtpEK9hRlPs= =gdez -----END PGP SIGNATURE----- --QpLtyIdz4YbDseoN--