Re: [PATCH 2/4] tcp: Don't subscribe to EPOLLOUT events on STALLED

[David Gibson <david@gibson.dropbear.id.au>]

[-- Attachment #1: Type: text/plain, Size: 1136 bytes --]

On Thu, Jan 16, 2025 at 09:32:48PM +0100, Stefano Brivio wrote:
> I inadvertently added that in an unrelated change, but it doesn't make
> sense: STALLED means we have pending socket data that we can't write
> to the guest, not the other way around.
> 
> Fixes: bb708111833e ("treewide: Packet abstraction with mandatory boundary checks")
> Signed-off-by: Stefano Brivio <sbrivio@redhat.com>

Reviewed-by: David Gibson <david@gibson.dropbear.id.au>

> ---
>  tcp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tcp.c b/tcp.c
> index 72fca63..ef33388 100644
> --- a/tcp.c
> +++ b/tcp.c
> @@ -437,7 +437,7 @@ static uint32_t tcp_conn_epoll_events(uint8_t events, uint8_t conn_flags)
>  			return EPOLLET;
>  
>  		if (conn_flags & STALLED)
> -			return EPOLLIN | EPOLLOUT | EPOLLRDHUP | EPOLLET;
> +			return EPOLLIN | EPOLLRDHUP | EPOLLET;
>  
>  		return EPOLLIN | EPOLLRDHUP;
>  	}

-- 
David Gibson (he or they)	| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you, not the other way
				| around.
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]