From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202412 header.b=W8nhCSZS; dkim-atps=neutral Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id 362AC5A0274 for ; Fri, 24 Jan 2025 04:38:26 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202412; t=1737689892; bh=TB2dAvUqKtsyi/M9ZhlWluJ7SgrH5MYGBaDOjuBFD7A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=W8nhCSZSuKM3hiWJwgn5GeSdsgfn3oDyP2a8vVISrdvvdqWQ5L3NnLU3O0+qi1+IN /CcuzBOI30qZm1weHwT154amvvCgq7h9W2EYlQjfU9ukN38mfp5NY1H3SGMExF1bJB 7KkqM8W5Z+QvI8qaP8hIEtCVP46TAN2ZbYQg1U2NDJVJROPGvY6i4Il5uxWmK3QZ7x wpuZnOB09ciSdzgFGSI2pU6dEb6S9KB3S74DCJlfy8GNBpXRcToV3aSCakaOhhpw+u pkcSY/z2GpJf6sY5L9SC1hKMaU8p9Xo1nhX+PZNPjMk4jRPqjQZMubLfYMaDC0hEAS dzb2AjBhiU58w== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4YfNnJ3gZ0z4wgp; Fri, 24 Jan 2025 14:38:12 +1100 (AEDT) Date: Fri, 24 Jan 2025 13:58:00 +1100 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH 2/4] tcp: Don't subscribe to EPOLLOUT events on STALLED Message-ID: References: <20250116203250.784496-1-sbrivio@redhat.com> <20250116203250.784496-3-sbrivio@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="fjYXOhZxsWOqUL8B" Content-Disposition: inline In-Reply-To: <20250116203250.784496-3-sbrivio@redhat.com> Message-ID-Hash: UTBVHUYFL4YMMO4BSFKRUDKC4TAG3SXW X-Message-ID-Hash: UTBVHUYFL4YMMO4BSFKRUDKC4TAG3SXW X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, Asahi Lina , Sergio Lopez , Jon Maloy X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --fjYXOhZxsWOqUL8B Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jan 16, 2025 at 09:32:48PM +0100, Stefano Brivio wrote: > I inadvertently added that in an unrelated change, but it doesn't make > sense: STALLED means we have pending socket data that we can't write > to the guest, not the other way around. >=20 > Fixes: bb708111833e ("treewide: Packet abstraction with mandatory boundar= y checks") > Signed-off-by: Stefano Brivio Reviewed-by: David Gibson > --- > tcp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/tcp.c b/tcp.c > index 72fca63..ef33388 100644 > --- a/tcp.c > +++ b/tcp.c > @@ -437,7 +437,7 @@ static uint32_t tcp_conn_epoll_events(uint8_t events,= uint8_t conn_flags) > return EPOLLET; > =20 > if (conn_flags & STALLED) > - return EPOLLIN | EPOLLOUT | EPOLLRDHUP | EPOLLET; > + return EPOLLIN | EPOLLRDHUP | EPOLLET; > =20 > return EPOLLIN | EPOLLRDHUP; > } --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --fjYXOhZxsWOqUL8B Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmeTAbcACgkQzQJF27ox 2GfqeA//dHJbTWbh3rZezbUq0VNGAbaF5SpnAIljugVsmF1mh8plmsJ/rvcmGx04 /o4cVfLeDMZwhDbBiOwUh5sFUOxim4WieIxloS9U5m7uGEMsXKR2ptgLV9NGluXI gjH1+nINrVz34dbb7utMm6RJUAwvBgB1C3/c7Jkh+L4TOJ/k6+6JbbZDRlJQ3Qqh KIWwDoI4UXR/LwznynY47tT7LO3Zd+Qr9LmMxQQkL+a9Px+F9nVQzxymud/56iJD /QWSWYtSDunoBvv7m9neYkWb7GW+J9nu7wt47XpouneddJmkNx9YpxdzZZmJV3Xq 4XROYKOspfJtz2uhpdBsxf6gGhXzhkQuzvgmgXYp27RsUPobBqCLCxz0Wlk8DZrQ zka6CSoNiWJbK98tlgD1mZMLu4xwMrabY5bXwlWee/4fN2QYwEgHF1Q5sOzf5kCH gmvVG+Xx4mafwOqgLiobg/s4O6kAnN14WGPUWZuIvP2jd6UBgDp6gzJQa+a8eO4a 6SYF2mX5iIkPCM8y2nC9Y0OJnE2W7ApPc8/SLRowL6fw8a2Q9jCxy5aE5QEqInu5 foS0MNY+l6DNBJRjzLMZd34jkymL/jqTnvRd1HNjRIlTJaoHecjjnMY6tJ6RsJ2C YPVju3UL7iUqAKOJ1VyMKwjvVj/hfEsxt7QZtUbfSLdV6htLWDg= =MUyi -----END PGP SIGNATURE----- --fjYXOhZxsWOqUL8B--