Re: [PATCH 3/7] tcp_conn: Avoid 7-bit hole in struct tcp_splice_conn

[David Gibson <david@gibson.dropbear.id.au>]

[-- Attachment #1: Type: text/plain, Size: 1236 bytes --]

On Tue, Jan 28, 2025 at 12:15:28AM +0100, Stefano Brivio wrote:
> Moving in_epoll out of the common flow data created a 7-bit hole in
> struct tcp_splice_conn: repack by shrinking @flags by one (otherwise
> unused) bit.

Is this actually necessary for the migration stuff?  Or just a cleanup
you spotted along the way?

> 
> Fixes: b60fa33eeafb ("tcp: Move in_epoll flag out of common connection structure")
> Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
> ---
>  tcp_conn.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tcp_conn.h b/tcp_conn.h
> index d342680..3d06e2c 100644
> --- a/tcp_conn.h
> +++ b/tcp_conn.h
> @@ -125,7 +125,7 @@ struct tcp_splice_conn {
>  #define FIN_RCVD(sidei_)		((sidei_) ? BIT(5) : BIT(4))
>  #define FIN_SENT(sidei_)		((sidei_) ? BIT(7) : BIT(6))
>  
> -	uint8_t flags;
> +	uint8_t flags	:7;
>  #define RCVLOWAT_SET(sidei_)		((sidei_) ? BIT(1) : BIT(0))
>  #define RCVLOWAT_ACT(sidei_)		((sidei_) ? BIT(3) : BIT(2))
>  #define CLOSING				BIT(4)

-- 
David Gibson (he or they)	| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you, not the other way
				| around.
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]