From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202412 header.b=OKeHnqxO; dkim-atps=neutral Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id 30D165A061E for ; Tue, 28 Jan 2025 02:52:09 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202412; t=1738029115; bh=DOEbxpGwmoiFeyuUXhMkPWHs61F2Igckz6rkbaa5rZg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OKeHnqxO7620pDqLWixI9I0weeFlDiMXJZrovZ1RKVJjzYq1C/wN0eiyqimucHqpC xGsrJknSrzSxWz6w/3ajQRT/wqO4TPpCWHLVO6Q17bkNZ8jv9VDcJC7zi8K+zl/mx+ p0WNj588/i/fGNgAW9iDk2O6qSPky1EVQevkQJRRLhiNpX7+Pey+yo+tI8gaRjQWHO SAz9Z66uVyiZM00Sw08qalpjjrWmwpYEfiEthr/RFpaeAHKIbOBJ4DkEGUM2trtBry r7Rb0nuIFl+YwBPx+ubDjz3JYMiU58d4nyIlElDFDfI9dpD2p9k/UF/4sVPYOKoSsf GZtHBHb0ns0LQ== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4YhpDq6wD5z4wyr; Tue, 28 Jan 2025 12:51:55 +1100 (AEDT) Date: Tue, 28 Jan 2025 11:53:09 +1100 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH 3/7] tcp_conn: Avoid 7-bit hole in struct tcp_splice_conn Message-ID: References: <20250127231532.672363-1-sbrivio@redhat.com> <20250127231532.672363-4-sbrivio@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="V+zsMn1VRChOIt6/" Content-Disposition: inline In-Reply-To: <20250127231532.672363-4-sbrivio@redhat.com> Message-ID-Hash: 6IUIUIXVNBSIQG7PNJOAPHEPI55RMKLR X-Message-ID-Hash: 6IUIUIXVNBSIQG7PNJOAPHEPI55RMKLR X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, Laurent Vivier X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --V+zsMn1VRChOIt6/ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jan 28, 2025 at 12:15:28AM +0100, Stefano Brivio wrote: > Moving in_epoll out of the common flow data created a 7-bit hole in > struct tcp_splice_conn: repack by shrinking @flags by one (otherwise > unused) bit. Is this actually necessary for the migration stuff? Or just a cleanup you spotted along the way? >=20 > Fixes: b60fa33eeafb ("tcp: Move in_epoll flag out of common connection st= ructure") > Signed-off-by: Stefano Brivio > --- > tcp_conn.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/tcp_conn.h b/tcp_conn.h > index d342680..3d06e2c 100644 > --- a/tcp_conn.h > +++ b/tcp_conn.h > @@ -125,7 +125,7 @@ struct tcp_splice_conn { > #define FIN_RCVD(sidei_) ((sidei_) ? BIT(5) : BIT(4)) > #define FIN_SENT(sidei_) ((sidei_) ? BIT(7) : BIT(6)) > =20 > - uint8_t flags; > + uint8_t flags :7; > #define RCVLOWAT_SET(sidei_) ((sidei_) ? BIT(1) : BIT(0)) > #define RCVLOWAT_ACT(sidei_) ((sidei_) ? BIT(3) : BIT(2)) > #define CLOSING BIT(4) --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --V+zsMn1VRChOIt6/ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmeYKnUACgkQzQJF27ox 2GcTow//WxhzKB3mashoifxa/wXVDKLYS1x64GzLiMmjTD1teveqPInGJlSu740o hLrt70tt+IqkJNVuerfCnRvUUw63DzA2KtCv9C89Yh5bN3y6LGgCJw6ZtflCVD2u nRFi9M34yPwi+vZ5nSw09CncMzjuR4Km4B9/R4HtYrTjfkeTSFv+X8mUknMwinjI CKjlNirlA+7D5biYdHsoF82boQvKqPtIVecME/GLreCItL5L5xaO6ayr2WetCMSl nK2mwr4NxmVFpk+TVNDwJarIf1I233+LIDJpIQHWCCr1CXQw7bJ+Aw8ZVacLUNTo b7LhGm3AyeOuv29d3VDZLYLkjQZVIs4ewDuWtaHACjn72COF7q3S96FkDehfaUpw fjYEbw2bM+PDmJtPO9Amkkbhc52vLGubx2jIUFBBbynYpPNdvtjtIEj9o9bvELBY EJCK4hRfDRPbdQxA2yyyV0eJMUU0Lfx3VIVt7YFz6cMQS8tq0SrO0Ast2TCIkoha NED/4Ck1K4yZ8+MxPD1NjsZty0F9Z9xkErgcnxDaY+Pewde6BDPQZi83LtGxdQsy T1ZXEM/8lSBLBS6WO/RimjMg+ma+lyPX2k5jp+fITP4X5NpHopqquzh33tawVznF h2EOb2r6zBHieCEzxlPPZti3gLlv2rjoTJ7UHcxWQpeJ343Yai8= =ZC71 -----END PGP SIGNATURE----- --V+zsMn1VRChOIt6/--