From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202412 header.b=NeUL2J4P; dkim-atps=neutral Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id 579925A026F for ; Wed, 29 Jan 2025 02:29:40 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202412; t=1738114167; bh=y4vxMfOKJ8Sy7kiWpigSnBxCYojpbtx8baVpdywKbhA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NeUL2J4Pg3LI3HfPswvByp49wmVWnWYhECRtBc3Dy9j7LQ4KlKlwcqS6kfu3gVyEe qcOLUt6N/tAVKoC73x34FWKbcukkZUSV0gZLfp2jhYI8gZ4QmRyfeQABtLo4EHoWoi UlYvh9SnOPa/bvNQnC7W7rwc6/xc3ZJ7iM8Et/WTrgwskzpuyZYdLuI7qU9ezVzgo6 V4eh7EcUDjU+PD2ryFIrAxMpmHCWEijc06n/dUjLlm7dX9PGtpkDhicHZ4/fQR36kp w/OCkMT3/mBDrpgk5Fck4Ss9SNHpkh2Ww125ApWUabS01aypYVRd36wjGCpGUBlWt0 ANTyvonupMXgw== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4YjPhR132qz4x0t; Wed, 29 Jan 2025 12:29:27 +1100 (AEDT) Date: Wed, 29 Jan 2025 12:02:09 +1100 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH 3/7] tcp_conn: Avoid 7-bit hole in struct tcp_splice_conn Message-ID: References: <20250127231532.672363-1-sbrivio@redhat.com> <20250127231532.672363-4-sbrivio@redhat.com> <20250128074833.716e4a66@elisabeth> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="zOUuilsqZuLIFIuc" Content-Disposition: inline In-Reply-To: <20250128074833.716e4a66@elisabeth> Message-ID-Hash: SYWM2Y25JC3VFY77OYBKSGW6W4KCZA4A X-Message-ID-Hash: SYWM2Y25JC3VFY77OYBKSGW6W4KCZA4A X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, Laurent Vivier X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --zOUuilsqZuLIFIuc Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jan 28, 2025 at 07:48:33AM +0100, Stefano Brivio wrote: > On Tue, 28 Jan 2025 11:53:09 +1100 > David Gibson wrote: >=20 > > On Tue, Jan 28, 2025 at 12:15:28AM +0100, Stefano Brivio wrote: > > > Moving in_epoll out of the common flow data created a 7-bit hole in > > > struct tcp_splice_conn: repack by shrinking @flags by one (otherwise > > > unused) bit. =20 > >=20 > > Is this actually necessary for the migration stuff? Or just a cleanup > > you spotted along the way? >=20 > I thought it was helpful to keep the same size on 32-bit, but it looks > like it's not actually needed. >=20 > Let me drop it from this series as it's just noise and I'm trying to > keep this slim. If we are all happy with it I can apply it. If not I'll > forget about it. Eh, I don't care that much either way. Note, btw, that bit-field packing is another way source and destination could potentially have mismatching data structures. IIUC bit field packing is described by the ABI and doesn't necessarily match the byte endianness. --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --zOUuilsqZuLIFIuc Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmeZfgMACgkQzQJF27ox 2GcKMA//aUiwAklHIWzsZ9atL4Szs1de+yCUv3EzeQno7HajGspJYmLXtGiICB42 NufdBwdq3ma4ZlK4B8Xr74eiw7zlGAraQWLxDqb3lTu+rxAGzXlZRGravrfJU8Zm 2XNo5BN+WY9h9+3HT7Scr8cy8kJUmrMeDOCeRiUSsbipXexhVcH7zmmofgICMPe9 sGdj16RZp8WgEoE+4WfRndxgjTJCoFygEnr7Taox9nHpyGobxOQE13/nOpCUizkV bp/d49Yq+2gAh3LxAG6/IorIvbn06EvWahA4o6KN1YhMFh5Mc7LRWzQCaOwLWFCJ Ee48I2XgNdeyAM2kjVp7+cIuaposao1nMkMQjsLwtgFgnUA1H8OfgbrjVzx52txG o0Q5mqy9K1gPMV+4exMow6dBsEpSDZGDVxkkrMurHCzvgfgVwepldVGT0VdRHuNl 1dcf4tqSRxGeJg/9R9FheKp0QTg2vjGmOiC6rCovR5dq8/t5mxSzWODVF1pTjg3L uWGO2T4+o4QbiB5KJ8UmMHRsrGS4/DmDCLjgnOe5M8ED4UMZAhwc2Cfvac77Hg11 qDRbg6Z23/jZNgMQ5plkHNPxPu9qi695j4lpFFN1FEQd8rw5yV/gqwuJZIjhaiPk 0K1X8PCqHoR9ymZ/HvQMAIxqP+sp08ZqFrQlL9AgJeGw/iYpHfY= =/+g+ -----END PGP SIGNATURE----- --zOUuilsqZuLIFIuc--