Re: [PATCH 1/2] migrate: Merge protocol version information into one table

[David Gibson <david@gibson.dropbear.id.au>]

[-- Attachment #1: Type: text/plain, Size: 1218 bytes --]

On Fri, Jan 31, 2025 at 06:53:44AM +0100, Stefano Brivio wrote:
> On Fri, 31 Jan 2025 15:52:14 +1100
> David Gibson <david@gibson.dropbear.id.au> wrote:
> 
> > +/**
> > + * struct migrate_meta - Migration metadata
> > + * @version:		Version number, host order
> > + * @v:			Version information
> > + * @bswap:		Source has opposite endianness
> > + * @peer_64b:		Source uses 64-bit void *
> > + * @time_64b:		Source uses 64-bit time_t
> > + * @flow_size:		Size of union flow in source
> > + * @flow_sidx_size:	Size of struct flow_sidx in source
> > + */
> > +struct migrate_meta {
> > +	uint32_t version;
> > +	const struct migrate_version *v;
> > +	bool bswap;
> > +	bool source_64b;
> > +	bool time_64b;
> > +	size_t flow_size;
> > +	size_t flow_sidx_size;
> > +};
> 
> What's the purpose of this, if this information should go away quite
> soon (even before merge, perhaps)?

Soon, but not yet.  I don't want to break the stuff you're working on
until I have something else to replace it.

-- 
David Gibson (he or they)	| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you, not the other way
				| around.
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]