From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au
Authentication-Results: passt.top;
	dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202412 header.b=kLX9Bo1S;
	dkim-atps=neutral
Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3])
	by passt.top (Postfix) with ESMTPS id 78B585A0629
	for <passt-dev@passt.top>; Fri, 31 Jan 2025 07:32:33 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=gibson.dropbear.id.au; s=202412; t=1738305128;
	bh=LJKqcEm/4qNyq94KGs8/Nq80kv4Lfkij1X5I0Nn1eSU=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=kLX9Bo1St9e23XQQQ07Ye+AC0iyrvKBArewiHs/E64eGm1nPJMOQzJvHQFfDdVlwX
	 WJdkDGp359a0jxmwYodWxIJ2HCZNfe4OW0/FBCGPo9GiOY3XUqqHMbestsI1XeTVS2
	 hE4F7V1e0FlsjiRT1/F7eamltXfcKejIdnRovmhY5LRORBwEtvFPKhlhHTx7M0XRC5
	 DeZvm/g5HbY+S8P/79fyezxZfxuULdt+B21b72+Z0hBOYH8BhsICFT1f3dgNapdtaf
	 6VmE/ktcLO6N2IZL521Kj8N0tFPV660pleyRIEzCOmQJ72cfrhNS0NL1IYaEnzAX+r
	 Mq7ih1CW3hvKQ==
Received: by gandalf.ozlabs.org (Postfix, from userid 1007)
	id 4YkmJm0W9kz4wdF; Fri, 31 Jan 2025 17:32:08 +1100 (AEDT)
Date: Fri, 31 Jan 2025 17:17:02 +1100
From: David Gibson <david@gibson.dropbear.id.au>
To: Stefano Brivio <sbrivio@redhat.com>
Subject: Re: [PATCH 1/2] migrate: Merge protocol version information into one
 table
Message-ID: <Z5xq3nIsEDPHITkH@zatzit>
References: <20250131045215.1368543-1-david@gibson.dropbear.id.au>
 <20250131045215.1368543-2-david@gibson.dropbear.id.au>
 <20250131065344.1f440c01@elisabeth>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="wluM39zxLULhHPiT"
Content-Disposition: inline
In-Reply-To: <20250131065344.1f440c01@elisabeth>
Message-ID-Hash: BQIT6GKZ6Y4BE2H2G43CY7O6QIUG6OYF
X-Message-ID-Hash: BQIT6GKZ6Y4BE2H2G43CY7O6QIUG6OYF
X-MailFrom: dgibson@gandalf.ozlabs.org
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header
CC: passt-dev@passt.top
X-Mailman-Version: 3.3.8
Precedence: list
List-Id: Development discussion and patches for passt <passt-dev.passt.top>
Archived-At: <https://archives.passt.top/passt-dev/Z5xq3nIsEDPHITkH@zatzit/>
Archived-At: <https://passt.top/hyperkitty/list/passt-dev@passt.top/message/BQIT6GKZ6Y4BE2H2G43CY7O6QIUG6OYF/>
List-Archive: <https://archives.passt.top/passt-dev/>
List-Archive: <https://passt.top/hyperkitty/list/passt-dev@passt.top/>
List-Help: <mailto:passt-dev-request@passt.top?subject=help>
List-Owner: <mailto:passt-dev-owner@passt.top>
List-Post: <mailto:passt-dev@passt.top>
List-Subscribe: <mailto:passt-dev-join@passt.top>
List-Unsubscribe: <mailto:passt-dev-leave@passt.top>


--wluM39zxLULhHPiT
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Jan 31, 2025 at 06:53:44AM +0100, Stefano Brivio wrote:
> On Fri, 31 Jan 2025 15:52:14 +1100
> David Gibson <david@gibson.dropbear.id.au> wrote:
>=20
> > +/**
> > + * struct migrate_meta - Migration metadata
> > + * @version:		Version number, host order
> > + * @v:			Version information
> > + * @bswap:		Source has opposite endianness
> > + * @peer_64b:		Source uses 64-bit void *
> > + * @time_64b:		Source uses 64-bit time_t
> > + * @flow_size:		Size of union flow in source
> > + * @flow_sidx_size:	Size of struct flow_sidx in source
> > + */
> > +struct migrate_meta {
> > +	uint32_t version;
> > +	const struct migrate_version *v;
> > +	bool bswap;
> > +	bool source_64b;
> > +	bool time_64b;
> > +	size_t flow_size;
> > +	size_t flow_sidx_size;
> > +};
>=20
> What's the purpose of this, if this information should go away quite
> soon (even before merge, perhaps)?

Soon, but not yet.  I don't want to break the stuff you're working on
until I have something else to replace it.

--=20
David Gibson (he or they)	| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you, not the other way
				| around.
http://www.ozlabs.org/~dgibson

--wluM39zxLULhHPiT
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmecat4ACgkQzQJF27ox
2Gc6Uw//eaJn/Vz/rCaepJALXf6+mxyOclNrT9FIxbaE/uxBgMgvIl64DtwXWUDP
0zKsbXGqhvn9kXpXY/3AdNlj4Gmi1k46CPDXudgU1Z02oIaADiUBRrOpnw1SNPlI
t005ZWjqYm4E/SctKSg55bMLvXB2zZg3X1T754sikrYOcKPeU5vNumvqOlQVh9C1
BSAfwmpSDl1ZMqxqzKbjs1W7BeKcBTQE1Et8Xa/Xz0B87MhWSKf+FWdmacMBynXE
La4ps1kPgjP4DOT9KXFTFRC9z4+5arGCOUcxPRj8XkKOidTwnwm+Acc1TU+gcFeU
4EpEPPvYn7O7dkDWfHLlzV1thseUQGh0UxNwCtmkly1iO+sjci99CgmZju/oc0ng
eO0K7Agmb0rNz7fw1uyysuenL7aRBqpYsnhm9/runIeYj7JBczoVo9gMS7ieaxaS
LEW8GL8uTVgQNlQKe8rj0ri8c4PwyXJY+HM34apBa4xVsGahNKv6t9zHG+0WzeX5
Et2c6hbsfrFagY6lHeVNoJOR87nFNgw6nm9Ql7lYrIRNBDMzBwiXkY9YcorkUKRV
oSjRP0LtZr/z2BdgtpDlYND9z+eO0c2vLy0gRKd56mHdIyKQf5xu8vcbjnIxjRyo
zWK5GIgUuk0cTBKYKgAEup0kKAQpmDNbkwXl/csxMdbk3ecAURo=
=gMF7
-----END PGP SIGNATURE-----

--wluM39zxLULhHPiT--