From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202502 header.b=ksYWsfRY; dkim-atps=neutral Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id B47EB5A061D for ; Mon, 03 Feb 2025 03:17:02 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202502; t=1738549000; bh=kXnLuOLLnTRKt02FgVaNxgRlLuCc6AevMW7LcQfke1w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ksYWsfRY5jiKZQyIFIXOMMpdQe9AuZ+royX1CRc9/aC082yB2HnON9+3VlXbwl2ck qAfnRnP58sr4fvGn/n3TWXP2HpDZcVzMyM9Nff2WTQdX+VaaxPriRCcz4mDo57E/d1 DbAu68hj7Cketrb0CBvLHaNvTcMjLJDlwefyJHHjt8VWRZZ34/Recl7oGNCi3MWQ42 HiewvABRr7TuSaZFWDAIGAxZ5bVT+7XGOd76gHs+sLBW7f4APqzOWhFLfzRSJWLe/h WKiBXzFF68wZpiVKF/3CaF0EcCl2RVL/pIvXXNRZ40w2473pdrtGGeQOWRvj0/7fJv /eHl7GJ1nMZlw== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4YmVVc4ZVvz4wyh; Mon, 3 Feb 2025 13:16:40 +1100 (AEDT) Date: Mon, 3 Feb 2025 13:06:04 +1100 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH v3 19/20] tcp: Add HOSTSIDE(x), HOSTFLOW(x) macros Message-ID: References: <20250131193953.3034031-1-sbrivio@redhat.com> <20250131193953.3034031-20-sbrivio@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="VqQz+rh9Oz0CK9+J" Content-Disposition: inline In-Reply-To: <20250131193953.3034031-20-sbrivio@redhat.com> Message-ID-Hash: A73PMROZ5NKVZ5YSBFI5NZFJOXVVG3G6 X-Message-ID-Hash: A73PMROZ5NKVZ5YSBFI5NZFJOXVVG3G6 X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, Laurent Vivier X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --VqQz+rh9Oz0CK9+J Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jan 31, 2025 at 08:39:52PM +0100, Stefano Brivio wrote: > Those are symmetric to TAPSIDE(x)/TAPFLOW(x) and I'll use them in > the next patch to extract 'oport' in order to re-bind sockets to > the original socket-side local port. >=20 > Signed-off-by: Stefano Brivio Reviewed-by: David Gibson > --- > tcp_internal.h | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) >=20 > diff --git a/tcp_internal.h b/tcp_internal.h > index 94e5780..9cf31f5 100644 > --- a/tcp_internal.h > +++ b/tcp_internal.h > @@ -38,9 +38,13 @@ > #define OPT_SACK 5 > #define OPT_TS 8 > =20 > -#define TAPSIDE(conn_) ((conn_)->f.pif[1] =3D=3D PIF_TAP) > -#define TAPFLOW(conn_) (&((conn_)->f.side[TAPSIDE(conn_)])) > -#define TAP_SIDX(conn_) (FLOW_SIDX((conn_), TAPSIDE(conn_))) > +#define TAPSIDE(conn_) ((conn_)->f.pif[1] =3D=3D PIF_TAP) > +#define TAPFLOW(conn_) (&((conn_)->f.side[TAPSIDE(conn_)])) > +#define TAP_SIDX(conn_) (FLOW_SIDX((conn_), TAPSIDE(conn_))) > + > +#define HOSTSIDE(conn_) ((conn_)->f.pif[1] =3D=3D PIF_HOST) > +#define HOSTFLOW(conn_) (&((conn_)->f.side[HOSTSIDE(conn_)])) > +#define HOST_SIDX(conn_) (FLOW_SIDX((conn_), TAPSIDE(conn_))) > =20 > #define CONN_V4(conn) (!!inany_v4(&TAPFLOW(conn)->oaddr)) > #define CONN_V6(conn) (!CONN_V4(conn)) --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --VqQz+rh9Oz0CK9+J Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmegJIsACgkQzQJF27ox 2GeU9w/9EkXEJGcGilppT1xW9ivqzS2/qw//1PSEYLuRR+OooV+mb/NWgE1r3LPQ WS55hWRE00eMF/LtvHfDC91PZpHXBcz/aq5gsggfOG9nxVmwk0FOojxfOGZ2e3ID SSLoVeYnUkioELuDBaO/r1hhwGMHINLo7r0Y8s8pFdRSJ5fMmZHdLZDufbtbY7WJ L7r4vc9njVoeN6qBdmoRe4JpiolKJcYBpidVsLCd7uuRnj1thbyXs25vwFe5rtif XaWXYALExcTyRW7k2eYJtQioW0p1+0D4acqkV+p5dOXTcCcP6Imma0r54qNeJfBS ftU/yanGF8hvRp7waPpbnRxOJJwjhvYdv39/jNcGcLeNnVlMYscOIpH1kk0nPjpp gHhi4xARuZFTDREe6tdv+YL30BE0mAgBYBMFFO0UwruOUbZWYy82m/9i/Q4ecngq 3ryWEPsfeszDe53QmSvHp7vbzk5LiLOq7qdNZXQq2KucOszjdpzOgnaIB1+YQfC6 0j7/plSF83/6ByheuoUYI2hEmZBl9N9uS7wJBLYUZwKtqzZkyfbE7M8GtLLA/X2+ QBiEpEuywqSbX+MY3fqJN9+o+Y8/cN60n+A1lhNaxF9EhRzi7e0/EtzNDs3mjyuD zJhgu0M+dkuD5Pnj0d+oYbP3XJIvw1vExoWa1ymYrQu1+3/674w= =sGjO -----END PGP SIGNATURE----- --VqQz+rh9Oz0CK9+J--