Re: [PATCH v3 16/20] vhost_user: Turn vhost-user message reports to trace()

[David Gibson <david@gibson.dropbear.id.au>]

[-- Attachment #1: Type: text/plain, Size: 2002 bytes --]

On Fri, Jan 31, 2025 at 08:39:49PM +0100, Stefano Brivio wrote:
> Having every vhost-user message printed as part of debug output makes
> debugging anything else a bit complicated.
> 
> Signed-off-by: Stefano Brivio <sbrivio@redhat.com>

I'm a little bit baffled by this.  You're changing to trace() a couple
of relatively rare messages, that I think belong in debug() category,
but *not* changing some things that definitely should be trace() -
such as the ones in vu_send_single() and vu_kick_cb().

> ---
>  vhost_user.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/vhost_user.c b/vhost_user.c
> index 2dde405..1092387 100644
> --- a/vhost_user.c
> +++ b/vhost_user.c
> @@ -640,8 +640,8 @@ static bool vu_set_vring_num_exec(struct vu_dev *vdev,
>  	unsigned int idx = msg->payload.state.index;
>  	unsigned int num = msg->payload.state.num;
>  
> -	debug("State.index: %u", idx);
> -	debug("State.num:   %u", num);
> +	trace("State.index: %u", idx);
> +	trace("State.num:   %u", num);
>  	vdev->vq[idx].vring.num = num;
>  
>  	return false;
> @@ -1176,11 +1176,11 @@ void vu_control_handler(struct vu_dev *vdev, int fd, uint32_t events)
>  		vu_sock_reset(vdev);
>  		return;
>  	}
> -	debug("================ Vhost user message ================");
> -	debug("Request: %s (%d)", vu_request_to_string(msg.hdr.request),
> +	trace("================ Vhost user message ================");
> +	trace("Request: %s (%d)", vu_request_to_string(msg.hdr.request),
>  		msg.hdr.request);
> -	debug("Flags:   0x%x", msg.hdr.flags);
> -	debug("Size:    %u", msg.hdr.size);
> +	trace("Flags:   0x%x", msg.hdr.flags);
> +	trace("Size:    %u", msg.hdr.size);
>  
>  	need_reply = msg.hdr.flags & VHOST_USER_NEED_REPLY_MASK;
>  

-- 
David Gibson (he or they)	| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you, not the other way
				| around.
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]