From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202502 header.b=NFre//Qy; dkim-atps=neutral Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id 3C5D45A026F for ; Mon, 03 Feb 2025 06:05:01 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202502; t=1738559074; bh=oJIG7CF2S8OFipDO8Wp/ouNmTng/UDZL2h+TLSjJKOA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NFre//QynRdof0VOsrN6T8R9LI8eRp/YDyQsjFLt0fjLyIDKKBVxU2WJYkHXKLYPw Gu3Vf6NMgN/WF7OpQnNjwCZhGlUZk/rq7fsenA8TBSx68P0SxViQgdYRZLv7zQnyok zR60yEY1btGYsPOFeUVTY7CJUfVUUG9qaxWSWRvxHzt7YsFNkmyjgoluXUyl3vOgnD cAPsP3IWTfJ7lEY/rruxKd/7i+NBCTQZ7DdgcqGdMMZEZi8l/a1jlbpMzsw79MBFxe AmIi4bH+sKbqDq6uS4bBwb7iJvY4muzBmAN6HtgFf1fM1rB20aBus3NeWA/NunvQk5 PXmW+cv+V2DoQ== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4YmZDL5NtQz4wnp; Mon, 3 Feb 2025 16:04:34 +1100 (AEDT) Date: Mon, 3 Feb 2025 14:11:10 +1100 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH v3 16/20] vhost_user: Turn vhost-user message reports to trace() Message-ID: References: <20250131193953.3034031-1-sbrivio@redhat.com> <20250131193953.3034031-17-sbrivio@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="cyDw0knZVZfO1sKA" Content-Disposition: inline In-Reply-To: <20250131193953.3034031-17-sbrivio@redhat.com> Message-ID-Hash: NNIPJL4FGT72HRFMDEMASDXAZFBLDO2H X-Message-ID-Hash: NNIPJL4FGT72HRFMDEMASDXAZFBLDO2H X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, Laurent Vivier X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --cyDw0knZVZfO1sKA Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jan 31, 2025 at 08:39:49PM +0100, Stefano Brivio wrote: > Having every vhost-user message printed as part of debug output makes > debugging anything else a bit complicated. >=20 > Signed-off-by: Stefano Brivio I'm a little bit baffled by this. You're changing to trace() a couple of relatively rare messages, that I think belong in debug() category, but *not* changing some things that definitely should be trace() - such as the ones in vu_send_single() and vu_kick_cb(). > --- > vhost_user.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) >=20 > diff --git a/vhost_user.c b/vhost_user.c > index 2dde405..1092387 100644 > --- a/vhost_user.c > +++ b/vhost_user.c > @@ -640,8 +640,8 @@ static bool vu_set_vring_num_exec(struct vu_dev *vdev, > unsigned int idx =3D msg->payload.state.index; > unsigned int num =3D msg->payload.state.num; > =20 > - debug("State.index: %u", idx); > - debug("State.num: %u", num); > + trace("State.index: %u", idx); > + trace("State.num: %u", num); > vdev->vq[idx].vring.num =3D num; > =20 > return false; > @@ -1176,11 +1176,11 @@ void vu_control_handler(struct vu_dev *vdev, int = fd, uint32_t events) > vu_sock_reset(vdev); > return; > } > - debug("=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D Vhost user mess= age =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D"); > - debug("Request: %s (%d)", vu_request_to_string(msg.hdr.request), > + trace("=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D Vhost user mess= age =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D"); > + trace("Request: %s (%d)", vu_request_to_string(msg.hdr.request), > msg.hdr.request); > - debug("Flags: 0x%x", msg.hdr.flags); > - debug("Size: %u", msg.hdr.size); > + trace("Flags: 0x%x", msg.hdr.flags); > + trace("Size: %u", msg.hdr.size); > =20 > need_reply =3D msg.hdr.flags & VHOST_USER_NEED_REPLY_MASK; > =20 --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --cyDw0knZVZfO1sKA Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmegM80ACgkQzQJF27ox 2GcwSg//aP8Pz8YWGrgbHL00hNar+vFWl/LfHxj18kGAzQNsqMh8A8kpGyqz8LkV jJ0O6jytxQU0thbYyv3GyiZxhJ/M+FnXjz4+1ly26LrbyzRCpY8fgzUNdaCFpAkQ vv9d8EbPpCnBHELLCUnnFuCECj0CuwZmATJJeItjMKKHByXx52dY1oNBJFZlycF6 0z1q2f6m6lNi0widM2BoWZcVMudRGu6JnbcW3CLHREIe77mnSSUEvfYPFOPvrRy9 XYOXYltj/OJiACdjEDBaQAYT0TTdMEfqsiLoFlWaJm19NhhJZxZ4MKJBgW8dYdbB 4Vdi/aIZbtIqVePM3G+AYYEAhyzs0eveIFxvOj36QkmZ23MAgNYOHjoo6RmOgqMb o8F87+0joKeQoNrUtNgMTWhOWU77s/37eSTIKzkvvrjV8uyC7EmHwUjX0D9ER55e eJw/swkRv72pxjscPHtMNolpaS4V3D1+HFdGTRzhObypk6So12FuVaueaPp1Bjsc E385oD/Glhnyb4cZB/J/sqD4X80N5JeNpC0BMz4CPkc7dEdkZYHMCkpxvhcBZNVT ecEWbKKTPgVMPsclOypLaK5fDZo3AhagUaEuhUl/IZhFH5OJpYc1L4KhpMbjRMjO wtcgSKK2GHrdIhLjqH7ImLxRRTYiKBJmwT0P2UjuFSdanXfKZc0= =8Nwe -----END PGP SIGNATURE----- --cyDw0knZVZfO1sKA--