From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202502 header.b=ij8FgIpB; dkim-atps=neutral Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id F28005A026F for ; Mon, 03 Feb 2025 06:22:50 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202502; t=1738560145; bh=OJtWMAd5FFKJrtOqEz+W5ugrBDbzeKqg8rFTvhOqXt0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ij8FgIpBHDW7mPvq9CUD5eW6u8z7ma1r/RrPaQtRutc62eqLpsu9uB5FdbvLZ8PWJ nOR7cB5jrG30ivswJ5a6niJ3KSAe408hw0juqlZUZdeXZmEtpw7XuDXnu7O84EaQsy jqJgEj9zFnqXzap2+diYdjg9HyHYDY7bf2ngXkfgXwQLNY8kqW4ULTkAVSVZlDbOlk xFCnGzA8MR7id9NdzmZztuerRWOP4Ffmj2KcM+TXjT4PtfGN6RFkiG+WJOZdIdVjVB 9WdVmBosypPgaD+rilelboguNxbQ5SC13tkFhGRqIA8XtS2rXzfZPU7YwNc+QozGnp yNF/UqRls9diA== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4YmZcx0RD0z4wxm; Mon, 3 Feb 2025 16:22:25 +1100 (AEDT) Date: Mon, 3 Feb 2025 16:22:30 +1100 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH v3 09/20] Add interfaces and configuration bits for passt-repair Message-ID: References: <20250131193953.3034031-1-sbrivio@redhat.com> <20250131193953.3034031-10-sbrivio@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="sxtfF2TrQyfoqcd2" Content-Disposition: inline In-Reply-To: <20250131193953.3034031-10-sbrivio@redhat.com> Message-ID-Hash: GF2GKG2YQRSEBGQPPIZQEOBF6RXYVEV2 X-Message-ID-Hash: GF2GKG2YQRSEBGQPPIZQEOBF6RXYVEV2 X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, Laurent Vivier X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --sxtfF2TrQyfoqcd2 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jan 31, 2025 at 08:39:42PM +0100, Stefano Brivio wrote: > In vhost-user mode, by default, create a second UNIX domain socket > accepting connections from passt-repair, with the usual listener > socket. >=20 > When we need to set or clear TCP_REPAIR on sockets, we'll send them > via SCM_RIGHTS to passt-repair, who sets the socket option values we > ask for. >=20 > To that end, introduce batched functions to request TCP_REPAIR > settings on sockets, so that we don't have to send a single message > for each socket, on migration. When needed, repair_flush() will > send the message and check for the reply. >=20 > Signed-off-by: Stefano Brivio [snip] > +/** > + * repair_close() - Close connection to TCP_REPAIR helper > + * @c: Execution context > + */ > +void repair_close(struct ctx *c) > +{ > + debug("Closing TCP_REPAIR helper socket"); > + > + epoll_ctl(c->epollfd, EPOLL_CTL_DEL, c->fd_repair, NULL); This can be an epoll_del(), since you put the patch introducing that before this one in the series. --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --sxtfF2TrQyfoqcd2 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmegUpUACgkQzQJF27ox 2Gct3g/+Lz162cBhMZxVfwbkiWJ1AtMoAp0Anwc5nVrA7oeizNJiSiUZQs7nTLx9 gGhZEofIWBWY703bF7CRW4lks8gYh3QY3Cxg0DRjTIobBMYNGtmWHFi7UQuWcFKO w+XjzTnxa/B/ZbrKnMCNb+WSuNwpTqqAvCu1iln75vIZh6g9mDL4qygHBUr73OP2 z43PwlcDWJ/C/pc2e2OFd3GKnO9Dn4BA55ehq7tbiZeGlN5pNw6T6+UMymh34KXT sIGbOaXoWc2g5dwnynGxkc6Ge0WUkrXA0soGpvBTm4MaEA6L7KYqWPL+1WZsqXgS 78KJyLwHzEqNCRB5mHl7IEFT5y23to0ildDNPsvYTOVpmDumQlL8OP48YnFnlZ+M eMeKQZKhy3PLYB4wUvJGM5FOP3/WPCDMl/5jy74biqAzU83bsh76bAoa8rUN4RbS JPVwCxi1DRjHfiM++onTYQEHkdOFX5Jc2twsfi+iNtLBYFng9NoG338+MNUPVpS3 DAmweVmcZUj7Dc4sqdFKJjKSGspszcA2zQA+1iPXNBNpi2WOLzhWvgYpr6fLIHo+ j412NCp3UahjSGieCytHZ6DFI2iOhXt9GWmJzY9Yr0SwoNHAhDTUkL2bOEBYxae9 INNSRxVCUpD/i0SR7yeaWPnBep9mmuZJEznBB0cn/N8qmRFrVIo= =d58A -----END PGP SIGNATURE----- --sxtfF2TrQyfoqcd2--