From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202502 header.b=BjPTnVf2; dkim-atps=neutral Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id 5E5F35A0272 for ; Mon, 03 Feb 2025 10:25:19 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202502; t=1738574694; bh=4VBhr5lBd7IOJZUacCV4pDPqBtXm3cPd0M0v8dwKizc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BjPTnVf2xI9y2o7taFU9KWDu7spd32lf90W33VvZ1XlO2Mwgs23XP8/0dmcsBXMFA l9PBKUH5D7dCe/MY/CxBtWa1EsbyPT4/xdBz1zx2gcjC67Ev4jjcQlGZkY2YotaVsS Dtr5R9bdUpuyaNjj6v0KoqMJ5JWmsFO2UCIvz0oN0sg7W9Y+ZUFW+T3FEA1rO7aMqi VdiC0Owr+XKqlG3KMShi2IEozn0eP0gaa0xZH4zLFM57QmWx8NVWGX3FrUg4FUQ5zL vO48CWl3hlqPyvhHQs6itzVx4AvLGClZzRM9eXTTRwz1LV9jWqkh8YL3mrkzUBK66M gHti+9nr0hJlg== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4Ymh0k3Nwbz4wyl; Mon, 3 Feb 2025 20:24:54 +1100 (AEDT) Date: Mon, 3 Feb 2025 20:07:39 +1100 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH] tcp_splice, udp_flow: fcntl64() support on PPC64 depends on glibc version Message-ID: References: <20250203062525.1419524-1-sbrivio@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="GMePZ/YnG1dtCJnh" Content-Disposition: inline In-Reply-To: <20250203062525.1419524-1-sbrivio@redhat.com> Message-ID-Hash: SNVRLZGDMW2AQQG6ZBXYTNZRU5J6TC5K X-Message-ID-Hash: SNVRLZGDMW2AQQG6ZBXYTNZRU5J6TC5K X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --GMePZ/YnG1dtCJnh Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Feb 03, 2025 at 07:25:25AM +0100, Stefano Brivio wrote: > I explicitly added fcntl64() to the list of allowed system calls for > PPC64 a while ago, and now it turns out it's not available in recent > Debian builds. The warning from seccomp.sh is harmless because we > unconditionally try to enable fcntl() anyway, but take care of it > anyway. >=20 > Link: https://buildd.debian.org/status/fetch.php?pkg=3Dpasst&arch=3Dppc64= &ver=3D0.0%7Egit20250121.4f2c8e7-1&stamp=3D1737477147&raw=3D0 > Signed-off-by: Stefano Brivio Reviewed-by: David Gibson > --- > tcp_splice.c | 2 +- > udp_flow.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/tcp_splice.c b/tcp_splice.c > index 5db1d62..f048a82 100644 > --- a/tcp_splice.c > +++ b/tcp_splice.c > @@ -28,7 +28,7 @@ > * - FIN_SENT_0: FIN (write shutdown) sent to accepted socket > * - FIN_SENT_1: FIN (write shutdown) sent to target socket > * > - * #syscalls:pasta pipe2|pipe fcntl arm:fcntl64 ppc64:fcntl64 i686:fcntl= 64 > + * #syscalls:pasta pipe2|pipe fcntl arm:fcntl64 ppc64:fcntl64|fcntl i686= :fcntl64 > */ > =20 > #include > diff --git a/udp_flow.c b/udp_flow.c > index 7fae81d..83c2568 100644 > --- a/udp_flow.c > +++ b/udp_flow.c > @@ -174,7 +174,7 @@ cancel: > * @s_in: Source socket address, filled in by recvmmsg() > * @now: Timestamp > * > - * #syscalls fcntl arm:fcntl64 ppc64:fcntl64 i686:fcntl64 > + * #syscalls fcntl arm:fcntl64 ppc64:fcntl64|fcntl i686:fcntl64 > * > * Return: sidx for the destination side of the flow for this packet, or > * FLOW_SIDX_NONE if we couldn't find or create a flow. --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --GMePZ/YnG1dtCJnh Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmegh1oACgkQzQJF27ox 2GetrA//cYcE5Mjyl9H1/MrBQ3JhsKQ+VEO0cAVkcZn1mCsKratqhGvBO6L1LvNi p3Hkt1IMBJp9TZHCvhCMSlWUC+45dVCLMlqEyMYNQSpRqQ7AO0VwSC+PVPtVbIsY wecAVJZWSvnXDt+7KZc2uyek9AXa3kwu1lEWHE53eERSvO8DpSiSoaXQCW2zDoLi GREvV/L6+dWrHfSD28AtjBOs3Zljc4UndcthTi+emlp7p0jmpOJIEfnWizxSJI6/ J9f8l8axu+zEMckBJOQu5BxD8qfPY50l0abYJHuOlknxbvdK1Gva3g4ijKTblZ6e k8Q5XRxh02st78P0jpZKX7IwC3g08UnfbOs2kBq0BbvCa9LnzmEo0cbjcamvhtoN Wnky6QYu/ZSR5Eq9skcEs6xyGD0HsoeFpZBfCbl/cFDfzS/rJTsf7Pf7qfA+HaEV 7V4MasU2WL32mSsc/u4bAIUhrfy1PlNIOXGNnSK8xxivjXHPivWwn7Hf1CLuYs4Q Ykfxp9drTwOQKFp2tPNkrpj3exk+YmCK51P8eBclA5Fc82R3IqzUy0OYsS9Kb3Mu yUCPlA2ErcXohp7Vhum2QV3VElM4VKkBq2ywL/nmCakxUwdaWvyQgGQibN5hsJV+ fgqiErz/oJHQ8B/suIGaxiLpINSKJ98MHRXZHwHJWFc3WBQMOkw= =yohi -----END PGP SIGNATURE----- --GMePZ/YnG1dtCJnh--