From: David Gibson <david@gibson.dropbear.id.au>
To: Stefano Brivio <sbrivio@redhat.com>
Cc: Enrique Llorente <ellorent@redhat.com>, passt-dev@passt.top
Subject: Re: [PATCH] dhcp: Don't re-use request message for reply
Date: Mon, 3 Feb 2025 20:29:10 +1100 [thread overview]
Message-ID: <Z6CMZsIXtOH1Xdap@zatzit> (raw)
In-Reply-To: <20250201141330.59af1324@elisabeth>
[-- Attachment #1: Type: text/plain, Size: 839 bytes --]
On Sat, Feb 01, 2025 at 02:13:30PM +0100, Stefano Brivio wrote:
> On Fri, 31 Jan 2025 15:53:29 +0100
> Enrique Llorente <ellorent@redhat.com> wrote:
>
> > The logic composing the DHCP reply message is reusing the request
> > message to compose the it, this kind be problematic from a security
>
> Does "be problematic" imply "would be ... once we add longer options"?
>
> > context and may break the functionality.
>
> Which one? This is important to know for distribution maintainers and,
> ultimately, users.
Right, as a general rule commit messages be specific and concrete
about what the problem they're address is.
--
David Gibson (he or they) | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you, not the other way
| around.
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2025-02-03 9:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-31 14:53 [PATCH] dhcp: Don't re-use request message for reply Enrique Llorente
2025-02-01 13:13 ` Stefano Brivio
2025-02-03 9:19 ` Enrique Llorente Pastora
2025-02-03 9:24 ` Stefano Brivio
2025-02-03 9:29 ` David Gibson [this message]
2025-02-03 9:53 ` Enrique Llorente Pastora
2025-02-03 19:00 ` Stefano Brivio
2025-02-03 10:26 ` Enrique Llorente Pastora
2025-02-03 19:00 ` Stefano Brivio
2025-02-04 9:27 ` Enrique Llorente Pastora
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z6CMZsIXtOH1Xdap@zatzit \
--to=david@gibson.dropbear.id.au \
--cc=ellorent@redhat.com \
--cc=passt-dev@passt.top \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).