From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202502 header.b=fBj0Wu8M; dkim-atps=neutral Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id 597115A004E for ; Mon, 03 Feb 2025 10:29:21 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202502; t=1738574947; bh=bqlBxJobE0u/DRyWpjutQovVwWKkAThXvhbMeY3AyFw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fBj0Wu8MMoUnVlzMjZxqktNAueII1kngfUMsjGUqn3TdceouIZGHwsxDSod0085dR pZPvZo6/h6yIgVxbflEC5kmvlGFnBOCgtf+Eg8D7797eWR2ld5Dlo3gsryVxKrr1mF Kz0SQteJ0OMLvL048pFqQlKWVOp59kb+ZXNrR4gKc5UBIDvWmq9TjaJbCttuUxTzj1 7KZel98JvnPmBLPn8fonr/8cFAutwZuw9xTAh/GWFG4EQRgMN/ZLtIfFw97H+1URy5 uPNS2swEUHgrf6nWDmT60dpJNhbOq/aRcDwZlbqY+rv8YNCpOldis9Ir6d60rC1Spn GductnlulWJKA== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4Ymh5b6QCbz4wcw; Mon, 3 Feb 2025 20:29:07 +1100 (AEDT) Date: Mon, 3 Feb 2025 20:29:10 +1100 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH] dhcp: Don't re-use request message for reply Message-ID: References: <20250131145329.1835558-1-ellorent@redhat.com> <20250201141330.59af1324@elisabeth> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="3tMxBdlAtUwJ/Q1J" Content-Disposition: inline In-Reply-To: <20250201141330.59af1324@elisabeth> Message-ID-Hash: 4GOFE5XSPGG6KI3YI2UHSHCPOSUQTIPS X-Message-ID-Hash: 4GOFE5XSPGG6KI3YI2UHSHCPOSUQTIPS X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Enrique Llorente , passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --3tMxBdlAtUwJ/Q1J Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Feb 01, 2025 at 02:13:30PM +0100, Stefano Brivio wrote: > On Fri, 31 Jan 2025 15:53:29 +0100 > Enrique Llorente wrote: >=20 > > The logic composing the DHCP reply message is reusing the request > > message to compose the it, this kind be problematic from a security >=20 > Does "be problematic" imply "would be ... once we add longer options"? >=20 > > context and may break the functionality. >=20 > Which one? This is important to know for distribution maintainers and, > ultimately, users. Right, as a general rule commit messages be specific and concrete about what the problem they're address is. --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --3tMxBdlAtUwJ/Q1J Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmegjGUACgkQzQJF27ox 2GfZPQ/+MhtuPV6NDzG9dvMblb4NeEuPTd6totJPKxWrw9pHkjTXoyEo0bXJV7V2 Zx/gZcnKCNBrf8YNoF66q1NhWFxp2fifBaU8b+CvfvVR+s+/yAIS4KauFovfTBRI 65y11pCbB3O/sXObC57BPt9FeAMXpSp5FqZKPbomcSDjql5n5y5ODNzRW0EHSJ+o ZGUPhx4bpMJ+8fPyT0Mj60eb3Hn5n18hdLWBAuTuTYuWPkAU0dTJISXUJBQ1Yygr Zrap/8hzBY2JCrS7HTDF6xHpt7qte14GQ0ZW5C+3WQ7aUjKQcLIGOFmzRDdO8B5Z OKWcFrAEUNDsnROH8ubh0rSpx3uZ3w6LnI+1pohirGgOktvCaHP11Xd/PFcoIdBG PlnCnTHFa/cbdrLlVr6CIMVeOxRUBAuKTJQsdb6XOpMuUybFmhJewTjUsATSOf/d MviNxWL/PM7MmFJJP5zC6dqXmAMR4M1rcQurKqHDqqfZZiu/KPDp9ECn6CNKFLrl QPfWfXfXiuM1zKKvRa/RpqmGcZWg0oVJAqkzS8y47N5TqMYoqpCI+KL7Kr8/6pPH 7VeHDet5Qlbk+Sx2+EQnm0tjj5OEJP5QViGRWU1A42LTvNus+O7UKgq3FmqvX/Ei GML/ZUtNvvwSuMclh7pp7vq7FSw4YZnduvs6j7M4JQayEFV6rlU= =hy8w -----END PGP SIGNATURE----- --3tMxBdlAtUwJ/Q1J--