From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202502 header.b=ipZfupT9; dkim-atps=neutral Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id 28E445A0271 for ; Tue, 04 Feb 2025 04:35:28 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202502; t=1738640108; bh=9VkmZkqr4t1hilY9NGjoXBV42jkxPZ2Wq5Hmr4IutKc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ipZfupT9XuPai4W/MMu0Wtx7dTo4m9GvwMYhSbnjm9oF99B37FTQquouHNnN9Fvn9 1BPljuw9UNVLNeoUw5QiezUQuPTgzX54y7dZj64ToO/IYOPWdVrtgQaDwePsvlwoAc 0+HReDiWCCaE1WdN6j1jEC2Bb6G+jQlDAGU3OCyRL4WJCAsbFz2tcbPmnvTN53cD4C 8gBDPW64yle2CSz/x5AUD3gKtKvKN5EM9ODQ59F0rx1N7+UKKBT1NVA5TmK2kcLm/V f9S1Au0EEHXHq2l35wlmRpNzgpo8Ilovy7bl0saqImqkTAOPhKYS4fjZ7TyRzDOL1Y L3TgR0vBFgZ2Q== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4Yn8Bh4wPPz4wvb; Tue, 4 Feb 2025 14:35:08 +1100 (AEDT) Date: Tue, 4 Feb 2025 13:09:03 +1100 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH 3/5] migrate: Move repair_sock_init() to vu_init() Message-ID: References: <20250130083330.917030-1-david@gibson.dropbear.id.au> <20250130083330.917030-4-david@gibson.dropbear.id.au> <20250204014231.3b7fe0d6@elisabeth> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="FEQAHwbrbhddnzRq" Content-Disposition: inline In-Reply-To: <20250204014231.3b7fe0d6@elisabeth> Message-ID-Hash: 2DLJPU6RHG5TO2C7N2ZFQLDUADBNF3SZ X-Message-ID-Hash: 2DLJPU6RHG5TO2C7N2ZFQLDUADBNF3SZ X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --FEQAHwbrbhddnzRq Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Feb 04, 2025 at 01:42:31AM +0100, Stefano Brivio wrote: > On Thu, 30 Jan 2025 19:33:28 +1100 > David Gibson wrote: >=20 > > Currently we call repair_sock_init() immediately before > > tap_sock_unix_init(). However, this means it will be skipped if the > > vhost-user control fd is passed with --fd instead of being created at a > > specific path. >=20 > That's intended, because we might not have a path in that case. See > conf_open_files(). Hm, good point. We should probably make it conditional on actually having a path in that case. If --fd and --repair-path are used together, that should work, and at the moment it won't. > I know it's not perfectly consistent, but it's practical at the moment. >=20 > The alternative opens up complicated questions such as: should we have > a --fd-repair option? What should be the default path if only --fd is > given? This is really unnecessary right now. I don't think we can have an --fd-repair, since part of the security model for passt-repair is that it connects to passt, not the other way around. We could, however, require --repair path if you want to use migration with --fd. --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --FEQAHwbrbhddnzRq Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmehdr4ACgkQzQJF27ox 2GcHjQ//VUetRvaBU/vsGLuZnpRmrxN9SXNGfBfSWtMAeYEHoLxR8n/6S8SI2GVa aeIWCu13AlBLia0tR8mGvby6qzivVzuQOxEUY+syxYtHWZ7AwxWp+eh/iJIaCFF4 W+e/FgpmDP5vYx1XELW7WukxF0QVMX16A5ss/QK63Hb6Fr8pXK+UgGmRGSuOMmo7 +vCAWopajYzp6ynF8Ep4eINmeRJyZ3kgXk8JYWE2QUiF3PWjz1wjXNsOt6CHijDc 7LiIbySDZFSXGv3d8FG3Nyv3LttqfuKKyMM/GJ5snYaLqpSs0zBZlHFT4VYD75Jv qSMgPThxcAuscTBrU3fcUXp3xkN5HODiI38k0LdBrrA91y+IboMyFfuRxZiH+r/O TsFE9nWhsut7sMYmML0pZdWRQUhPct4D9l+cHpRCXcVs2SQGAXhra/QThbS6+Z5s HvD+lGTtnLk9G3whkhi4q7WizewtUQxIVuafgfPZjva5dLHXWMSmALVr01/CD6nv q0bmUYu/mPasw4pBF0/HQDsH52zzOSScdS4145fgRdR2Evvzlc2nzDcn465rcjHa pstpSWyXBu18iQaZaEMpBkhoQ1ydqGkOkEyqcYx/DoRNEfCaLCmoOmEQsZRUb01X tcXZRSyEB1g6LOqgmcd3fzJ2W0Z3j60Hyf9kwZ2/YFUTifbFb2Q= =6LU1 -----END PGP SIGNATURE----- --FEQAHwbrbhddnzRq--