From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202502 header.b=JH2e5G3L; dkim-atps=neutral Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id 35B385A0271 for ; Tue, 04 Feb 2025 04:43:15 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202502; t=1738640581; bh=L+r7eDndsoyOedEd+BlCUgm9ctH6ufZeKOY1Iw5cE8s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JH2e5G3LMZ6Mt7ePtTseNiuFLCuYlI9z+ZZU4OOYog5U5mFUKAwk61/I2viyQIbQb NfAOtXiCeRHNc7tf6a8GEyrkVYP1v0VzMRBY+bhnzBwVRwGJKa4/LtmyzG8Cw92FIS Ed0U9pbWQKQPAS/LdfxM39lFj4kUBXM3PBp+M/N5snFDEHjlYR9lTFiqQWTGwGZBAo fl5fnd/H4qszxEajArapsByiz0IfJAwFYHYKjSXzLVR/FAD5W2M7Zu/KGkrjUhhaUJ ElLj6RfAENT/7D7uRup6I/szwnyJ+c+OxoHBy8Fu/5L8/2EoUUjBxF1gefzyAATK7G KDs2eCzRkF2PQ== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4Yn8Mn40YWz4wc4; Tue, 4 Feb 2025 14:43:01 +1100 (AEDT) Date: Tue, 4 Feb 2025 14:43:07 +1100 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH v4 6/8] flow, tcp: Basic pre-migration source handler to dump sequence numbers Message-ID: References: <20250204004745.97854-1-sbrivio@redhat.com> <20250204004745.97854-7-sbrivio@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="xgzh/G52hP7Blt9E" Content-Disposition: inline In-Reply-To: <20250204004745.97854-7-sbrivio@redhat.com> Message-ID-Hash: 6NR673OBBQS4LMCR37YJNR3WSUV6X2YV X-Message-ID-Hash: 6NR673OBBQS4LMCR37YJNR3WSUV6X2YV X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --xgzh/G52hP7Blt9E Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Feb 04, 2025 at 01:47:43AM +0100, Stefano Brivio wrote: > Very much draft quality, but it works. Ask passt-repair to switch > TCP sockets to repair mode and dump their current sequence numbers to > the flow table, which will be transferred and used by the target in > the next step. [snip] > @@ -268,6 +270,7 @@ void migrate_close(struct ctx *c) > { > if (c->device_state_fd !=3D -1) { > debug("Closing migration channel, fd: %d", c->device_state_fd); > + epoll_del(c, c->device_state_fd); You have a stray revert hunks here again which breaks things horribly. And therefore makes me not confident that I'm actually testing the same code you are. > close(c->device_state_fd); > c->device_state_fd =3D -1; > c->device_state_result =3D -1; > @@ -282,14 +285,12 @@ void migrate_close(struct ctx *c) > */ > void migrate_request(struct ctx *c, int fd, bool target) > { > - debug("Migration requested, fd: %d (was %d)", > - fd, c->device_state_fd); > + debug("Migration requested, fd: %d", c->device_state_fd); > =20 > if (c->device_state_fd !=3D -1) > migrate_close(c); > =20 > c->device_state_fd =3D fd; > - c->migrate_target =3D target; And here. --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --xgzh/G52hP7Blt9E Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmehjMoACgkQzQJF27ox 2GcPuQ//VNJ28zpTRhk5u5pzguop2eFW0hRZv2on8iFEplAu2dt3oIhFsaVFpMKE GO/CRw2qoveg+W7H8ygvV1lzIBxG+8lNDfTON98faGSn0WxVzqMGMY5VEcP0WUAh WRsizhUaNHlhfU86+jJ6ice4xm9eXcpikqHUVfRFTqm3H0nmkjH2mPdEQNnUn5OW xSxUo9p2IlUJGkZfhbNZURoOEQSx8V97WA/5Ox3WYM2A6rfTwB0MQLky6fdbzFEW DJ06USMt1izf9GG7LI2im4pN9Yfx4eeWBkNrwnN81HH2SAKcLtFz9IXnR4te9NCh AOBK0BY7jzd3kkOnIk+pqay3/iFM6Q8C3RwyPECmWnh+1LIoe8WnG7LGaFuMJ9Xh KSta9uBwhC7ZgHNXxI+8uylnOCucUjcju3n31S/Y3l51+D4lxHPkWZZXM5LMpU0I xLl5/5e1rg4ESemrpUtPIZxTnVc+Xnb6Jg9L2EH3CTwNr2wLcP5KpdmT20mJzW0L ks1ivILmnSGTYX29QFBxQh+2/a5ht/TvBNBq9i569gS0lwF8+VV7rAELRMeMQucx SJKJb1VLxYuvwUJi4Ih7IaT76K6gtllayd/MtjQbWpaKPVt/5ac9WEiH33kGLK11 6ZcJy90WXgPAM9Eo2/Xek+FhyLQNz/oTzcc7SeKTxhnkA8WeGOM= =wJX2 -----END PGP SIGNATURE----- --xgzh/G52hP7Blt9E--