From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202502 header.b=jbSn36R+; dkim-atps=neutral Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id 8418D5A0272 for ; Tue, 04 Feb 2025 06:05:32 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202502; t=1738645518; bh=o/C7iQmlX7Rc0YZRBRqeyIhVeYd7blp6zzCHsj3orHo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jbSn36R+ia19LjW3A+WHgHoHZcJ6xIZh9SpXfFuUvxpX28LaewbyhmsnPevQkbxwg yD4KHX+2B07iGbjN3m+VgZTupXs0bXlkiZxuUePVWjOSMQ0qacee683DqcumbbVKjO 33FW+rEwFJikp2tQMTMiL+O7omZtIh1Ryo4es/OsdW2vq67JnoWYlXggK8F8kGn9Em fGu0tTyCqxyTnSh8xd9twYpvtCbLzxYJS1cOo6b0iQjJI9QgTSwF1It72IMGSg1APA srgvTDtu7LVRKprV3aTWdMDTZsUZqavp2ZrguP2cgQUCkD1bjm4SUlo0DxTX65D6sH Nl5vrwa6OEvVQ== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4YnBBk2LF6z4wcD; Tue, 4 Feb 2025 16:05:18 +1100 (AEDT) Date: Tue, 4 Feb 2025 14:59:39 +1100 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH] Introduce passt-repair Message-ID: References: <20250204000514.3811208-1-sbrivio@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ZXv6RqGX4u/1CClI" Content-Disposition: inline In-Reply-To: <20250204000514.3811208-1-sbrivio@redhat.com> Message-ID-Hash: IFYQBBTJGXJOE5ZGZ3B2F5YKE2SV5NOS X-Message-ID-Hash: IFYQBBTJGXJOE5ZGZ3B2F5YKE2SV5NOS X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --ZXv6RqGX4u/1CClI Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Feb 04, 2025 at 01:05:14AM +0100, Stefano Brivio wrote: > A privileged helper to set/clear TCP_REPAIR on sockets on behalf of > passt. Not used yet. >=20 > Signed-off-by: Stefano Brivio > --- > Note: I'm merging this right now, but posting anyway to ease review. [snip] > +/** > + * main() - Entry point and whole program with loop > + * @argc: Argument count, must be 2 > + * @argv: Argument: path of UNIX domain socket to connect to > + * > + * Return: 0 on success (EOF), 1 on error, 2 on usage error > + * > + * #syscalls:repair connect setsockopt write exit_group > + * #syscalls:repair socket s390x:socketcall i686:socketcall > + * #syscalls:repair recvfrom recvmsg arm:recv ppc64le:recv > + * #syscalls:repair sendto sendmsg arm:send ppc64le:send > + */ You are missing close() :(. --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --ZXv6RqGX4u/1CClI Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmehkKoACgkQzQJF27ox 2GdhBw/+I6QhfpzBj+a9QwoG83yvM++HstZzzWRe3gMc6rluD1bfNnfgIWDJK5x5 QV3eWBk4VLWKGncokkZs5OH3oeITt7yIbZvfMcU1akTKV2i8H/8Pelj91sRQEoHt 1AztYltA3AOEkoaSmUEeFqfocERQJTk9Y/T3B2j2mGSsLIFCp3cfcbcuxXn8g4u/ qeRjOkroelSgatgeAWF7ULUhB+LAq6sIppdCqbnhjm7fmCjCmvp0dawSXrq2Kvbu S7nLjA8VebKrEEL8JCwweQFsD+sjkfse3gZcgVbONLCj7swWhLc+cb5UqPUFc6cB FC8BxXZzkMpQir3b39ERGR9twk05HT4xWzOcoOP/AhBkTxN47NSMmoUOo1SNT3py /JG1Tgq/B1M8amIWWOBuC5nbCCpZ0TdwoBxxKtFoVepHo2qHQOZjDyguTL4p96zN aQfAYv1YCcO2AQ0NWhr1+JTZ6Q9CiONbvnMdJnyRh/B9UAYNyBfqdFY76HxKuXAJ /0+dxu5EDSw4e5Z9C2Wo9W3NwXgwfaDOp4fqVmUaZJnMBjuxlwxErbM7XUZPRd8J RJG/E8ETjRbhusfHLaNIGLLYFqboKsOVK58Cng6Omn+sj1wSB/a4TIrf9wGDnFN6 CCJY9DV3YQv17b0Zk0TBOwnCkVg9Aj3GFt/h00WdEKNeWiR1HzA= =mxPp -----END PGP SIGNATURE----- --ZXv6RqGX4u/1CClI--