From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202502 header.b=GBcyTtpy; dkim-atps=neutral Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id 489975A061B for ; Wed, 05 Feb 2025 02:02:11 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202502; t=1738717305; bh=qp6yIa847l34EK43n0wSVm3AIbleURINGe03TPfcZp4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GBcyTtpyt3UBz4b61b4BDpKbPA5uYKR1m2d5wRmd4To2pONgcqEiURXQxEjZpcGzS TnD2e1teYFJmVZyDoRMgD55k/K6ZUFhSIFKlWPyS3+XYNkT73yOWYAe9Q1wR9lJpuc yNrqOidb2dqs+0Q/IlmlXljw4O3f7C9pGToWGgnEfAgqpOFp8AsznFaMJowBC+3ccs /UhU8Vrfi7Uecd5wf2t7qTjjwkyBDXCwcOXWlmzaDPwgVz9ANzfSPDYMqCaO9isxt8 NMysWaG3n1yZuSFzKlrfhigUigoTQWXbrUF+3qOZDOcIMQePvis9/gIA5kndU2agI0 +qctDYpgLDJww== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4YnhlF3wvFz4wj2; Wed, 5 Feb 2025 12:01:45 +1100 (AEDT) Date: Wed, 5 Feb 2025 11:58:43 +1100 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH v4 6/8] flow, tcp: Basic pre-migration source handler to dump sequence numbers Message-ID: References: <20250204004745.97854-1-sbrivio@redhat.com> <20250204004745.97854-7-sbrivio@redhat.com> <20250204074410.5d0f5eb3@elisabeth> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="WcZm/1dBy0+7oq23" Content-Disposition: inline In-Reply-To: <20250204074410.5d0f5eb3@elisabeth> Message-ID-Hash: ANH4QCRJTZGL5KJQM6CKEEFEU3CSJRQB X-Message-ID-Hash: ANH4QCRJTZGL5KJQM6CKEEFEU3CSJRQB X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --WcZm/1dBy0+7oq23 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Feb 04, 2025 at 07:44:10AM +0100, Stefano Brivio wrote: > On Tue, 4 Feb 2025 14:43:07 +1100 > David Gibson wrote: >=20 > > On Tue, Feb 04, 2025 at 01:47:43AM +0100, Stefano Brivio wrote: > > > Very much draft quality, but it works. Ask passt-repair to switch > > > TCP sockets to repair mode and dump their current sequence numbers to > > > the flow table, which will be transferred and used by the target in > > > the next step. =20 > >=20 > > [snip] > > > @@ -268,6 +270,7 @@ void migrate_close(struct ctx *c) > > > { > > > if (c->device_state_fd !=3D -1) { > > > debug("Closing migration channel, fd: %d", c->device_state_fd); > > > + epoll_del(c, c->device_state_fd); =20 > >=20 > > You have a stray revert hunks here again which breaks things horribly. > > And therefore makes me not confident that I'm actually testing the > > same code you are. >=20 > Well, folding "[PATCH 6/6] migrate: Make migration handlers simpler and > more flexible" into the first patches, where it belongs, was a lot of > fun. Heh, fair point. > As I mentioned, I didn't test this one, I just build-tested the final > result. >=20 > > > close(c->device_state_fd); > > > c->device_state_fd =3D -1; > > > c->device_state_result =3D -1; > > > @@ -282,14 +285,12 @@ void migrate_close(struct ctx *c) > > > */ > > > void migrate_request(struct ctx *c, int fd, bool target) > > > { > > > - debug("Migration requested, fd: %d (was %d)", > > > - fd, c->device_state_fd); > > > + debug("Migration requested, fd: %d", c->device_state_fd); > > > =20 > > > if (c->device_state_fd !=3D -1) > > > migrate_close(c); > > > =20 > > > c->device_state_fd =3D fd; > > > - c->migrate_target =3D target; =20 > >=20 > > And here. >=20 > Can you please post the fixed rebase...? Ah, yeah, I've been thinking this way of posting patches back and forth hasn't been working great for this rapid iteration. On the other hand I was relucant to do the patch folding myself for fear of clobbering changes you were making concurrently to the same patches. I'll try posting the whole rebase and see how we go. --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --WcZm/1dBy0+7oq23 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmeit78ACgkQzQJF27ox 2Gd98g//ZjbUyXREhAntaMNMpGGQOuoaJDZgRZfyZKphh6JdIR5FttZp1m7MYTyQ Hk9b3WPCjboezV9FC4K/GCkmK0V8rBlHqmrWVgdUOmM3Q0sI7neVK6IodxjAjTuP 4crN/mdVGoBpdZAczKgHzyCRAH4Zm7ZydtodKxxRXIl4p38S6zREAWd75chMIFSS 72tB9Sizh9ZMRQZnQ7Ck2jDet7focbaT2r1ppfphxI5dhI5mwoEJDb4lpUW+1rxP dhGqfwvRdswna5uUk7cGY85K/SFCWeRmBLEYPV40fys3JfgHjrMZDIfzPrJCyCWL W/dCRUOMK7nyHLrkwinSRrBQ1dj6d0nsFSc/3Ox/ucK52BsQG1C6+Hkchpo2h/LR zZNTworIUdu/OJjcvya6bR2hmpR7qJ0u3Ld3dfHQeGhyZPP8BHzj2v1ye9dTarNI NjB9r1cO0L94mHGGhjTnwh+9AgmWTc8JhSB9K2GfPhQrTiMYdp2NIZ4n4sJOl6jL k0St2VUUJwNFxsd5yIrNprvECO7XjOR0H3Cw2Q+awdipgmxl/nkyoRhP5DrrRU0e JV5DC/KJCMVLwLu3g2GDhRlyxOzn9vbOEC8w4BAnBJT2HkHkxrA2KtLlB32+pSDv nFQhT+3ssYeTJnXzGEHu/eptdM7ddWUe9/b4fjsBxyuan1DmIDU= =Tbgw -----END PGP SIGNATURE----- --WcZm/1dBy0+7oq23--