From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202502 header.b=ThO1CmgL; dkim-atps=neutral Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id 1E6365A061C for ; Wed, 05 Feb 2025 02:40:41 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202502; t=1738719614; bh=ZUpe13NQ67hYwyxHNIpppuuyiHTlXcIxetSOttA5RT4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ThO1CmgL1k74AibNZcRiXITjASp78wwjavUj7jxiLITMhZT29Yq/DHABLvNW0IBz5 zfIXf+J6MKYCp0p2QBh5mP8GHYl3DcC8XOZJZGwn9MkHwMOFk31pQkctdr3mmL7nRd EXWbyHXDP3gvLqH03ImWkvb4QBE3yvflBlAdOBJN7nSVNEk2uqvd8oJ/2HCw5v+KSh SZUuN5jUlTMGdFwzqWHT+kjrYlT5ydx9nFwjF3Ed9JadLP4iabvZsHk+kGr3ksAeuQ BsP77CDXsFDG2pT5G2AoVjnJM+DsDaSwKgiDRvxF50kl8Xs30VEEzGnP5T6QWGvaAB jCL44YcvwFhDQ== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4Ynjbf5Hwkz4wnp; Wed, 5 Feb 2025 12:40:14 +1100 (AEDT) Date: Wed, 5 Feb 2025 12:10:10 +1100 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH v5 6/6] Implement source and target sides of migration Message-ID: References: <20250205003904.2797491-1-sbrivio@redhat.com> <20250205003904.2797491-7-sbrivio@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="sSS7wByGwYOM9O56" Content-Disposition: inline In-Reply-To: <20250205003904.2797491-7-sbrivio@redhat.com> Message-ID-Hash: A3N4M4NFE2ZANWAR3K22YOCMBNADIJKV X-Message-ID-Hash: A3N4M4NFE2ZANWAR3K22YOCMBNADIJKV X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, Laurent Vivier X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --sSS7wByGwYOM9O56 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Feb 05, 2025 at 01:39:04AM +0100, Stefano Brivio wrote: > This implements flow preparation on the source, transfer of data with > a format roughly inspired by struct tcp_tap_conn, and flow insertion > on the target, with all the appropriate window options, window > scaling, MSS, etc. >=20 > The target side is rather convoluted because we first need to create > sockets and switch them to repair mode, before we can apply options > that are *not* stored in the flow table. However, we don't want to > request repair mode for sockets one by one. So we need to do this in > several steps. >=20 > A hack in order to connect() on the "RARP" message should be easy to > enable, I left a couple of comments in that sense. >=20 > This is very much draft quality, but I tested the whole flow, and it > works for me. Window parameters and MSS match, too. >=20 > Signed-off-by: Stefano Brivio [snip] > diff --git a/isolation.c b/isolation.c > index c944fb3..df58bb8 100644 > --- a/isolation.c > +++ b/isolation.c > @@ -377,7 +377,7 @@ void isolate_postfork(const struct ctx *c) > { > struct sock_fprog prog; > =20 > - prctl(PR_SET_DUMPABLE, 0); > +// prctl(PR_SET_DUMPABLE, 0); Looks like a stray debugging change made it in here. Fwiw, I keep a branch around with debugging hacks including exactly this. To make it harder to accidentally leak debug hacks into "real" series, I usually rebase between my debugging branch and main. In this case it conflicted with the patch from my debugging branch, of course, which is why I spotted it. > =20 > switch (c->mode) { > case MODE_PASST: --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --sSS7wByGwYOM9O56 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmeiunEACgkQzQJF27ox 2GcGeBAAgbexl6WG7V4ZRrFH2abfHhpj5YSX/pONEBo/2RryEnMvt6XJNQLOrodV au+rBRGb6Ahj1zvbYZDOYwz2SMA/OyyVXC/g2dcMlAV2OoKSGhRDvB1HOKYDmGS9 lpJRPE6/XoxWX5MBVg3DdMm0qbzcQfyoKmlLvFVWW7OQlxZ9YK0CO0oPvAnnJRXD RK+F9cFT1TxA/3fpkcTTgmmwy2y/a7OeGOvVNYCvEDLGqbS4z7zRA55oHrLSLsKE wEqWe7+jOCnVcWFcus0+RsbHLe86nai9gNE9h59HN9ZevDy2FdJrveD5rJW6y0aP aHbDIr2+mpSMFUspgtf6BhiyehTNlwKLHPqwP9O5DBxwcX0oWNuDNaH5oVr712nT sbfl/X1RFjkTZSmPSU6ciqHuWN9Hjx+ZwOgG/grGzYUnheyNKb+QVvZrsuebLI1F 5zA8cKF8QP/f+svFZecjdwmGyCnXLyhzhC2rS1rtEe7f5Wa2vHOzBdiHWrl75oZC sx3m4VdhZLTyX5swfBdshklJwIhoMrBnkock6iuczogHX3Bn8Q1iTKnr8t4EyXiI PbB2S1geNNSWpKwvWlEJXqlwUWuYoHwugS5Xhnse3CUD5NKDtMNdst4GqoTUZ2K/ /zwMAPKqflucS44tPkliTvwmgz4FWAkD4fmyUBxf6uIZWxBpdQ0= =Y0GL -----END PGP SIGNATURE----- --sSS7wByGwYOM9O56--