From: David Gibson <david@gibson.dropbear.id.au>
To: Stefano Brivio <sbrivio@redhat.com>
Cc: passt-dev@passt.top
Subject: Re: [PATCH] passt-repair.1: Fix indication of TCP_REPAIR constants
Date: Thu, 6 Feb 2025 09:31:40 +1100 [thread overview]
Message-ID: <Z6PmzGirfHQjr8qa@zatzit> (raw)
In-Reply-To: <20250205160428.3782051-1-sbrivio@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1244 bytes --]
On Wed, Feb 05, 2025 at 05:04:28PM +0100, Stefano Brivio wrote:
> ...perhaps I should adopt the healthy habit of actually reading
> headers instead of using my mental copy.
>
> Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
> ---
> passt-repair.1 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/passt-repair.1 b/passt-repair.1
> index 8d07c97..7c1b140 100644
> --- a/passt-repair.1
> +++ b/passt-repair.1
> @@ -31,7 +31,7 @@ same as the UNIX domain socket used for guest communication, suffixed by
> \fI.repair\fR.
>
> The messages consist of one 8-bit signed integer that can be \fITCP_REPAIR_ON\fR
> -(1), \fITCP_REPAIR_OFF\fR (2), or \fITCP_REPAIR_OFF_WP\fR (-1), as defined by
> +(1), \fITCP_REPAIR_OFF\fR (0), or \fITCP_REPAIR_OFF_NO_WP\fR (-1), as defined by
> the Linux kernel user API, and one to SCM_MAX_FD (253) sockets as SCM_RIGHTS
> (see \fBunix\fR(7)) ancillary message, sent by the server, \fBpasst\fR(1).
>
--
David Gibson (he or they) | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you, not the other way
| around.
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2025-02-05 22:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-05 16:04 [PATCH] passt-repair.1: Fix indication of TCP_REPAIR constants Stefano Brivio
2025-02-05 22:31 ` David Gibson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z6PmzGirfHQjr8qa@zatzit \
--to=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).