From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202502 header.b=QdPWtFQX; dkim-atps=neutral Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id DABB95A061D for ; Wed, 05 Feb 2025 23:33:04 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202502; t=1738794758; bh=Yy9s4/KbNeabel+ddoqwQ1Guw/oXxM6jdCmH1Y3wvNo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=QdPWtFQXlVVWD6bLDJNsjCSCBqAAbNqvyXtBAedsBjIdm9k4uuEP5uDcOlo5Rhrfx juPCSuRs0fLLRJ06X21+blwqxzQC7f/x5RqHNalOl14WUoL8a2o3XIGQ0jUYJKeLhz r8FQjaPOzpf9MOTVv22gKNCnxzo+SPP6yAuEO1oa8bWWG2olMTjQCiEgo0NOhGT8+9 X6ns3SYQfJqPT9pKVs990zxI1gQGJXgWxJgroDWpNjSLDrMCvECv1tRrDvzFu4kcYz eqE7c7r1F1RbRDjlLIm+XC5rUsxtxjDY71tDbqb/q9/mXie7iOJ+X6BE8DSksO4ggD HeOCIq03PsRCg== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4YpFNk4hltz4wj2; Thu, 6 Feb 2025 09:32:38 +1100 (AEDT) Date: Thu, 6 Feb 2025 09:31:40 +1100 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH] passt-repair.1: Fix indication of TCP_REPAIR constants Message-ID: References: <20250205160428.3782051-1-sbrivio@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="E1dkXy/kitHQGWOA" Content-Disposition: inline In-Reply-To: <20250205160428.3782051-1-sbrivio@redhat.com> Message-ID-Hash: OVMOGSD2WW4ZE7Z4DHKFHPUYM75LWZ45 X-Message-ID-Hash: OVMOGSD2WW4ZE7Z4DHKFHPUYM75LWZ45 X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --E1dkXy/kitHQGWOA Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Feb 05, 2025 at 05:04:28PM +0100, Stefano Brivio wrote: > ...perhaps I should adopt the healthy habit of actually reading > headers instead of using my mental copy. >=20 > Signed-off-by: Stefano Brivio Reviewed-by: David Gibson > --- > passt-repair.1 | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/passt-repair.1 b/passt-repair.1 > index 8d07c97..7c1b140 100644 > --- a/passt-repair.1 > +++ b/passt-repair.1 > @@ -31,7 +31,7 @@ same as the UNIX domain socket used for guest communica= tion, suffixed by > \fI.repair\fR. > =20 > The messages consist of one 8-bit signed integer that can be \fITCP_REPA= IR_ON\fR > -(1), \fITCP_REPAIR_OFF\fR (2), or \fITCP_REPAIR_OFF_WP\fR (-1), as defin= ed by > +(1), \fITCP_REPAIR_OFF\fR (0), or \fITCP_REPAIR_OFF_NO_WP\fR (-1), as de= fined by > the Linux kernel user API, and one to SCM_MAX_FD (253) sockets as SCM_RI= GHTS > (see \fBunix\fR(7)) ancillary message, sent by the server, \fBpasst\fR(1= ). > =20 --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --E1dkXy/kitHQGWOA Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmej5ssACgkQzQJF27ox 2GdSqQ//dI8U+tJLzUFjwsjOwb51SF5fS2UklIjRsaIce2w9BO3NDxvIG9zRCQLy wVfMHiH6kaxrdRLxvDGCV7ckGnFvNewTACUO7gEEv6guHz3ECzCrV5sAwioFSgEA fjbYFnc4H+UvGOTu/aYvVwOszU3QnFVDUZFkqN7zuqeORcyZLSTlRacR1KxGX2Zf b0YfdM3pzD/8u26Q5ncGje+emqIRGiU7wktzPdU9gqtLI0KKySMY47pvlc84pADr bE0NyLINvNeVPxRoIwd3kfZU5NR9KC7QJSQVUyCyc0hTmX6CDumpMwLsMcJRhJ1e 5uQjy9RuIQb4ue2mL+Vp0H/6q4YIJS9keG3PkES9O7rx+7tyGytS6GPVHUYpxdp6 WEHJtN20+7Ghdq5rT7udBvEkWeu2CYFwXM9/QrzP62omaBSeUDUNS3xDmgk0Z85g WvCL3ZOnkaC/eELqqGPh6B2ws5KxosMNstF9EdTNqzRqEXzRWtrT2GPwevnQS5N7 0oENxEN6fwmoB972FA4+5dR+LeZApio6pMsOf5jxA3iPh2K32Yb5i4xoavLfZM2O y+E32TJyYkuA/HEW61PTnYvH88BvyHaehCK9XlQ01VVzx5igD0zPYflf2K1vZdgV BWeQNuz0bbKg8CgYIpQNZvw2cG9uAiPFWvrdp7c6Y3eq+T4XbIg= =3XuP -----END PGP SIGNATURE----- --E1dkXy/kitHQGWOA--