From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202502 header.b=U2YYVp3M; dkim-atps=neutral Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id 152C85A0271 for ; Thu, 06 Feb 2025 11:09:04 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202502; t=1738836529; bh=OsQynyfPZ9JRohY3d+vOqJmdlosMrkIBn2ek+M+AzRo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=U2YYVp3MmEqHIeEcBCQ91SYaAosOr5xrGyNcge04Yni8DfmSJF33MZMHozDDNvHTB ioS0rR4Vho7bi22mqOUzrXq79fooraFxkshW1/hw8lpo2dn2aFhN/wT8z7nsG1JbTj HoQASyeRXlRQpXeYb/VnucGlvU/GUNVzB/u0KPldcFE14dY2lPganS/fnf+rU+/xjv +JGyrIcLE02UpYczXr52bzo+ygqAU0zYkWPCnAKgP/bPts1mYUxLrqTYY9wlaFGBW1 izqQqMT0XumbZ//qVnlTDA8hFJRZK54jJ8IGxiWUpY3bFVseH+gtqbedSDOOv08X2I OhpcRkrR78Sqw== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4YpXr12rtdz4wyV; Thu, 6 Feb 2025 21:08:49 +1100 (AEDT) Date: Thu, 6 Feb 2025 20:30:59 +1100 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH] conf, passt.1: Un-deprecate --host-lo-to-ns-lo Message-ID: References: <20250206083957.892482-1-sbrivio@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="hp1y/u8WQQxOMWRW" Content-Disposition: inline In-Reply-To: <20250206083957.892482-1-sbrivio@redhat.com> Message-ID-Hash: MGYT5JR7XR5WFIVAW4C4Y3ZHPXCPG3VE X-Message-ID-Hash: MGYT5JR7XR5WFIVAW4C4Y3ZHPXCPG3VE X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --hp1y/u8WQQxOMWRW Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Feb 06, 2025 at 09:39:57AM +0100, Stefano Brivio wrote: > It was established behaviour, and it's now the third report about it: > users ask how to achieve the same functionality, and we don't have a > better answer yet. >=20 > The idea behind declaring it deprecated to start with, I guess, was > that we would eventually replace it by more flexible and generic > configuration options, which is still planned. But there's nothing > preventing us to alias this in the future to a particular > configuration. >=20 > So, stop scaring users off, and un-deprecate this. I concur. Reviewed-by: David Gibson >=20 > Link: https://archives.passt.top/passt-dev/20240925102009.62b9a0ce@elisab= eth/ > Link: https://github.com/rootless-containers/rootlesskit/pull/482#issueco= mment-2591855705 > Link: https://github.com/moby/moby/issues/48838 > Link: https://github.com/containers/podman/discussions/25243 > Signed-off-by: Stefano Brivio > --- > conf.c | 3 +-- > passt.1 | 2 +- > 2 files changed, 2 insertions(+), 3 deletions(-) >=20 > diff --git a/conf.c b/conf.c > index dcfc1d6..db7950e 100644 > --- a/conf.c > +++ b/conf.c > @@ -966,8 +966,7 @@ pasta_opts: > " -U, --udp-ns SPEC UDP port forwarding to init namespace\n" > " SPEC is as described above\n" > " default: auto\n" > - " --host-lo-to-ns-lo DEPRECATED:\n" > - " Translate host-loopback forwards to\n" > + " --host-lo-to-ns-lo Translate host-loopback forwards to\n" > " namespace loopback\n" > " --userns NSPATH Target user namespace to join\n" > " --netns PATH|NAME Target network namespace to join\n" > diff --git a/passt.1 b/passt.1 > index 63a3a01..395c0c6 100644 > --- a/passt.1 > +++ b/passt.1 > @@ -633,7 +633,7 @@ Configure UDP port forwarding from target namespace t= o init namespace. > Default is \fBauto\fR. > =20 > .TP > -.BR \-\-host-lo-to-ns-lo " " (DEPRECATED) > +.BR \-\-host-lo-to-ns-lo > If specified, connections forwarded with \fB\-t\fR and \fB\-u\fR from > the host's loopback address will appear on the loopback address in the > guest as well. Without this option such forwarded packets will appear --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --hp1y/u8WQQxOMWRW Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmekgU4ACgkQzQJF27ox 2Gedow//dc/GUf5pt+k+jth2zADLcOQoJfUrhD6iqSX6zR3IR/UEZXuvlgD2hh56 m2ZvA98/1ZrzFosVMpaUqDfpZME5wO1InJw0tWmPaI/KQIIHApK257qG7GDTMcWx vZ2M4xkhK/5Fz3F44QyZPo1l22676MZ2O+b+DPAs1Cbhb87dsUqePh1BCthvla8s iHtRCs27diYcfXUUkGtRbV2ZlmuV7Tior4ddUk6vY3gtArKpUf9K7NtGnNU1p1ov GISR7xqbKDEweELDxWE2GJc9j5wP6rdFBB/jXStMOWZynBVKvTtIUG0NlQotZuhf shZXV+pHLPi9riS39UK5ccl7nZMCNW6Uvftzk4xhmAlVpCAX9VZGRVXASF/+UT0P TnnL1OZlso2pXJ7/A4zVvIZkO3238GFDfESiPHk3016cKyxbpnammJdALXCcLYLA lbZJFYVoOprLZ7RaRJ1KjFYUqgjW5nqEMT9cobBTNAJNEITp6+S606R6Pd5X935O I2UY3mVStalGww6cBqf6Ui4fwGzoTivJvaL4G0AlOx6jXaoasG0MQXqGJJGOUNUG isMOaT4fFDyk1OWTACIhSw3rDgBOgFCA77YzAMaST3lh57V6F7fHLpA5XdllhCLu m+Ryt9+8VuTvNITKOEXNC0SiNnnyGsSEZ08aQO8fSBCJ/yMlna0= =pXP8 -----END PGP SIGNATURE----- --hp1y/u8WQQxOMWRW--